Skip to content

Commit 4f4f334

Browse files
[CI][workflows] Use node 20 by default
Signed-off-by: Marc Dumais <[email protected]>
1 parent e8d7e1d commit 4f4f334

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

.github/workflows/ci-cd.yml

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,19 @@ on:
88
release:
99
types:
1010
- published
11+
schedule:
12+
- cron: '0 4 * * *' # Runs every day at 4am: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#scheduled-events-schedule
13+
1114

1215
jobs:
1316

1417
build-test:
15-
name: Build and Test
18+
name: Build and Test (${{ matrix.os }}, node-${{ matrix.node-version }})
1619
runs-on: ${{ matrix.os }}
1720
strategy:
1821
matrix:
1922
os: [ubuntu-latest]
20-
node-version: [18]
23+
node-version: [18,20,22]
2124

2225
steps:
2326
- uses: actions/checkout@v4
@@ -32,19 +35,21 @@ jobs:
3235
run: yarn test
3336
- name: Package as VSCode Extension
3437
run: yarn vsce:package
35-
# Save the extension .vsix file for potential publishing
36-
# in later step (if appropriate)
38+
# Save the extension ().vsix file) for publishing in later step
39+
# (when appropriate)
3740
- uses: actions/upload-artifact@v4
3841
with:
3942
name: extension
4043
path: vscode-trace-server-*.vsix
44+
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/vscode-trace-server'
4145

4246
code-lint:
47+
name: Run linter (${{ matrix.os }})
4348
runs-on: ${{ matrix.os }}
4449
strategy:
4550
matrix:
4651
os: [ubuntu-latest]
47-
node-version: [18]
52+
node-version: [20]
4853

4954
steps:
5055
- name: Check out Git repository
@@ -61,14 +66,14 @@ jobs:
6166

6267
publish-oxsv:
6368
# https://open-vsx.org/
64-
name: Publish extension to public Open VSX Registry
69+
name: Publish extension to public Open VSX Registry (${{ matrix.os }})
6570
runs-on: ${{ matrix.os }}
6671
needs:
6772
- build-test
6873
strategy:
6974
matrix:
7075
os: [ubuntu-latest]
71-
node-version: [18]
76+
node-version: [20]
7277
# Only execute when the trigger was a tag (new release)
7378
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/vscode-trace-server'
7479

@@ -94,14 +99,14 @@ jobs:
9499

95100
publish-vs-marketplace:
96101
# https://marketplace.visualstudio.com/
97-
name: Publish extension to Visual Studio Marketplace
102+
name: Publish extension to Visual Studio Marketplace (${{ matrix.os }})
98103
runs-on: ${{ matrix.os }}
99104
needs:
100105
- build-test
101106
strategy:
102107
matrix:
103108
os: [ubuntu-latest]
104-
node-version: [18]
109+
node-version: [20]
105110
# Only execute when the trigger was a tag (new release)
106111
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/vscode-trace-server'
107112

.github/workflows/license-check-workflow.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ on:
1414
jobs:
1515

1616
License-check:
17-
name: 3PP License Check using dash-licenses
17+
name: 3PP License Check using dash-licenses (${{ matrix.os }})
1818

1919
strategy:
2020
fail-fast: false
2121
matrix:
2222
os: [ubuntu-latest]
23-
node: [18]
23+
node-version: [20]
2424
java: [11]
2525

2626
runs-on: ${{ matrix.os }}
@@ -35,7 +35,7 @@ jobs:
3535
- name: Use Node.js ${{ matrix.node }}
3636
uses: actions/setup-node@v4
3737
with:
38-
node-version: ${{ matrix.node }}
38+
node-version: ${{ matrix.node-version }}
3939

4040
- name: Use Java ${{ matrix.java }}
4141
uses: actions/setup-java@v3

0 commit comments

Comments
 (0)