Skip to content

Commit 5913235

Browse files
update to node 18
Fixes #29 Signed-off-by: Marc Dumais <[email protected]>
1 parent 10e5398 commit 5913235

File tree

5 files changed

+35
-18
lines changed

5 files changed

+35
-18
lines changed

.github/workflows/ci-cd.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ jobs:
1717
strategy:
1818
matrix:
1919
os: [ubuntu-latest]
20-
node-version: [16]
20+
node-version: [18]
2121

2222
steps:
23-
- uses: actions/checkout@v3
23+
- uses: actions/checkout@v4
2424
- name: Use Node.js ${{ matrix.node-version }}
25-
uses: actions/setup-node@v3
25+
uses: actions/setup-node@v4
2626
with:
2727
node-version: ${{ matrix.node-version }}
2828
- run: yarn --frozen-lockfile
@@ -44,12 +44,12 @@ jobs:
4444
strategy:
4545
matrix:
4646
os: [ubuntu-latest]
47-
node-version: [16]
47+
node-version: [18]
4848

4949
steps:
5050
- name: Check out Git repository
51-
uses: actions/checkout@v3
52-
- uses: actions/setup-node@v3
51+
uses: actions/checkout@v4
52+
- uses: actions/setup-node@v4
5353
with:
5454
node-version: ${{ matrix.node-version }}
5555
# ESLint and Prettier must be in `package.json`
@@ -68,17 +68,17 @@ jobs:
6868
strategy:
6969
matrix:
7070
os: [ubuntu-latest]
71-
node-version: [16]
71+
node-version: [18]
7272
# Only execute when the trigger was a tag (new release)
7373
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v')
7474

7575
steps:
76-
- uses: actions/checkout@v3
76+
- uses: actions/checkout@v4
7777
# restore extension from the built-test job
7878
- uses: actions/download-artifact@v4
7979
with:
8080
name: extension
81-
- uses: actions/setup-node@v3
81+
- uses: actions/setup-node@v4
8282
with:
8383
node-version: ${{ matrix.node-version }}
8484
- name: Install dependencies
@@ -101,16 +101,16 @@ jobs:
101101
strategy:
102102
matrix:
103103
os: [ubuntu-latest]
104-
node-version: [16]
104+
node-version: [18]
105105
# Only execute when the trigger was a tag (new release)
106106
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v')
107107

108108
steps:
109-
- uses: actions/checkout@v3
109+
- uses: actions/checkout@v4
110110
- uses: actions/download-artifact@v4
111111
with:
112112
name: extension
113-
- uses: actions/setup-node@v3
113+
- uses: actions/setup-node@v4
114114
with:
115115
node-version: ${{ matrix.node-version }}
116116
- name: Install dependencies

.github/workflows/license-check-workflow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ jobs:
2828

2929
steps:
3030
- name: Checkout
31-
uses: actions/checkout@v3
31+
uses: actions/checkout@v4
3232
with:
3333
fetch-depth: 2
3434

3535
- name: Use Node.js ${{ matrix.node }}
36-
uses: actions/setup-node@v3
36+
uses: actions/setup-node@v4
3737
with:
3838
node-version: ${{ matrix.node }}
3939

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
runs-on: ubuntu-latest
2020

2121
steps:
22-
- uses: actions/checkout@v3
22+
- uses: actions/checkout@v4
2323
with:
2424
fetch-depth: 0
2525
- uses: pipe-cd/[email protected]

README-dev.md

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ This file contains information that could be interesting to developers, that wan
44

55
For general information, see the main [README.md](README.md)
66

7-
87
* This is a TypeScript extension, officially named `vscode-trace-server`.
98
* It is meant as companion to the [vscode-trace-extension][vscode-trace-extension].
109
* It registers `Trace Server:` start/stop commands, for a default instance locally.
@@ -22,7 +21,25 @@ This README is the usual entry point for documenting this extension.
2221

2322
## Build
2423

25-
Run `yarn`, which should automatically include `yarn install`.
24+
First, you need Node.js and yarn:
25+
26+
It's suggested to install [nvm](https://github.com/nvm-sh/nvm#installing-and-updating) to manage node on your machine. Once that's done, install the required version:
27+
28+
```bash
29+
nvm install 18
30+
# optional: make it the default version
31+
nvm alias default
32+
# or set it every time like so
33+
nvm use 18
34+
```
35+
36+
Then install `yarn`:
37+
38+
```bash
39+
npm i -g yarn # the default version should be ok
40+
```
41+
42+
To build, run `yarn`, which should automatically trigger `yarn install`.
2643

2744
* This extension is bundled using `webpack`, originally based on [the guide][guide].
2845
* There is only a modest automated CI test suite being run on GitHub

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1554,7 +1554,7 @@ [email protected], js-yaml@^4.1.0:
15541554
dependencies:
15551555
argparse "^2.0.1"
15561556

1557-
"json-bigint@github:sidorares/json-bigint#2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473":
1557+
json-bigint@sidorares/json-bigint#2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473:
15581558
version "1.0.0"
15591559
resolved "https://codeload.github.com/sidorares/json-bigint/tar.gz/2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473"
15601560
dependencies:

0 commit comments

Comments
 (0)