Skip to content

Commit 99a5c0e

Browse files
authored
Adopt special review process officially (#1347)
There are occassionally PRs that improve CDT in areas where there is not enough current Eclipse CDT committer experience to provide detailed reviews. Therefore the Eclipse CDT project adopted (in [Oct 2023 call](https://hackmd.io/@jonahgraham/cdt-call-october-11-2023) and reaffirmed in [Oct 2025 call](#1340)) that such if the code looks correct and it is sufficiently tested it is ok to accept these changes. Examples of previous times this policy has been adopted include [PR #587](#587 (comment)), [PR #581](#581 (review)) and others, particularly in the [language support category](https://github.com/eclipse-cdt/cdt/pulls?q=is%3Apr+is%3Aclosed+label%3Alanguage+). This policy can be referenced by a CDT committer/reviewer in the approval process.
1 parent c6feff5 commit 99a5c0e

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

POLICY.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,4 +103,11 @@ All public API classes and interfaces must have meaningful javadoc header, as we
103103

104104
See [Eclipse Version Numbering Guildlines](https://wiki.eclipse.org/Version_Numbering)
105105

106+
## Special Review Process
106107

108+
There are occassionally PRs that improve CDT in areas where there is not enough current Eclipse CDT committer experience to provide detailed reviews.
109+
Therefore the Eclipse CDT project adopted (in [Oct 2023 call](https://hackmd.io/@jonahgraham/cdt-call-october-11-2023) and reaffirmed in [Oct 2025 call](https://github.com/eclipse-cdt/cdt/discussions/1340)) that such if the code looks correct and it is sufficiently tested it is ok to accept these changes.
110+
111+
Examples of previous times this policy has been adopted include [PR #587](https://github.com/eclipse-cdt/cdt/pull/587#issuecomment-1871507053), [PR #581](https://github.com/eclipse-cdt/cdt/pull/581#pullrequestreview-1798433846) and others, particularly in the [language support category](https://github.com/eclipse-cdt/cdt/pulls?q=is%3Apr+is%3Aclosed+label%3Alanguage+).
112+
113+
This policy can be referenced by a CDT committer/reviewer in the approval process.

0 commit comments

Comments
 (0)