Skip to content

Commit 2d78ba8

Browse files
authored
chore: PULL_REQUEST_TEMPLATE.md (#2051)
* chore: PULL_REQUEST_TEMPLATE.md Signed-off-by: Anatolii Bazko <[email protected]>
1 parent 0805258 commit 2d78ba8

File tree

1 file changed

+23
-13
lines changed

1 file changed

+23
-13
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,28 +21,40 @@ che-operator Development Guide: https://github.com/eclipse-che/che-operator/#dev
2121
- steps to reproduce
2222
-->
2323

24-
1. Prepare a patch file if needed:
24+
1. Deploy the operator:
25+
26+
#### OpenShift
2527
```bash
26-
cat > /tmp/cr-patch.yaml <<EOF
27-
apiVersion: org.eclipse.che/v2
28-
kind: CheCluster
29-
spec: {}
30-
EOF
28+
./build/scripts/olm/test-catalog-from-sources.sh
3129
```
3230

33-
2. Deploy the operator:
34-
35-
#### OpenShift
31+
or
32+
3633
```bash
37-
./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml
34+
build/scripts/docker-run.sh /bin/bash -c "
35+
oc login \
36+
--token=<...> \
37+
--server=<...> \
38+
--insecure-skip-tls-verify=true && \
39+
build/scripts/olm/test-catalog-from-sources.sh
40+
"
3841
```
3942

43+
2.
44+
4045
#### on Minikube
4146

4247
```bash
43-
./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml
48+
./build/scripts/minikube-tests/test-operator-from-sources.sh
4449
```
4550

51+
#### Common Test Scenarios
52+
- [ ] Deploy Eclipse Che
53+
- [ ] Start an empty workspace
54+
- [ ] Open terminal and build/run an image
55+
- [ ] Stop a workspace
56+
- [ ] Check operator logs for reconciliation errors or infinite reconciliation loops
57+
4658
### PR Checklist
4759

4860
[As the author of this Pull Request I made sure that:](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#pull-request-template-and-its-checklist)
@@ -51,9 +63,7 @@ EOF
5163
- [ ] [Code produced is complete](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-produced-is-complete)
5264
- [ ] [Code builds without errors](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-builds-without-errors)
5365
- [ ] [Tests are covering the bugfix](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#tests-are-covering-the-bugfix)
54-
- [ ] [Development resource are up to date](https://github.com/eclipse-che/che-operator/blob/main/README.md#update-development-resources)
5566
- [ ] [The repository devfile is up to date and works](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#the-repository-devfile-is-up-to-date-and-works)
56-
- [ ] [Sections `What issues does this PR fix or reference` and `How to test this PR` completed](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#sections-what-issues-does-this-pr-fix-or-reference-and-how-to-test-this-pr-completed)
5767
- [ ] [Relevant user documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated)
5868
- [ ] [Relevant contributing documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated)
5969
- [ ] [CI/CD changes implemented, documented and communicated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#cicd-changes-implemented-documented-and-communicated)

0 commit comments

Comments
 (0)