fix : reset workspace storage defaults when PVC config removed (#2061)

Previously, removing a workspace PVC Config (e.g., `perUserStrategyPvcConfig`)
did not reset workspaceConfig fields. As a result, stale values in persisted
instead of reverting to defaults.

This change explicitly resets:
- `StorageAccessMode` to `{ReadWriteOnce}`
- `StorageClassName` to `nil`
- `DefaultStorageSize` to `nil`

before applying any PVC config, ensuring that removing PVC config restores default
workspace storage settings.

Signed-off-by: Rohan Kumar <[email protected]>

Author: rohanKanojia

pkg/deploy/dev-workspace-config/dev_workspace_config.go

@@ -176,7 +176,9 @@ func updateWorkspaceStorageConfig(devEnvironments *chev2.CheClusterDevEnvironmen
 		constants.CommonPVCStorageStrategy:       devEnvironments.Storage.PerUserStrategyPvcConfig,
 		constants.PerWorkspacePVCStorageStrategy: devEnvironments.Storage.PerWorkspaceStrategyPvcConfig,
 	}[pvcStrategy]
-
+	workspaceConfig.StorageAccessMode = nil
+	workspaceConfig.StorageClassName = nil
+	workspaceConfig.DefaultStorageSize = nil
 	if pvc != nil {
 		workspaceConfig.StorageAccessMode = pvc.StorageAccessMode
 		if pvc.StorageClass != "" {

pkg/deploy/dev-workspace-config/dev_workspace_config_test.go

@@ -175,6 +175,28 @@ func TestReconcileDevWorkspaceConfigStorage(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "Not setting PerUserStrategyPvcConfig should reset DevWorkspaceConfig to default StorageAccessMode",
+			cheCluster: &chev2.CheCluster{
+				ObjectMeta: metav1.ObjectMeta{
+					Namespace: "eclipse-che",
+					Name:      "eclipse-che",
+				},
+				Spec: chev2.CheClusterSpec{
+					DevEnvironments: chev2.CheClusterDevEnvironments{
+						DisableContainerBuildCapabilities: pointer.Bool(true),
+						Storage: chev2.WorkspaceStorage{
+							PvcStrategy: constants.PerUserPVCStorageStrategy,
+						},
+					},
+				},
+			},
+			expectedOperatorConfig: &controllerv1alpha1.OperatorConfiguration{
+				Workspace: &controllerv1alpha1.WorkspaceConfig{
+					DeploymentStrategy: "Recreate",
+				},
+			},
+		},
 		{
 			name: "Create DevWorkspaceOperatorConfig with nil StorageAccessMode",
 			cheCluster: &chev2.CheCluster{