chore: Enable ErrorProne plugin (#876)

Author: vinokurig

.mvn/jvm.config

@@ -1 +1,11 @@
--Xmx2048m -Xms1024m -Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Dgwt.compiler.localWorkers=1
+-Xmx2048m -Xms1024m -Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Dgwt.compiler.localWorkers=1
+--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
+--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
+--add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED
+--add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED

infrastructures/kubernetes/src/test/java/org/eclipse/che/workspace/infrastructure/kubernetes/devfile/ContainerSearchTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2021 Red Hat, Inc.
+ * Copyright (c) 2012-2025 Red Hat, Inc.
  * This program and the accompanying materials are made
  * available under the terms of the Eclipse Public License 2.0
  * which is available at https://www.eclipse.org/legal/epl-2.0/
@@ -44,6 +44,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import org.testng.Assert;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
@@ -355,12 +356,10 @@ public void shouldConsiderEmptySelectorAsNotPresent() {
   }
 
   private static void assertContainsContainer(Collection<Container> containers, String name) {
-    containers.stream()
-        .filter(c -> name.equals(c.getName()))
-        .findAny()
-        .orElseThrow(
-            () ->
-                new AssertionError(
-                    format("Expected a container called %s but didn't find any.", name)));
+    Optional<Container> containerOptional =
+        containers.stream().filter(c -> name.equals(c.getName())).findAny();
+    if (containerOptional.isEmpty()) {
+      throw new AssertionError(format("Expected a container called %s but didn't find any.", name));
+    }
   }
 }

pom.xml

@@ -52,7 +52,7 @@
         <com.fasterxml.jackson.version>2.20.0</com.fasterxml.jackson.version>
         <com.github.kirviq.dumbster.version>1.7.1</com.github.kirviq.dumbster.version>
         <com.google.code.guice.version>5.0.1</com.google.code.guice.version>
-        <com.google.errorprone>2.3.4</com.google.errorprone>
+        <com.google.errorprone>2.42.0</com.google.errorprone>
         <com.google.guava.version>32.1.2-jre</com.google.guava.version>
         <com.google.http-client.version>2.0.2</com.google.http-client.version>
         <com.google.oauth-client.version>1.34.1</com.google.oauth-client.version>
@@ -2035,7 +2035,8 @@
                             <release>${java.target.version}</release>
                             <compilerArgs>
                                 <arg>-XDcompilePolicy=simple</arg>
-<!--                                <arg>-Xplugin:ErrorProne</arg>-->
+                                <arg>--should-stop=ifError=FLOW</arg>
+                                <arg>-Xplugin:ErrorProne</arg>
                             </compilerArgs>
                             <annotationProcessorPaths>
                                 <path>

wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/jpa/JpaFactoryDao.java

@@ -101,7 +101,7 @@ public Page<FactoryImpl> getByAttributes(
       int maxItems, int skipCount, List<Pair<String, String>> attributes) throws ServerException {
     checkArgument(maxItems >= 0, "The number of items to return can't be negative.");
     checkArgument(
-        skipCount >= 0 && skipCount <= Integer.MAX_VALUE,
+        skipCount >= 0,
         "The number of items to skip can't be negative or greater than " + Integer.MAX_VALUE);
     try {
       LOG.debug(

wsmaster/che-core-api-factory/src/test/java/org/eclipse/che/api/factory/server/impl/SourceProjectParametersValidatorTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2018 Red Hat, Inc.
+ * Copyright (c) 2012-2025 Red Hat, Inc.
  * This program and the accompanying materials are made
  * available under the terms of the Eclipse Public License 2.0
  * which is available at https://www.eclipse.org/legal/epl-2.0/
@@ -11,6 +11,7 @@
  */
 package org.eclipse.che.api.factory.server.impl;
 
+import com.google.common.collect.ImmutableMap;
 import java.util.HashMap;
 import org.eclipse.che.api.core.ConflictException;
 import org.eclipse.che.api.core.factory.FactoryParameter;
@@ -34,15 +35,18 @@ public void setUp() throws Exception {
             .withLocation("location")
             .withType("git")
             .withParameters(
-                new HashMap<String, String>() {
-                  {
-                    put("branch", "master");
-                    put("commitId", "123456");
-                    put("keepVcs", "true");
-                    put("fetch", "12345");
-                    put("keepDir", "/src");
-                  }
-                });
+                new HashMap<>(
+                    ImmutableMap.of(
+                        "branch",
+                        "master",
+                        "commitId",
+                        "123456",
+                        "keepVcs",
+                        "true",
+                        "fetch",
+                        "12345",
+                        "keepDir",
+                        "/src")));
   }
 
   @Test

wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/model/impl/devfile/ComponentImpl.java

@@ -480,8 +480,8 @@ public boolean equals(Object o) {
       return false;
     }
     ComponentImpl component = (ComponentImpl) o;
-    return getMountSources() == component.getMountSources()
-        && getAutomountWorkspaceSecrets() == component.getAutomountWorkspaceSecrets()
+    return Objects.equals(getMountSources(), component.getMountSources())
+        && Objects.equals(getAutomountWorkspaceSecrets(), component.getAutomountWorkspaceSecrets())
         && Objects.equals(generatedId, component.generatedId)
         && Objects.equals(alias, component.alias)
         && Objects.equals(type, component.type)