fixup! Add Azure DevOps Server support

Author: vinokurig

wsmaster/che-core-api-factory-gitlab-common/pom.xml

@@ -31,6 +31,10 @@
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.google.code.gson</groupId>
+            <artifactId>gson</artifactId>
+        </dependency>
         <dependency>
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>

wsmaster/che-core-api-factory-gitlab-common/src/main/java/org/eclipse/che/api/factory/server/gitlab/AbstractGitlabUrlParser.java

@@ -16,6 +16,7 @@
 import static java.util.regex.Pattern.compile;
 import static org.eclipse.che.commons.lang.StringUtils.trimEnd;
 
+import com.google.gson.JsonParser;
 import jakarta.validation.constraints.NotNull;
 import java.net.URI;
 import java.util.ArrayList;
@@ -112,15 +113,27 @@ private boolean isApiRequestRelevant(String repositoryUrl) {
         // belongs to Gitlab.
         gitlabApiClient.getOAuthTokenInfo("");
       } catch (ScmUnauthorizedException e) {
-        // the error message is a JSON if it is a response from Gitlab.
-        return e.getMessage().startsWith("{");
+        // Some Git providers e.g. Azure Devops Server, may return unauthorized exception on invalid
+        // API request, but Gitlab API returns unauthorized error message in JSON format, so to be
+        // sure that the URL belongs to Gitlab, we need to check if the error message is a valid
+        // JSON.
+        return isJsonValid(e.getMessage());
       } catch (ScmItemNotFoundException | IllegalArgumentException | ScmCommunicationException e) {
         return false;
       }
     }
     return false;
   }
 
+  private boolean isJsonValid(String message) {
+    try {
+      new JsonParser().parse(message).getAsJsonObject();
+      return true;
+    } catch (Exception exception) {
+      return false;
+    }
+  }
+
   private Optional<Matcher> getPatternMatcherByUrl(String url) {
     URI uri =
         URI.create(

wsmaster/che-core-api-factory-gitlab/src/test/java/org/eclipse/che/api/factory/server/gitlab/GitlabUrlParserTest.java

@@ -101,7 +101,11 @@ public void shouldValidateUrlByApiRequest() {
     String url = wireMockServer.url("/user/repo");
     stubFor(
         get(urlEqualTo("/oauth/token/info"))
-            .willReturn(aResponse().withStatus(401).withBody("{error}")));
+            .willReturn(
+                aResponse()
+                    .withStatus(401)
+                    .withBody(
+                        "{\"error\":\"invalid_token\",\"error_description\":\"The access token is invalid\",\"state\":\"unauthorized\"}")));
 
     // when
     boolean result = gitlabUrlParser.isValid(url);
@@ -110,6 +114,21 @@ public void shouldValidateUrlByApiRequest() {
     assertTrue(result);
   }
 
+  @Test
+  public void shouldNotValidateUrlByApiRequestWithPlainStringResponse() {
+    // given
+    String url = wireMockServer.url("/user/repo");
+    stubFor(
+        get(urlEqualTo("/oauth/token/info"))
+            .willReturn(aResponse().withStatus(401).withBody("plain string error")));
+
+    // when
+    boolean result = gitlabUrlParser.isValid(url);
+
+    // then
+    assertFalse(result);
+  }
+
   @Test
   public void shouldNotValidateUrlByApiRequest() {
     // given