File tree Expand file tree Collapse file tree 2 files changed +6
-1
lines changed
Expand file tree Collapse file tree 2 files changed +6
-1
lines changed Original file line number Diff line number Diff line change 3535 steps :
3636 - uses : actions/setup-node@v3
3737 with :
38- node-version : ' 16 '
38+ node-version : ' 18 '
3939 registry-url : ' https://registry.npmjs.org'
4040 scope : ' @eclipse-che'
4141 -
Original file line number Diff line number Diff line change @@ -28,6 +28,7 @@ Automated lint checking and code format performs with ESLint and Prettier tools
2828### Preferable code style
2929
30301 . Page-object and util classes
31+
3132 1 . ✔ Class declaration using dependency injection (inversify library)
3233
3334 ```
@@ -37,6 +38,7 @@ Automated lint checking and code format performs with ESLint and Prettier tools
3738 ```
3839
3940 2. Public methods
41+
4042 - ✔ Declare public methods without "public "keyword
4143 - ✔ Add Logger.debug() inside method to log its name (with optional message)
4244
@@ -49,6 +51,7 @@ Automated lint checking and code format performs with ESLint and Prettier tools
4951 ```
5052
5153 3. Locators
54+
5255 - ✔ For static locators - private static readonly fields type of By
5356
5457 ```
@@ -102,6 +105,7 @@ Automated lint checking and code format performs with ESLint and Prettier tools
102105 ```
103106
1041072. Mocha framework
108+
105109 - ✔ TDD framework (`suite()`, `test()`)
106110 - ✔ Inject class instances, declare all test data inside test `suit()` function to avoid unnecessary code execution if test suit will not be run
107111
@@ -118,6 +122,7 @@ Automated lint checking and code format performs with ESLint and Prettier tools
118122 - ✔ Use test [./constants](constants) to make test flexible
119123
1201243. Packages
125+
121126 1. Add packages as dev dependencies
122127 2. If any changes re-create package-lock.json before push
123128
You can’t perform that action at this time.
0 commit comments