Fix timeout in waitDisappearance method calls in DexLoginPage; fix PR check (#23705)

* Fix waitDisappearance method calls in Dashboard and DexLoginPage to use attempts and polling interval
* Treat a 500 server error as normal when the workspace was deleted
--
Assisted-by: Claude Code

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Author: dmytro-ndp

tests/e2e/pageobjects/dashboard/Dashboard.ts

@@ -168,7 +168,8 @@ export class Dashboard {
 	async waitStartingPageLoaderDisappearance(timeout: number = TIMEOUT_CONSTANTS.TS_COMMON_DASHBOARD_WAIT_TIMEOUT): Promise<void> {
 		Logger.debug();
 
-		await this.driverHelper.waitDisappearance(Dashboard.STARTING_PAGE_LOADER, timeout);
+		const attempts: number = Math.ceil(timeout / TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING);
+		await this.driverHelper.waitDisappearance(Dashboard.STARTING_PAGE_LOADER, attempts, TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING);
 		await this.driverHelper.wait(TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING);
 	}
 
@@ -211,7 +212,12 @@ export class Dashboard {
 		await this.openDashboard();
 		await this.driverHelper.waitAndClick(Dashboard.USER_SETTINGS_DROPDOWN, timeout);
 		await this.driverHelper.waitAndClick(Dashboard.LOGOUT_BUTTON, timeout);
-		await this.driverHelper.waitDisappearance(Dashboard.USER_SETTINGS_DROPDOWN, timeout);
+		const attempts: number = Math.ceil(timeout / TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING);
+		await this.driverHelper.waitDisappearance(
+			Dashboard.USER_SETTINGS_DROPDOWN,
+			attempts,
+			TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING
+		);
 	}
 
 	async clickContinueWithDefaultDevfileButton(timeout: number = TIMEOUT_CONSTANTS.TS_CLICK_DASHBOARD_ITEM_TIMEOUT): Promise<void> {

tests/e2e/pageobjects/login/kubernetes/DexLoginPage.ts

@@ -54,6 +54,11 @@ export class DexLoginPage {
 	async waitDexLoginPageDisappearance(): Promise<void> {
 		Logger.debug();
 
-		await this.driverHelper.waitDisappearance(DexLoginPage.DEX_PAGE_CONTENT_CONTAINER, TIMEOUT_CONSTANTS.TS_SELENIUM_LOAD_PAGE_TIMEOUT);
+		const attempts: number = Math.ceil(TIMEOUT_CONSTANTS.TS_SELENIUM_LOAD_PAGE_TIMEOUT / TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING);
+		await this.driverHelper.waitDisappearance(
+			DexLoginPage.DEX_PAGE_CONTENT_CONTAINER,
+			attempts,
+			TIMEOUT_CONSTANTS.TS_SELENIUM_DEFAULT_POLLING
+		);
 	}
 }

tests/e2e/utils/workspace/TestWorkspaceUtil.ts

@@ -103,10 +103,10 @@ export class TestWorkspaceUtil implements ITestWorkspaceUtil {
 			deleteWorkspaceResponse = await this.processRequestHandler.delete(deleteWorkspaceApiUrl);
 		} catch (error) {
 			if (axios.isAxiosError(error) && error.response?.status === 404) {
-				Logger.error(`the workspace :${workspaceName} not found`);
-				throw error;
+				Logger.info(`Workspace ${workspaceName} not found, already deleted`);
+				return;
 			}
-			Logger.error(`delete workspace call failed. URL used: ${deleteWorkspaceStatus}`);
+			Logger.error(`delete workspace call failed. URL used: ${deleteWorkspaceApiUrl}`);
 			throw error;
 		}
 
@@ -117,12 +117,16 @@ export class TestWorkspaceUtil implements ITestWorkspaceUtil {
 		for (let i: number = 0; i < this.attempts; i++) {
 			try {
 				deleteWorkspaceResponse = await this.processRequestHandler.get(deleteWorkspaceApiUrl);
+				Logger.trace(
+					`GET ${deleteWorkspaceApiUrl} returned status: ${deleteWorkspaceResponse.status}; data: ${deleteWorkspaceResponse.data}`
+				);
 			} catch (error) {
-				if (axios.isAxiosError(error) && error.response?.status === 404) {
+				if (axios.isAxiosError(error) && (error.response?.status === 404 || error.response?.status === 500)) {
 					deleteWorkspaceStatus = true;
 					Logger.debug(`${workspaceName} deleted successfully`);
 					break;
 				}
+				Logger.trace(`GET ${deleteWorkspaceApiUrl} threw error: ${error}`);
 			}
 			await this.driverHelper.wait(this.polling);
 		}