Convert some Predicate to lambdas

Remove some useless javadoc tags while editing the files.

Author: akurtakov

chemclipse/plugins/org.eclipse.chemclipse.converter/src/org/eclipse/chemclipse/converter/core/IConverterSupport.java

@@ -1,12 +1,12 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2025 Lablicate GmbH.
+ * Copyright (c) 2008, 2026 Lablicate GmbH.
  *
  * This program and the accompanying materials are made
  * available under the terms of the Eclipse Public License 2.0
  * which is available at https://www.eclipse.org/legal/epl-2.0/
  *
  * SPDX-License-Identifier: EPL-2.0
- * 
+ *
  * Contributors:
  * Philip Wenig - initial API and implementation
  * Christoph Läubrich - simplify API, deprecate individual getters in favor to a new filter approach
@@ -37,8 +37,6 @@ public interface IConverterSupport {
 	 * The filter extension are the specific chromatogram file extensions.
 	 * Agilent has for example an filter extension (.D) which represents a
 	 * chromatogram.
-	 * 
-	 * @return String[]
 	 */
 	default String[] getFilterExtensions(Predicate<? super ISupplier> filter) {
 
@@ -64,8 +62,6 @@ default String[] getFilterExtensions(Predicate<? super ISupplier> filter) {
 	 * The filter names are the specific chromatogram file names to be displayed
 	 * for example in the SWT FileDialog. Agilent has for example an filter name
 	 * "Agilent Chromatogram (.D)".
-	 * 
-	 * @return String[]
 	 */
 	default String[] getFilterNames(Predicate<? super ISupplier> filter) {
 
@@ -80,22 +76,10 @@ default String[] getFilterNames(Predicate<? super ISupplier> filter) {
 	 * Returns the converter id "org.eclipse.chemclipse.msd.converter.supplier.agilent" available in the list defined by its name, e.g. "Agilent Chromatogram (*.D/DATA.MS)".
 	 * If more converter with the given name "Agilent Chromatogram (*.D/DATA.MS)" are stored, the first match will be returned. If exportConverterOnly is true, only a converter
 	 * that is able to export the file will be returned.
-	 * 
-	 * @param name
-	 * @param exportConverterOnly
-	 * @return String
-	 * @throws NoConverterAvailableException
 	 */
 	default String getConverterId(String name, boolean exportConverterOnly) throws NoConverterAvailableException {
 
-		Collection<ISupplier> supplier = getSupplier(new Predicate<ISupplier>() {
-
-			@Override
-			public boolean test(ISupplier supplier) {
-
-				return supplier.getFilterName().equals(name) && (!exportConverterOnly || supplier.isExportable());
-			}
-		});
+		Collection<ISupplier> supplier = getSupplier(s -> s.getFilterName().equals(name) && (!exportConverterOnly || s.isExportable()));
 		if(supplier.isEmpty()) {
 			throw new NoConverterAvailableException();
 		} else {
@@ -110,10 +94,6 @@ public boolean test(ISupplier supplier) {
 	 * The same thing if the file is a file and not a directory.<br/>
 	 * The header of {@link MethodConverter} lists some file format
 	 * endings.
-	 * 
-	 * @param file
-	 * @return List<String>
-	 * @throws NoConverterAvailableException
 	 */
 	default List<String> getAvailableConverterIds(File file) throws NoConverterAvailableException {
 
@@ -132,8 +112,6 @@ default List<String> getAvailableConverterIds(File file) throws NoConverterAvail
 
 	/**
 	 * Returns the list of all available suppliers
-	 * 
-	 * @return Collection<ISupplier>
 	 */
 	default Collection<ISupplier> getSupplier(Predicate<? super ISupplier> filter) {
 
@@ -151,10 +129,6 @@ default Collection<ISupplier> getSupplier(Predicate<? super ISupplier> filter) {
 	/**
 	 * Returns the supplier with the given id.<br/>
 	 * If no supplier with the given id is available, throw an exception.
-	 * 
-	 * @param id
-	 * @throws NoConverterAvailableException
-	 * @return supplier
 	 */
 	default ISupplier getSupplier(String id) throws NoConverterAvailableException {
 
@@ -169,13 +143,13 @@ default ISupplier getSupplier(String id) throws NoConverterAvailableException {
 	DataCategory getDataCategory();
 
 	/**
-	 * 
+	 *
 	 * @return a name of this converter so a user can identify this among others
 	 */
 	String getName();
 
 	/**
-	 * 
+	 *
 	 * @return an id that can be used to store a reference to this converter support
 	 */
 	default String getID() {

chemclipse/plugins/org.eclipse.chemclipse.model/src/org/eclipse/chemclipse/model/targets/TargetReference.java

@@ -6,7 +6,7 @@
  * which is available at https://www.eclipse.org/legal/epl-2.0/
  *
  * SPDX-License-Identifier: EPL-2.0
- * 
+ *
  * Contributors:
  * Christoph Läubrich - initial API and implementation
  * Philip Wenig - refactoring target label support
@@ -141,30 +141,23 @@ public static List<TargetReference> getPeakReferences(Collection<? extends IPeak
 
 	/**
 	 * Create the visibility filter.
-	 * 
-	 * @param targetDisplaySettings
-	 * @return {@link Predicate}
 	 */
 	public static Predicate<ITargetReference> createVisibilityFilter(ITargetDisplaySettings targetDisplaySettings) {
 
 		if(targetDisplaySettings == null) {
 			return always -> true;
 		}
 
-		return new Predicate<ITargetReference>() {
-
-			@Override
-			public boolean test(ITargetReference targetReference) {
+		return targetReference -> {
 
-				if(targetDisplaySettings.isVisible(targetReference)) {
-					if(TargetReferenceType.PEAK.equals(targetReference.getType())) {
-						return targetDisplaySettings.isShowPeakLabels();
-					} else if(TargetReferenceType.SCAN.equals(targetReference.getType())) {
-						return targetDisplaySettings.isShowScanLabels();
-					}
+			if(targetDisplaySettings.isVisible(targetReference)) {
+				if(TargetReferenceType.PEAK.equals(targetReference.getType())) {
+					return targetDisplaySettings.isShowPeakLabels();
+				} else if(TargetReferenceType.SCAN.equals(targetReference.getType())) {
+					return targetDisplaySettings.isShowScanLabels();
 				}
-				return false;
 			}
+			return false;
 		};
 	}
 }

chemclipse/plugins/org.eclipse.chemclipse.processing/src/org/eclipse/chemclipse/processing/supplier/IProcessSupplierContext.java

@@ -1,12 +1,12 @@
 /*******************************************************************************
- * Copyright (c) 2019, 2025 Lablicate GmbH.
+ * Copyright (c) 2019, 2026 Lablicate GmbH.
  *
  * This program and the accompanying materials are made
  * available under the terms of the Eclipse Public License 2.0
  * which is available at https://www.eclipse.org/legal/epl-2.0/
  *
  * SPDX-License-Identifier: EPL-2.0
- * 
+ *
  * Contributors:
  * Christoph Läubrich - initial API and implementation
  * Philip Wenig - refactorings
@@ -24,14 +24,11 @@ public interface IProcessSupplierContext {
 
 	/**
 	 * Gets the {@link IProcessSupplier} for the given id from this context or <code>null</code> if no supplier exits for the id
-	 * 
-	 * @param id
-	 * @return
 	 */
 	<T> IProcessSupplier<T> getSupplier(String id);
 
 	/**
-	 * 
+	 *
 	 * iterates all available {@link IProcessSupplier}
 	 */
 	void visitSupplier(Consumer<? super IProcessSupplier<?>> consumer);
@@ -54,18 +51,14 @@ static Predicate<IProcessSupplier<?>> forDataTypes(Iterable<DataCategory> dataTy
 			return test -> true;
 		}
 
-		return new Predicate<IProcessSupplier<?>>() {
-
-			@Override
-			public boolean test(IProcessSupplier<?> processSupplier) {
+		return processSupplier -> {
 
-				for(DataCategory dataType : dataTypes) {
-					if(processSupplier.getSupportedDataTypes().contains(dataType)) {
-						return true;
-					}
+			for(DataCategory dataType : dataTypes) {
+				if(processSupplier.getSupportedDataTypes().contains(dataType)) {
+					return true;
 				}
-				return false;
 			}
+			return false;
 		};
 	}
 

chemclipse/plugins/org.eclipse.chemclipse.ux.extension.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/internal/support/PreferencesProcessSupport.java

@@ -6,7 +6,7 @@
  * which is available at https://www.eclipse.org/legal/epl-2.0/
  *
  * SPDX-License-Identifier: EPL-2.0
- * 
+ *
  * Contributors:
  * Philip Wenig - initial API and implementation
  *******************************************************************************/
@@ -39,16 +39,12 @@ public class PreferencesProcessSupport {
 	public PreferencesProcessSupport(DataCategory dataCategory) {
 
 		this.dataCategory = dataCategory;
-		this.predicateProcessSupplier = new Predicate<IProcessSupplier<?>>() {
-
-			@Override
-			public boolean test(IProcessSupplier<?> processSupplier) {
+		this.predicateProcessSupplier = processSupplier -> {
 
-				if(processSupplier.getSupportedDataTypes().contains(DataCategory.AUTO_DETECT)) {
-					return true;
-				}
-				return processSupplier.getSupportedDataTypes().contains(getDataCategory());
+			if(processSupplier.getSupportedDataTypes().contains(DataCategory.AUTO_DETECT)) {
+				return true;
 			}
+			return processSupplier.getSupportedDataTypes().contains(getDataCategory());
 		};
 
 		updateProcessSuppliers();