Proposed updates for the next *.ocb version

[eselmeister]

org.eclipse.chemclipse.msd.model.core.IRegularLibraryMassSpectrum

• PrecursorType
• NeutralMass
• Polarity
• Properties
• Carrier Gas (He, H2 ...)

[Mailaender]

I think MassSpectrumType should be saved as byte instead of short to save some space.

[Mailaender]

#72 probably also requires an additional section.

[Mailaender]

IEditInformation: getEditor() should also be saved. This is important for GLP.

[Mailaender]

chemclipse/chemclipse/plugins/org.eclipse.chemclipse.support/src/org/eclipse/chemclipse/support/history/ProcessSupplierSupport.java

Lines 80 to 109 in e7342c6

	public static ProcessSupplierEntry fromPayload(String payload) {
	ProcessSupplierEntry processSupplierEntry = null;
	if(payload != null && !payload.isEmpty()) {
	String content = decode(payload);
	String[] parts = content.split(DELIMITER);
	if(parts.length == 4) {
	processSupplierEntry = new ProcessSupplierEntry();
	processSupplierEntry.setId(decode(parts[0]));
	processSupplierEntry.setName(decode(parts[1]));
	processSupplierEntry.setDescription(decode(parts[2]));
	processSupplierEntry.setUserSettings(decode(parts[3]));
	}
	}
	return processSupplierEntry;
	}
	private static String encode(String value) {
	value = value.isEmpty() ? PLACEHOLER_EMPTY : value;
	return Base64.getEncoder().encodeToString(value.getBytes());
	}
	private static String decode(String value) {
	String data = new String(Base64.getDecoder().decode(value.trim()));
	return PLACEHOLER_EMPTY.equals(data) ? "" : data;
	}
	}

this should probably be part of the converter and not the UI.

[eselmeister]

Could you please specify your comment?

[Mailaender]

Sure. First of all, the serialization is triggered by the UI only, so this will not work headlessly. It seems to be a hack to include process method information without changing API or the .ocb file format. However, this means that the description string field has base64 data in it, which will, for example, also serialize into other formats like mzML where it will make no sense and violate the standard. The proper way to do it would be a List<ProcessSupplierEntry> on EditHistory and then let the formats decide how to serialize it. This is pretty hard to untangle now without causing regressions.