Fix loading of SVGs at different size#2705
Merged
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom Feb 12, 2026
Merged
Fix loading of SVGs at different size#2705eselmeister merged 1 commit intoeclipse-chemclipse:developfrom
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom
Conversation
akurtakov
force-pushed
the
develop
branch
3 times, most recently
from
a7985a7 to
50c501d
Compare
It's a limitation in how SWT treats SVG images - uses the width/height in the svg file and treats it as fixed size to fit into all the use cases with old APIs. Use SWT's internals to load at requested size and store in the cache with key that includes the size.
Contributor
Author
|
If I suppress the warnings with annotation for the IDE Maven builds fails with: |
Contributor
Author
|
So this is a limitation in Tycho as it doesn't apply all the analysis pde does. Options are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a limitation in how SWT treats SVG images - uses the width/height in the svg file and treats it as fixed size to fit into all the use cases with old APIs.
Use SWT's internals to load at requested size and store in the cache with key that includes the size.