Avoid notificaton spam when deleting multiple targets in Peak/Scan list#2741
Merged
eselmeister merged 1 commit intoeclipse-chemclipse:developfrom Feb 26, 2026
Merged
Conversation
fd150b5 to
5e53fee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a populated Peak/Scan list press CTRL + A and then CTRL + D to clear targets of multiple peaks. This will trigger an update for each deleted peak consecutively which then bubbles through all the open parts. Takes a while until it finishes and even while not being a loop it is laggy and unpolished. I moved all the delete notifications outside the undo operation because in this case you may want to notify in bulk instead of per peak/scan. This was actually already there, so the extra notifications were overdone.