From bf521dd893739fbd2b38d29afea0e78ce1641880 Mon Sep 17 00:00:00 2001 From: "Stein.Codes" Date: Wed, 18 Oct 2023 05:39:13 +0000 Subject: [PATCH] refactor: Java Security Ultimate Security Repo Scanner 2023 Disclaimer: Automated Commit Alert Please be aware that this commit, generated through automated processes, may contain false alerts or not be precisely targeted. This automated commit is part of a large-scale effort to enhance software security over time. It is sent to various repositories to improve code quality and security. Exercise caution when reviewing the changes, and ensure that any necessary adjustments are made to maintain the integrity and functionality of the software. Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/TkgUEiqd7?organizationId=RWNsaXBzZSBGb3VuZGF0aW9u Co-authored-by: Moderne --- .../java/org/eclipse/collections/candykata/SchoolGroup.java | 4 ++-- .../java/org/eclipse/collections/candykata/SchoolGroup.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/candy-kata-solutions/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java b/candy-kata-solutions/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java index 20835879..17108873 100644 --- a/candy-kata-solutions/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java +++ b/candy-kata-solutions/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java @@ -10,6 +10,7 @@ package org.eclipse.collections.candykata; +import java.security.SecureRandom; import java.time.Duration; import java.time.LocalDate; import java.time.LocalDateTime; @@ -60,8 +61,7 @@ public static ImmutableList all() public Bag trickOrTreat() { - IntStream limit = new Random( - this.time.atZone(NEW_YORK).toEpochSecond()) + IntStream limit = new SecureRandom() .ints(0, Candy.values().length - 1) .limit(this.candyCount); return limit.mapToObj(i -> Candy.values()[i]) diff --git a/candy-kata/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java b/candy-kata/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java index 20835879..17108873 100644 --- a/candy-kata/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java +++ b/candy-kata/src/main/java/org/eclipse/collections/candykata/SchoolGroup.java @@ -10,6 +10,7 @@ package org.eclipse.collections.candykata; +import java.security.SecureRandom; import java.time.Duration; import java.time.LocalDate; import java.time.LocalDateTime; @@ -60,8 +61,7 @@ public static ImmutableList all() public Bag trickOrTreat() { - IntStream limit = new Random( - this.time.atZone(NEW_YORK).toEpochSecond()) + IntStream limit = new SecureRandom() .ints(0, Candy.values().length - 1) .limit(this.candyCount); return limit.mapToObj(i -> Candy.values()[i])