Skip to content

Commit e28acc6

Browse files
dbulahovstbischof
authored andcommitted
fix build after dialects refactoring
Signed-off-by: dbulahov <[email protected]>
1 parent 5aa8e00 commit e28acc6

File tree

4 files changed

+21
-35
lines changed

4 files changed

+21
-35
lines changed

mondrian/src/test/java/mondrian/rolap/sql/CodeSetTest.java

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@
1313
import static org.junit.jupiter.api.Assertions.fail;
1414
import static org.mockito.Mockito.mock;
1515
import static org.mockito.Mockito.when;
16+
17+
import java.sql.Connection;
18+
import java.sql.DatabaseMetaData;
19+
1620
import org.eclipse.daanse.jdbc.db.dialect.db.postgresql.PostgreSqlDialect;
1721
import org.eclipse.daanse.olap.api.exception.OlapRuntimeException;
18-
import org.eclipse.daanse.jdbc.db.api.meta.DatabaseInfo;
19-
import org.eclipse.daanse.jdbc.db.api.meta.IdentifierInfo;
20-
import org.eclipse.daanse.jdbc.db.api.meta.MetaInfo;
2122
import org.junit.jupiter.api.Test;
2223

2324
/**
@@ -55,7 +56,7 @@ void testSucces_CodeSetContainsOnlyCodeForPostgresDialect()
5556
throws Exception
5657
{
5758
PostgreSqlDialect postgreSqlDialect = new PostgreSqlDialect(
58-
mockMetaInfo(
59+
mockConnection(
5960
POSTGRESQL_PRODUCT_NAME,
6061
POSTGRESQL_PRODUCT_VERSION));
6162
codeSet = new SqlQuery.CodeSet();
@@ -82,7 +83,7 @@ void testSucces_CodeSetContainsCodeForBothPostgresAndGenericDialects()
8283
throws Exception
8384
{
8485
PostgreSqlDialect postgreSqlDialect = new PostgreSqlDialect(
85-
mockMetaInfo(
86+
mockConnection(
8687
POSTGRESQL_PRODUCT_NAME,
8788
POSTGRESQL_PRODUCT_VERSION));
8889
codeSet = new SqlQuery.CodeSet();
@@ -111,7 +112,7 @@ void testSucces_CodeSetContainsCodeForBothPostgresAndGenericDialects()
111112
throws Exception
112113
{
113114
PostgreSqlDialect postgreSqlDialect = new PostgreSqlDialect(
114-
mockMetaInfo(
115+
mockConnection(
115116
POSTGRESQL_PRODUCT_NAME,
116117
POSTGRESQL_PRODUCT_VERSION));
117118
codeSet = new SqlQuery.CodeSet();
@@ -138,7 +139,7 @@ void testSucces_CodeSetContainsOnlyCodeForGenericlDialect()
138139
throws Exception
139140
{
140141
PostgreSqlDialect postgreSqlDialect = new PostgreSqlDialect(
141-
mockMetaInfo(
142+
mockConnection(
142143
POSTGRESQL_PRODUCT_NAME,
143144
POSTGRESQL_PRODUCT_VERSION));
144145
codeSet = new SqlQuery.CodeSet();
@@ -164,7 +165,7 @@ void testMondrianExceptionThrown_WhenCodeSetContainsNOCodeForDialect()
164165
throws Exception
165166
{
166167
PostgreSqlDialect postgreSqlDialect = new PostgreSqlDialect(
167-
mockMetaInfo(
168+
mockConnection(
168169
POSTGRESQL_PRODUCT_NAME,
169170
POSTGRESQL_PRODUCT_VERSION));
170171
codeSet = new SqlQuery.CodeSet();
@@ -180,19 +181,17 @@ void testMondrianExceptionThrown_WhenCodeSetContainsNOCodeForDialect()
180181
}
181182
}
182183

183-
private MetaInfo mockMetaInfo(
184+
private Connection mockConnection(
184185
String dbProductName, String dbProductVersion) throws Exception
185186
{
186-
MetaInfo metaInfoMock = mock(MetaInfo.class);
187-
DatabaseInfo databaseInfo = mock(DatabaseInfo.class);
188-
IdentifierInfo identifierInfo = mock(IdentifierInfo.class);
189-
when(metaInfoMock.databaseInfo()).thenReturn(databaseInfo);
190-
when(metaInfoMock.identifierInfo()).thenReturn(identifierInfo);
191-
when(databaseInfo.databaseProductName()).thenReturn(
187+
Connection connection = mock(Connection.class);
188+
DatabaseMetaData metaData = mock(DatabaseMetaData.class);
189+
when(connection.getMetaData()).thenReturn(metaData);
190+
when(metaData.getDatabaseProductName()).thenReturn(
192191
dbProductName != null ? dbProductName : EMPTY_NAME);
193-
when(databaseInfo.databaseProductVersion()).thenReturn(
192+
when(metaData.getDatabaseProductVersion()).thenReturn(
194193
dbProductVersion != null ? dbProductVersion : EMPTY_NAME);
195-
return metaInfoMock;
194+
return connection;
196195
}
197196

198197
}

mondrian/src/test/java/org/opencube/junit5/dbprovider/H2DatabaseProvider.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,12 @@
2727

2828
import javax.sql.DataSource;
2929

30-
import org.eclipse.daanse.jdbc.db.dialect.db.h2.H2Dialect;
3130
import org.eclipse.daanse.jdbc.db.api.meta.MetaInfo;
3231
import org.eclipse.daanse.jdbc.db.core.DatabaseServiceImpl;
3332
import org.eclipse.daanse.jdbc.db.dialect.api.Dialect;
33+
import org.eclipse.daanse.jdbc.db.dialect.db.h2.H2Dialect;
3434
import org.h2.jdbcx.JdbcDataSource;
3535

36-
import aQute.bnd.annotation.spi.ServiceProvider;
37-
import mondrian.rolap.RolapCatalogCache;
38-
3936
//@ServiceProvider(value = DatabaseProvider.class)
4037
public class H2DatabaseProvider implements DatabaseProvider {
4138

@@ -85,9 +82,7 @@ public Entry<DataSource, Dialect> activate() {
8582
cpDataSource.setPassword("sa");
8683
try {
8784
connection = cpDataSource.getConnection();
88-
DatabaseServiceImpl databaseServiceImpl = new DatabaseServiceImpl();
89-
MetaInfo metaInfo = databaseServiceImpl.createMetaInfo(connection);
90-
Dialect dialect = new H2Dialect(metaInfo);
85+
Dialect dialect = new H2Dialect(connection);
9186

9287
connection.close();
9388
return new SimpleEntry<>(cpDataSource, dialect);

mondrian/src/test/java/org/opencube/junit5/dbprovider/MySqlDatabaseProvider.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727

2828
import javax.sql.DataSource;
2929

30-
import org.eclipse.daanse.jdbc.db.api.meta.MetaInfo;
31-
import org.eclipse.daanse.jdbc.db.core.DatabaseServiceImpl;
3230
import org.eclipse.daanse.jdbc.db.dialect.api.Dialect;
3331
import org.eclipse.daanse.jdbc.db.dialect.db.mysql.MySqlDialect;
3432

@@ -91,9 +89,7 @@ protected Entry<DataSource, Dialect> createDataSource() {
9189

9290
Connection connection = dataSource.getConnection(MYSQL_USER, MYSQL_PASSWORD);
9391
// wait until connection is possible
94-
DatabaseServiceImpl databaseServiceImpl = new DatabaseServiceImpl();
95-
MetaInfo metaInfo = databaseServiceImpl.createMetaInfo(connection);
96-
Dialect dialect = new MySqlDialect(metaInfo);
92+
Dialect dialect = new MySqlDialect(connection);
9793
connection.close();
9894
return new SimpleEntry<>(dataSource, dialect);
9995

mondrian/src/test/java/org/opencube/junit5/dbprovider/SQLiteDatabaseProvider.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@
2828

2929
import javax.sql.DataSource;
3030

31-
import org.eclipse.daanse.jdbc.db.dialect.db.mysql.MySqlDialect;
32-
import org.eclipse.daanse.jdbc.db.api.meta.MetaInfo;
33-
import org.eclipse.daanse.jdbc.db.core.DatabaseServiceImpl;
3431
import org.eclipse.daanse.jdbc.db.dialect.api.Dialect;
32+
import org.eclipse.daanse.jdbc.db.dialect.db.mysql.MySqlDialect;
3533
import org.sqlite.SQLiteConfig;
3634
import org.sqlite.SQLiteDataSource;
3735

@@ -66,9 +64,7 @@ public Entry<DataSource, Dialect> activate() {
6664
dataSource.setUrl(JDBC_SQLITE_MEMORY);
6765
try {
6866
Connection connection = dataSource.getConnection();
69-
DatabaseServiceImpl databaseServiceImpl = new DatabaseServiceImpl();
70-
MetaInfo metaInfo = databaseServiceImpl.createMetaInfo(connection);
71-
Dialect dialect = new MySqlDialect(metaInfo);
67+
Dialect dialect = new MySqlDialect(connection);
7268
connection.close();
7369
return new SimpleEntry<>(dataSource, dialect);
7470
} catch (SQLException e) {

0 commit comments

Comments
 (0)