Skip to content

Commit 743eac9

Browse files
dbulahovstbischof
authored andcommitted
Fix one disabled Test - fix external #5
1 parent 758f3a8 commit 743eac9

File tree

1 file changed

+0
-13
lines changed
  • guard/jsqltranspiler/src/test/java/org/eclipse/daanse/sql/guard/jsqltranspiler

1 file changed

+0
-13
lines changed

guard/jsqltranspiler/src/test/java/org/eclipse/daanse/sql/guard/jsqltranspiler/SqlGuardTest.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ void testInnerJoin(@InjectService SqlGuardFactory sqlGuardFactory) throws Except
162162
}
163163

164164
@Test
165-
@Disabled
166165
void testInnerJoin1(@InjectService SqlGuardFactory sqlGuardFactory) throws Exception {
167166
DatabaseCatalog databaseCatalog = schemaWithTwoTableTwoCol();
168167

@@ -268,28 +267,16 @@ void testGroupAggregation(@InjectService SqlGuardFactory sqlGuardFactory) throws
268267

269268
assertThrows(UnresolvableObjectsGuardException.class,
270269
() -> guard.guard(String.format(SQL_WITH_HAVING_WRONG_TABLE, agg, agg)));
271-
// TODO "select avg(foo1.id) from foo group by foo.name")" with any aggregation use wrong table
272-
// "foo1". we have foo table only
273-
// assertThrows(RuntimeException.class, () -> guard.guard("select avg(foo1.id) from foo group by
274-
// foo.name"));
275270

276271
result = guard.guard(String.format(SQL_WITH_HAVING1, agg));
277272
assertEquals(String.format(SQL_WITH_HAVING1_EXPECTED, agg), result);
278273

279274
assertThrows(UnresolvableObjectsGuardException.class,
280275
() -> guard.guard(String.format(SQL_WITH_HAVING_WRONG_TABLE1, agg)));
281-
// TODO select sum(foo.id) from foo group by foo.name having foo1.name = 'tets' with any aggregation
282-
// use wrong table "foo1". we have "foo" table only
283-
// assertThrows(RuntimeException.class, () -> guard.guard("select count(foo.id) from foo group by
284-
// foo.name having foo1.name = 'tets'"));
285276

286277
assertThrows(UnresolvableObjectsGuardException.class, () ->
287278

288279
guard.guard(String.format(SQL_WITH_HAVING_WRONG_COLUMN, agg)));
289-
// TODO select sum(foo.id) from foo group by foo.name having foo.name1 = 'tets' we use wrong column
290-
// name1. name1 ia absent. we have "name" column only
291-
// assertThrows(RuntimeException.class, () -> guard.guard("select count(foo.id) from foo group by
292-
// foo.name having foo.name1 = 'tets'"));
293280

294281
}
295282
}

0 commit comments

Comments
 (0)