refactor to converter seperate handlers - no new behavier code

- Extract Discover handlers (DBSCHEMA_*, MDSCHEMA_*, DISCOVER_*)
- Extract Execute handlers (Statement, Alter, Cancel, ClearCache)
- Simplify XmlaApiAdapter with handler dispatch maps
- Add type-safe getXxxList() methods to Convert/Handler
- Constantd for String and QName decentralized
- add tests
- Formatter and organite imports

Signed-off-by: Stefan Bischof <[email protected]>

Author: stbischof

api/src/main/java/org/eclipse/daanse/xmla/api/PropertyDefinition.java

@@ -18,7 +18,6 @@
 package org.eclipse.daanse.xmla.api;
 
 import java.util.EnumSet;
-import java.util.Enumeration;
 import java.util.Set;
 
 /**
@@ -197,13 +196,13 @@ public enum PropertyDefinition {
             "DBMSVersion");
 
     final RowsetDefinitionType type;
-    final Set<? extends Enum> enumSet;
+    final Set<? extends Enum<?>> enumSet;
     final XmlaConstants.Access access;
     final XmlaConstants.Method usage;
     final String value;
     final String description;
 
-    PropertyDefinition(RowsetDefinitionType type, Set<? extends Enum> enumSet, XmlaConstants.Access access,
+    PropertyDefinition(RowsetDefinitionType type, Set<? extends Enum<?>> enumSet, XmlaConstants.Access access,
             String value, XmlaConstants.Method usage, String description) {
         // Line endings must be UNIX style (LF) not Windows style (LF+CR).
         // Thus the client will receive the same XML, regardless

api/src/main/java/org/eclipse/daanse/xmla/api/XmlaException.java

@@ -21,6 +21,7 @@
  *
  * @author <a>Richard M. Emberson</a>
  */
+@SuppressWarnings("serial")
 public class XmlaException extends RuntimeException {
 
     public static String formatFaultCode(XmlaException xex) {

api/src/main/java/org/eclipse/daanse/xmla/api/XmlaUtil.java

@@ -16,6 +16,7 @@
 import static org.eclipse.daanse.xmla.api.XmlaConstants.CLIENT_FAULT_FC;
 import static org.eclipse.daanse.xmla.api.XmlaConstants.USM_DOM_PARSE_CODE;
 import static org.eclipse.daanse.xmla.api.XmlaConstants.USM_DOM_PARSE_FAULT_FS;
+
 import java.io.StringWriter;
 import java.util.ArrayList;
 import java.util.List;
@@ -231,21 +232,6 @@ public static String normalizeNumericString(String numericStr) {
         return numericStr;
     }
 
-
-    private static <T> String toString(List<T> list) {
-        StringBuilder buf = new StringBuilder();
-        int k = -1;
-        for (T t : list) {
-            if (++k > 0) {
-                buf.append(", ");
-            }
-            buf.append(t);
-        }
-        return buf.toString();
-    }
-
-
-
     /**
      * Result of a metadata query.
      */

api/src/main/java/org/eclipse/daanse/xmla/api/common/enums/AccessEnum.java

@@ -13,10 +13,10 @@
  */
 package org.eclipse.daanse.xmla.api.common.enums;
 
-import org.eclipse.daanse.xmla.api.annotation.Enumerator;
-
 import java.util.stream.Stream;
 
+import org.eclipse.daanse.xmla.api.annotation.Enumerator;
+
 @Enumerator(name = "Access")
 public enum AccessEnum {
     READ("Read"), WRITE("Write"), READ_WRITE("ReadWrite");

api/src/main/java/org/eclipse/daanse/xmla/api/common/enums/AuthenticationModeEnum.java

@@ -13,10 +13,10 @@
  */
 package org.eclipse.daanse.xmla.api.common.enums;
 
-import org.eclipse.daanse.xmla.api.annotation.Enumerator;
-
 import java.util.stream.Stream;
 
+import org.eclipse.daanse.xmla.api.annotation.Enumerator;
+
 @Enumerator(name = "AuthenticationMode")
 public enum AuthenticationModeEnum {
 

api/src/main/java/org/eclipse/daanse/xmla/api/common/enums/ProviderTypeEnum.java

@@ -13,10 +13,10 @@
  */
 package org.eclipse.daanse.xmla.api.common.enums;
 
-import org.eclipse.daanse.xmla.api.annotation.Enumerator;
-
 import java.util.stream.Stream;
 
+import org.eclipse.daanse.xmla.api.annotation.Enumerator;
+
 @Enumerator(name = "ProviderType")
 public enum ProviderTypeEnum {
 

api/src/main/java/org/eclipse/daanse/xmla/api/common/enums/TreeOpEnum.java

@@ -13,10 +13,10 @@
  */
 package org.eclipse.daanse.xmla.api.common.enums;
 
-import org.eclipse.daanse.xmla.api.annotation.Enumerator;
-
 import java.util.stream.Stream;
 
+import org.eclipse.daanse.xmla.api.annotation.Enumerator;
+
 /**
  * Applies only to a single member:
  */

api/src/main/java/org/eclipse/daanse/xmla/api/common/properties/PropertyListElementDefinition.java

@@ -31,14 +31,14 @@ public enum PropertyListElementDefinition {
     LOCALE_IDENTIFIER("LocaleIdentifier", Type.UNSIGNED_INTEGER, null, Access.READ_WRITE, null, true, true);
 
     final Type type;
-    final Set<? extends Enum> enumSet;
+    final Set<? extends Enum<?>> enumSet;
     final Access access;
     final boolean discover;
     final boolean execute;
     final String value;
     final String nameValue;
 
-    PropertyListElementDefinition(String nameValue, Type type, Set<? extends Enum> enumSet, Access access, String value,
+    PropertyListElementDefinition(String nameValue, Type type, Set<? extends Enum<?>> enumSet, Access access, String value,
             boolean discover, boolean execute) {
 
         assert (enumSet != null) == type.isEnum();

api/src/main/java/org/eclipse/daanse/xmla/api/discover/dbschema/catalogs/DbSchemaCatalogsRequest.java

@@ -13,11 +13,11 @@
 */
 package org.eclipse.daanse.xmla.api.discover.dbschema.catalogs;
 
+import static org.eclipse.daanse.xmla.api.common.properties.OperationNames.DBSCHEMA_CATALOGS;
+
 import org.eclipse.daanse.xmla.api.annotation.Operation;
 import org.eclipse.daanse.xmla.api.discover.Properties;
 
-import static org.eclipse.daanse.xmla.api.common.properties.OperationNames.DBSCHEMA_CATALOGS;
-
 @Operation(name = DBSCHEMA_CATALOGS, guid = "C8B52211-5CF3-11CE-ADE5-00AA0044773D")
 public interface DbSchemaCatalogsRequest {
     Properties properties();

api/src/main/java/org/eclipse/daanse/xmla/api/discover/dbschema/catalogs/DbSchemaCatalogsRestrictions.java

@@ -13,11 +13,11 @@
  */
 package org.eclipse.daanse.xmla.api.discover.dbschema.catalogs;
 
-import org.eclipse.daanse.xmla.api.annotation.Restriction;
+import static org.eclipse.daanse.xmla.api.common.properties.XsdType.XSD_STRING;
 
 import java.util.Optional;
 
-import static org.eclipse.daanse.xmla.api.common.properties.XsdType.XSD_STRING;
+import org.eclipse.daanse.xmla.api.annotation.Restriction;
 
 public interface DbSchemaCatalogsRestrictions {
     String RESTRICTIONS_CATALOG_NAME = "CATALOG_NAME";