Apply warnings target to remaining libraries

Author: DownerCase

ecal/service/CMakeLists.txt

@@ -19,6 +19,28 @@
 cmake_minimum_required(VERSION 3.16)
 project(ecal_service)
 
+# Root CMakeLists sets CMAKE_MODULE_PATH to include the correct path
+# If the module cannot be found warnings basic warnings will be applied instead
+include(helper_functions/ecal_compiler_warnings OPTIONAL RESULT_VARIABLE _ecal_warnings_found)
+if("${_ecal_warnings_found}" STREQUAL "NOTFOUND")
+  message(AUTHOR_WARNING
+    "  helper_functions/ecal_compiler_warnings.cmake not found.\n"
+    "  Add the path to CMAKE_MODULE_PATH to use warnings specified by the main eCAL repo."
+  )
+  add_library(_ecal_service_warnings INTERFACE)
+  set(cxx_compiler_flags "")
+  if("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
+      set(cxx_compiler_flags "/MP" "/W4")
+  elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU|Clang")
+      set(cxx_compiler_flags "-Wall" "-Wextra")
+  else()
+      message(WARNING "Unknown compiler, will not set warning flags")
+  endif()
+  target_compile_options(_ecal_service_warnings INTERFACE "${cxx_compiler_flags}")
+else()
+  add_library(_ecal_service_warnings ALIAS _ecal_warnings)
+endif()
+
 # Main library
 add_subdirectory(ecal_service)
 

ecal/service/ecal_service/CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.5.1)
+cmake_minimum_required(VERSION 3.16)
 
 project(ecal_service)
 
@@ -61,6 +61,7 @@ target_link_libraries(${PROJECT_NAME}
         Threads::Threads
         $<$<BOOL:${WIN32}>:ws2_32>
         $<$<BOOL:${WIN32}>:wsock32>
+        _ecal_service_warnings
 
 )
 
@@ -72,12 +73,6 @@ target_compile_definitions(${PROJECT_NAME}
 
 target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_14)
 
-target_compile_options(${PROJECT_NAME} PRIVATE
-                           $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
-                                -Wall -Wextra>
-                           $<$<CXX_COMPILER_ID:MSVC>:
-                                /W4>)
-
 # Add own public include directory
 target_include_directories(${PROJECT_NAME}
   PUBLIC 

lib/EcalParser/CMakeLists.txt

@@ -45,9 +45,6 @@ set(sources
 # QEcalParser is an internal implementation detail for applications so it can
 # always be static and not installed/exported
 ecal_add_static_library(${PROJECT_NAME}
-    ${includes}
-    ${sources}
-)
 
 target_include_directories(${PROJECT_NAME} PUBLIC include/)
 target_include_directories(${PROJECT_NAME} PRIVATE src/)