Skip to content

Commit 83efe9b

Browse files
authored
fix: Revert "build(deps): bump swagger plugin to 2.2.40 (#397)" (#401)
Revert "build(deps): bump swagger plugin to 2.2.40 (#397)" This reverts commit bfcd9ca.
1 parent c58d783 commit 83efe9b

File tree

3 files changed

+19
-22
lines changed

3 files changed

+19
-22
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jupiter = "6.0.1"
1414
mockito = "5.20.0"
1515
openapi-merger = "1.0.5"
1616
openapi-generator = "7.16.0"
17-
swagger = "2.2.40"
17+
swagger = "2.2.26"
1818
swagger-parser = "2.1.35"
1919

2020
[libraries]

plugins/edc-build/src/main/java/org/eclipse/edc/plugins/edcbuild/conventions/SwaggerResolveConvention.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.gradle.api.plugins.JavaPluginExtension;
2323

2424
import java.nio.file.Path;
25+
import java.util.Map;
2526
import java.util.stream.Stream;
2627

2728
import static org.eclipse.edc.plugins.edcbuild.conventions.ConventionFunctions.requireExtension;
@@ -60,7 +61,7 @@ public void apply(Project target) {
6061

6162
var outputDir = Path.of(swaggerExt.getOutputDirectory().getOrElse(fallbackOutputDir.toFile()).toURI())
6263
.resolve(apiGroup)
63-
.toAbsolutePath().toString();
64+
.toFile();
6465

6566
task.setOutputFileName(outputFileName);
6667
task.setOutputDir(outputDir);
@@ -75,7 +76,7 @@ public void apply(Project target) {
7576
target.getTasks().register("openapi", ResolveTask.class).configure(task -> {
7677
var outputDir = target.getLayout().getBuildDirectory().getAsFile().get().toPath()
7778
.resolve("docs").resolve("openapi")
78-
.toAbsolutePath().toString();
79+
.toFile();
7980

8081
target.getTasks().findByName("jar").dependsOn(task);
8182
task.setGroup("documentation");
@@ -89,6 +90,9 @@ public void apply(Project target) {
8990
task.setBuildClasspath(task.getClasspath());
9091
task.setResourcePackages(resourcePkgs);
9192
});
93+
94+
target.getConfigurations().all(c -> c.exclude(Map.of("group", "com.fasterxml.jackson.jaxrs",
95+
"module", "jackson-jaxrs-json-provider")));
9296
});
9397
}
9498
}

plugins/edc-build/src/test/java/org/eclipse/edc/plugins/edcbuild/conventions/SwaggerResolveConventionTest.java

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ void setUp() {
3737
project = ProjectBuilder.builder().withName(PROJECT_NAME).build();
3838
project.getPluginManager().apply(SWAGGER_GRADLE_PLUGIN);
3939
project.getPluginManager().apply(JavaPlugin.class);
40-
project.getRepositories().mavenCentral();
4140
project.getExtensions().create("edcBuild", BuildExtension.class, project.getObjects());
4241
}
4342

@@ -46,13 +45,11 @@ void apply_whenApiGroupNotSpecified_shouldUseDefault() {
4645
var convention = new SwaggerResolveConvention();
4746
convention.apply(project);
4847

49-
var task = project.getTasks().getByName("resolve");
48+
var resolveTask = (ResolveTask) project.getTasks().getByName("resolve");
5049

51-
assertThat(task).isInstanceOfSatisfying(ResolveTask.class, resolveTask -> {
52-
assertThat(resolveTask.getOutputDir().get().getAsFile().getAbsolutePath()).endsWith("/resources/openapi/yaml");
53-
assertThat(resolveTask.getOutputFileName().get()).isEqualTo(PROJECT_NAME);
54-
assertThat(resolveTask.getOutputFormat().get()).isEqualTo(ResolveTask.Format.YAML);
55-
});
50+
assertThat(resolveTask.getOutputDir().toString()).endsWith("/resources/openapi/yaml");
51+
assertThat(resolveTask.getOutputFileName()).isEqualTo(PROJECT_NAME);
52+
assertThat(resolveTask.getOutputFormat()).isEqualTo(ResolveTask.Format.YAML);
5653
}
5754

5855
@Test
@@ -62,13 +59,11 @@ void apply_whenApiGroupSpecified_shouldAppend() {
6259
var convention = new SwaggerResolveConvention();
6360
convention.apply(project);
6461

65-
var task = project.getTasks().getByName("resolve");
62+
var resolveTask = (ResolveTask) project.getTasks().getByName("resolve");
6663

67-
assertThat(task).isInstanceOfSatisfying(ResolveTask.class, resolveTask -> {
68-
assertThat(resolveTask.getOutputDir().get().getAsFile().getAbsolutePath()).endsWith("/resources/openapi/yaml/test-api");
69-
assertThat(resolveTask.getOutputFileName().get()).isEqualTo(PROJECT_NAME);
70-
assertThat(resolveTask.getOutputFormat().get()).isEqualTo(ResolveTask.Format.YAML);
71-
});
64+
assertThat(resolveTask.getOutputDir().toString()).endsWith("/resources/openapi/yaml/test-api");
65+
assertThat(resolveTask.getOutputFileName()).isEqualTo(PROJECT_NAME);
66+
assertThat(resolveTask.getOutputFormat()).isEqualTo(ResolveTask.Format.YAML);
7267
}
7368

7469
@Test
@@ -79,12 +74,10 @@ void apply_whenOutputDirSet_shouldAppend() {
7974
var convention = new SwaggerResolveConvention();
8075
convention.apply(project);
8176

82-
var task = project.getTasks().getByName("resolve");
77+
var resolveTask = (ResolveTask) project.getTasks().getByName("resolve");
8378

84-
assertThat(task).isInstanceOfSatisfying(ResolveTask.class, resolveTask -> {
85-
assertThat(resolveTask.getOutputDir().get().getAsFile().getAbsolutePath()).endsWith("/some/funny/path/test-api");
86-
assertThat(resolveTask.getOutputFileName().get()).isEqualTo(PROJECT_NAME);
87-
assertThat(resolveTask.getOutputFormat().get()).isEqualTo(ResolveTask.Format.YAML);
88-
});
79+
assertThat(resolveTask.getOutputDir().toString()).endsWith("/some/funny/path/test-api");
80+
assertThat(resolveTask.getOutputFileName()).isEqualTo(PROJECT_NAME);
81+
assertThat(resolveTask.getOutputFormat()).isEqualTo(ResolveTask.Format.YAML);
8982
}
9083
}

0 commit comments

Comments
 (0)