Skip to content

Commit bfcd9ca

Browse files
authored
build(deps): bump swagger plugin to 2.2.40 (#397)
1 parent 9109cf4 commit bfcd9ca

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jupiter = "6.0.1"
1414
mockito = "5.20.0"
1515
openapi-merger = "1.0.5"
1616
openapi-generator = "7.16.0"
17-
swagger = "2.2.26"
17+
swagger = "2.2.40"
1818
swagger-parser = "2.1.35"
1919

2020
[libraries]

plugins/edc-build/src/main/java/org/eclipse/edc/plugins/edcbuild/conventions/SwaggerResolveConvention.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.gradle.api.plugins.JavaPluginExtension;
2323

2424
import java.nio.file.Path;
25-
import java.util.Map;
2625
import java.util.stream.Stream;
2726

2827
import static org.eclipse.edc.plugins.edcbuild.conventions.ConventionFunctions.requireExtension;
@@ -61,7 +60,7 @@ public void apply(Project target) {
6160

6261
var outputDir = Path.of(swaggerExt.getOutputDirectory().getOrElse(fallbackOutputDir.toFile()).toURI())
6362
.resolve(apiGroup)
64-
.toFile();
63+
.toAbsolutePath().toString();
6564

6665
task.setOutputFileName(outputFileName);
6766
task.setOutputDir(outputDir);
@@ -76,7 +75,7 @@ public void apply(Project target) {
7675
target.getTasks().register("openapi", ResolveTask.class).configure(task -> {
7776
var outputDir = target.getLayout().getBuildDirectory().getAsFile().get().toPath()
7877
.resolve("docs").resolve("openapi")
79-
.toFile();
78+
.toAbsolutePath().toString();
8079

8180
target.getTasks().findByName("jar").dependsOn(task);
8281
task.setGroup("documentation");
@@ -90,9 +89,6 @@ public void apply(Project target) {
9089
task.setBuildClasspath(task.getClasspath());
9190
task.setResourcePackages(resourcePkgs);
9291
});
93-
94-
target.getConfigurations().all(c -> c.exclude(Map.of("group", "com.fasterxml.jackson.jaxrs",
95-
"module", "jackson-jaxrs-json-provider")));
9692
});
9793
}
9894
}

plugins/edc-build/src/test/java/org/eclipse/edc/plugins/edcbuild/conventions/SwaggerResolveConventionTest.java

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ void setUp() {
3737
project = ProjectBuilder.builder().withName(PROJECT_NAME).build();
3838
project.getPluginManager().apply(SWAGGER_GRADLE_PLUGIN);
3939
project.getPluginManager().apply(JavaPlugin.class);
40+
project.getRepositories().mavenCentral();
4041
project.getExtensions().create("edcBuild", BuildExtension.class, project.getObjects());
4142
}
4243

@@ -45,11 +46,13 @@ void apply_whenApiGroupNotSpecified_shouldUseDefault() {
4546
var convention = new SwaggerResolveConvention();
4647
convention.apply(project);
4748

48-
var resolveTask = (ResolveTask) project.getTasks().getByName("resolve");
49+
var task = project.getTasks().getByName("resolve");
4950

50-
assertThat(resolveTask.getOutputDir().toString()).endsWith("/resources/openapi/yaml");
51-
assertThat(resolveTask.getOutputFileName()).isEqualTo(PROJECT_NAME);
52-
assertThat(resolveTask.getOutputFormat()).isEqualTo(ResolveTask.Format.YAML);
51+
assertThat(task).isInstanceOfSatisfying(ResolveTask.class, resolveTask -> {
52+
assertThat(resolveTask.getOutputDir().get().getAsFile().getAbsolutePath()).endsWith("/resources/openapi/yaml");
53+
assertThat(resolveTask.getOutputFileName().get()).isEqualTo(PROJECT_NAME);
54+
assertThat(resolveTask.getOutputFormat().get()).isEqualTo(ResolveTask.Format.YAML);
55+
});
5356
}
5457

5558
@Test
@@ -59,11 +62,13 @@ void apply_whenApiGroupSpecified_shouldAppend() {
5962
var convention = new SwaggerResolveConvention();
6063
convention.apply(project);
6164

62-
var resolveTask = (ResolveTask) project.getTasks().getByName("resolve");
65+
var task = project.getTasks().getByName("resolve");
6366

64-
assertThat(resolveTask.getOutputDir().toString()).endsWith("/resources/openapi/yaml/test-api");
65-
assertThat(resolveTask.getOutputFileName()).isEqualTo(PROJECT_NAME);
66-
assertThat(resolveTask.getOutputFormat()).isEqualTo(ResolveTask.Format.YAML);
67+
assertThat(task).isInstanceOfSatisfying(ResolveTask.class, resolveTask -> {
68+
assertThat(resolveTask.getOutputDir().get().getAsFile().getAbsolutePath()).endsWith("/resources/openapi/yaml/test-api");
69+
assertThat(resolveTask.getOutputFileName().get()).isEqualTo(PROJECT_NAME);
70+
assertThat(resolveTask.getOutputFormat().get()).isEqualTo(ResolveTask.Format.YAML);
71+
});
6772
}
6873

6974
@Test
@@ -74,10 +79,12 @@ void apply_whenOutputDirSet_shouldAppend() {
7479
var convention = new SwaggerResolveConvention();
7580
convention.apply(project);
7681

77-
var resolveTask = (ResolveTask) project.getTasks().getByName("resolve");
82+
var task = project.getTasks().getByName("resolve");
7883

79-
assertThat(resolveTask.getOutputDir().toString()).endsWith("/some/funny/path/test-api");
80-
assertThat(resolveTask.getOutputFileName()).isEqualTo(PROJECT_NAME);
81-
assertThat(resolveTask.getOutputFormat()).isEqualTo(ResolveTask.Format.YAML);
84+
assertThat(task).isInstanceOfSatisfying(ResolveTask.class, resolveTask -> {
85+
assertThat(resolveTask.getOutputDir().get().getAsFile().getAbsolutePath()).endsWith("/some/funny/path/test-api");
86+
assertThat(resolveTask.getOutputFileName().get()).isEqualTo(PROJECT_NAME);
87+
assertThat(resolveTask.getOutputFormat().get()).isEqualTo(ResolveTask.Format.YAML);
88+
});
8289
}
8390
}

0 commit comments

Comments
 (0)