Skip to content

Commit f1a5ef4

Browse files
authored
fix: exclude modules that should not be published from the waitForPublishedArtifacts (#366)
1 parent 20a2a26 commit f1a5ef4

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

plugins/edc-build/src/main/java/org/eclipse/edc/plugins/edcbuild/conventions/MavenPublicationConvention.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323

2424
public class MavenPublicationConvention implements EdcConvention {
2525

26-
private static final boolean DEFAULT_SHOULD_PUBLISH = true;
27-
2826
@Override
2927
public void apply(Project target) {
3028
// do not publish the root project or modules without a build.gradle.kts
@@ -33,9 +31,8 @@ public void apply(Project target) {
3331
}
3432

3533
var buildExtension = requireExtension(target, BuildExtension.class);
36-
var shouldPublish = buildExtension.getPublish().getOrElse(DEFAULT_SHOULD_PUBLISH);
3734

38-
if (shouldPublish) {
35+
if (buildExtension.shouldPublish()) {
3936
target.getPlugins().apply(MavenPublishPlugin.class);
4037

4138
target.getExtensions().configure(MavenPublishBaseExtension.class, extension -> {

plugins/edc-build/src/main/java/org/eclipse/edc/plugins/edcbuild/extensions/BuildExtension.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@
2424
* Root configuration resource for the EDC Build plugin
2525
*/
2626
public abstract class BuildExtension {
27+
28+
private static final boolean DEFAULT_SHOULD_PUBLISH = true;
29+
2730
private final MavenPomExtension pom;
2831
private final SwaggerGeneratorExtension swagger;
2932

@@ -50,6 +53,15 @@ public SwaggerGeneratorExtension getSwagger() {
5053
return swagger;
5154
}
5255

56+
/**
57+
* Tell if the module needs to be published
58+
*
59+
* @return true if the module needs to be published, false otherwise
60+
*/
61+
public boolean shouldPublish() {
62+
return getPublish().getOrElse(DEFAULT_SHOULD_PUBLISH);
63+
}
64+
5365
public abstract Property<Boolean> getPublish();
5466

5567
}

plugins/edc-build/src/main/java/org/eclipse/edc/plugins/edcbuild/tasks/WaitForPublishedArtifacts.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
package org.eclipse.edc.plugins.edcbuild.tasks;
1616

17+
import org.eclipse.edc.plugins.edcbuild.extensions.BuildExtension;
1718
import org.gradle.api.DefaultTask;
1819
import org.gradle.api.artifacts.dsl.RepositoryHandler;
1920
import org.gradle.api.publish.PublishingExtension;
@@ -37,6 +38,10 @@ public class WaitForPublishedArtifacts extends DefaultTask {
3738

3839
@TaskAction
3940
public void waitForPublishedArtifacts() {
41+
if (!requireExtension(getProject(), BuildExtension.class).shouldPublish()) {
42+
return;
43+
}
44+
4045
requireExtension(getProject(), PublishingExtension.class)
4146
.getPublications().stream()
4247
.map(MavenPublication.class::cast)

0 commit comments

Comments
 (0)