Skip to content

Commit 31a3469

Browse files
fix: compile errors after EDC token refactor (#128)
* fix: compile errors after EDC token refactor * pr remarks
1 parent e55dcd7 commit 31a3469

File tree

3 files changed

+30
-44
lines changed

3 files changed

+30
-44
lines changed

DEPENDENCIES

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
maven/mavencentral/com.apicatalog/carbon-did/0.0.2, Apache-2.0, approved, #9239
2+
maven/mavencentral/com.apicatalog/iron-verifiable-credentials/0.8.1, Apache-2.0, approved, #9234
3+
maven/mavencentral/com.apicatalog/titanium-json-ld/1.0.0, Apache-2.0, approved, clearlydefined
4+
maven/mavencentral/com.apicatalog/titanium-json-ld/1.3.1, Apache-2.0, approved, #8912
15
maven/mavencentral/com.apicatalog/titanium-json-ld/1.3.3, Apache-2.0, approved, #8912
26
maven/mavencentral/com.azure.resourcemanager/azure-resourcemanager-appplatform/2.33.0, MIT, approved, clearlydefined
37
maven/mavencentral/com.azure.resourcemanager/azure-resourcemanager-appservice/2.33.0, MIT, approved, clearlydefined
@@ -82,11 +86,15 @@ maven/mavencentral/com.github.docker-java/docker-java-transport-zerodep/3.3.4, A
8286
maven/mavencentral/com.github.docker-java/docker-java-transport/3.3.4, Apache-2.0, approved, #7942
8387
maven/mavencentral/com.github.stephenc.jcip/jcip-annotations/1.0-1, Apache-2.0, approved, CQ21949
8488
maven/mavencentral/com.google.code.findbugs/jsr305/3.0.2, Apache-2.0, approved, #20
89+
maven/mavencentral/com.google.code.gson/gson/2.10.1, Apache-2.0, approved, #6159
90+
maven/mavencentral/com.google.crypto.tink/tink/1.12.0, Apache-2.0, approved, #12041
91+
maven/mavencentral/com.google.errorprone/error_prone_annotations/2.22.0, Apache-2.0, approved, #10661
8592
maven/mavencentral/com.google.errorprone/error_prone_annotations/2.7.1, Apache-2.0, approved, clearlydefined
8693
maven/mavencentral/com.google.guava/failureaccess/1.0.1, Apache-2.0, approved, CQ22654
8794
maven/mavencentral/com.google.guava/guava/31.0.1-jre, Apache-2.0, approved, clearlydefined
8895
maven/mavencentral/com.google.guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava, Apache-2.0, approved, CQ22657
8996
maven/mavencentral/com.google.j2objc/j2objc-annotations/1.3, Apache-2.0, approved, CQ21195
97+
maven/mavencentral/com.google.protobuf/protobuf-java/3.24.3, BSD-3-Clause, approved, clearlydefined
9098
maven/mavencentral/com.microsoft.azure/msal4j-persistence-extension/1.2.0, MIT, approved, clearlydefined
9199
maven/mavencentral/com.microsoft.azure/msal4j/1.14.0, MIT, approved, clearlydefined
92100
maven/mavencentral/com.microsoft.azure/msal4j/1.4.0, MIT, approved, clearlydefined
@@ -170,6 +178,7 @@ maven/mavencentral/io.rest-assured/rest-assured/5.3.2, Apache-2.0, approved, #92
170178
maven/mavencentral/io.rest-assured/rest-assured/5.4.0, Apache-2.0, approved, #12040
171179
maven/mavencentral/io.rest-assured/xml-path/5.3.2, Apache-2.0, approved, #9267
172180
maven/mavencentral/io.rest-assured/xml-path/5.4.0, Apache-2.0, approved, #12038
181+
maven/mavencentral/io.setl/rdf-urdna/1.1, Apache-2.0, approved, clearlydefined
173182
maven/mavencentral/io.swagger.core.v3/swagger-annotations-jakarta/2.1.13, Apache-2.0, approved, clearlydefined
174183
maven/mavencentral/io.swagger.core.v3/swagger-annotations-jakarta/2.2.15, Apache-2.0, approved, #5947
175184
maven/mavencentral/io.swagger.core.v3/swagger-annotations-jakarta/2.2.20, Apache-2.0, approved, #5947
@@ -260,6 +269,7 @@ maven/mavencentral/org.eclipse.edc/control-plane-core/0.4.2-SNAPSHOT, Apache-2.0
260269
maven/mavencentral/org.eclipse.edc/control-plane-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
261270
maven/mavencentral/org.eclipse.edc/core-spi/0.3.1, Apache-2.0, approved, technology.edc
262271
maven/mavencentral/org.eclipse.edc/core-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
272+
maven/mavencentral/org.eclipse.edc/crypto-common/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
263273
maven/mavencentral/org.eclipse.edc/data-plane-client/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
264274
maven/mavencentral/org.eclipse.edc/data-plane-core/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
265275
maven/mavencentral/org.eclipse.edc/data-plane-instance-store-sql/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
@@ -290,16 +300,17 @@ maven/mavencentral/org.eclipse.edc/http-spi/0.4.2-SNAPSHOT, Apache-2.0, approved
290300
maven/mavencentral/org.eclipse.edc/http/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
291301
maven/mavencentral/org.eclipse.edc/iam-mock/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
292302
maven/mavencentral/org.eclipse.edc/identity-did-spi/0.3.1, Apache-2.0, approved, technology.edc
303+
maven/mavencentral/org.eclipse.edc/identity-did-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
293304
maven/mavencentral/org.eclipse.edc/identity-hub-spi/0.3.1, Apache-2.0, approved, technology.edc
294305
maven/mavencentral/org.eclipse.edc/identity-hub-store-spi/0.3.1, Apache-2.0, approved, technology.edc
295306
maven/mavencentral/org.eclipse.edc/identity-hub-store-sql/0.3.1, Apache-2.0, approved, technology.edc
307+
maven/mavencentral/org.eclipse.edc/identity-trust-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
296308
maven/mavencentral/org.eclipse.edc/jersey-core/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
297309
maven/mavencentral/org.eclipse.edc/jersey-providers/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
298310
maven/mavencentral/org.eclipse.edc/jetty-core/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
299311
maven/mavencentral/org.eclipse.edc/json-ld-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
300312
maven/mavencentral/org.eclipse.edc/json-ld/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
301313
maven/mavencentral/org.eclipse.edc/junit/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
302-
maven/mavencentral/org.eclipse.edc/jwt-core/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
303314
maven/mavencentral/org.eclipse.edc/jwt-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
304315
maven/mavencentral/org.eclipse.edc/management-api-configuration/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
305316
maven/mavencentral/org.eclipse.edc/management-api-test-fixtures/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
@@ -321,6 +332,8 @@ maven/mavencentral/org.eclipse.edc/sql-core/0.3.1, Apache-2.0, approved, technol
321332
maven/mavencentral/org.eclipse.edc/sql-core/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
322333
maven/mavencentral/org.eclipse.edc/sql-lease/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
323334
maven/mavencentral/org.eclipse.edc/state-machine/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
335+
maven/mavencentral/org.eclipse.edc/token-core/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
336+
maven/mavencentral/org.eclipse.edc/token-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
324337
maven/mavencentral/org.eclipse.edc/transaction-datasource-spi/0.3.1, Apache-2.0, approved, technology.edc
325338
maven/mavencentral/org.eclipse.edc/transaction-datasource-spi/0.4.2-SNAPSHOT, Apache-2.0, approved, technology.edc
326339
maven/mavencentral/org.eclipse.edc/transaction-spi/0.3.1, Apache-2.0, approved, technology.edc

extensions/common/vault/vault-azure/src/main/java/org/eclipse/edc/vault/azure/AzureVaultExtension.java

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,13 @@
1818
import com.azure.security.keyvault.secrets.SecretClientBuilder;
1919
import org.eclipse.edc.runtime.metamodel.annotation.Extension;
2020
import org.eclipse.edc.runtime.metamodel.annotation.Inject;
21-
import org.eclipse.edc.runtime.metamodel.annotation.Provides;
21+
import org.eclipse.edc.runtime.metamodel.annotation.Provider;
2222
import org.eclipse.edc.runtime.metamodel.annotation.Setting;
2323
import org.eclipse.edc.spi.monitor.Monitor;
24-
import org.eclipse.edc.spi.security.CertificateResolver;
25-
import org.eclipse.edc.spi.security.PrivateKeyResolver;
2624
import org.eclipse.edc.spi.security.Vault;
27-
import org.eclipse.edc.spi.security.VaultCertificateResolver;
28-
import org.eclipse.edc.spi.security.VaultPrivateKeyResolver;
2925
import org.eclipse.edc.spi.system.ServiceExtension;
3026
import org.eclipse.edc.spi.system.ServiceExtensionContext;
3127

32-
@Provides({Vault.class, PrivateKeyResolver.class, CertificateResolver.class})
3328
@Extension(value = AzureVaultExtension.NAME)
3429
public class AzureVaultExtension implements ServiceExtension {
3530

@@ -45,17 +40,13 @@ public String name() {
4540
return NAME;
4641
}
4742

48-
@Override
49-
public void initialize(ServiceExtensionContext context) {
43+
@Provider
44+
public Vault createVault(ServiceExtensionContext context) {
5045
var name = context.getConfig().getString(VAULT_NAME);
5146
var client = new SecretClientBuilder()
5247
.vaultUrl("https://" + name + ".vault.azure.net")
5348
.credential(new DefaultAzureCredentialBuilder().build())
5449
.buildClient();
55-
var vault = new AzureVault(monitor, client);
56-
57-
context.registerService(Vault.class, vault);
58-
context.registerService(PrivateKeyResolver.class, new VaultPrivateKeyResolver(vault));
59-
context.registerService(CertificateResolver.class, new VaultCertificateResolver(vault));
50+
return new AzureVault(monitor, client);
6051
}
6152
}

extensions/common/vault/vault-azure/src/test/java/org/eclipse/edc/vault/azure/AzureVaultExtensionTest.java

Lines changed: 12 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -15,52 +15,34 @@
1515
package org.eclipse.edc.vault.azure;
1616

1717
import org.eclipse.edc.junit.extensions.DependencyInjectionExtension;
18-
import org.eclipse.edc.spi.security.CertificateResolver;
19-
import org.eclipse.edc.spi.security.PrivateKeyResolver;
20-
import org.eclipse.edc.spi.security.Vault;
21-
import org.eclipse.edc.spi.security.VaultCertificateResolver;
22-
import org.eclipse.edc.spi.security.VaultPrivateKeyResolver;
2318
import org.eclipse.edc.spi.system.ServiceExtensionContext;
24-
import org.eclipse.edc.spi.system.injection.ObjectFactory;
25-
import org.junit.jupiter.api.AfterAll;
26-
import org.junit.jupiter.api.BeforeAll;
27-
import org.junit.jupiter.api.BeforeEach;
19+
import org.eclipse.edc.spi.system.configuration.Config;
2820
import org.junit.jupiter.api.Test;
2921
import org.junit.jupiter.api.extension.ExtendWith;
3022

3123
import static org.assertj.core.api.Assertions.assertThat;
24+
import static org.mockito.Mockito.atLeastOnce;
25+
import static org.mockito.Mockito.mock;
26+
import static org.mockito.Mockito.verify;
27+
import static org.mockito.Mockito.when;
3228

3329
@ExtendWith(DependencyInjectionExtension.class)
3430
public class AzureVaultExtensionTest {
3531

3632
private static final String VAULT_NAME = "aVault";
3733
private static final String VAULT_NAME_SETTING = "edc.vault.name";
3834

39-
private ServiceExtensionContext context;
40-
private AzureVaultExtension extension;
41-
42-
@BeforeEach
43-
void setUp(ServiceExtensionContext context, ObjectFactory factory) {
44-
this.context = context;
45-
extension = factory.constructInstance(AzureVaultExtension.class);
46-
}
4735

4836
@Test
49-
void verifyInitialize() {
50-
extension.initialize(context);
37+
void verifyCreateVault(AzureVaultExtension extension, ServiceExtensionContext context) {
38+
Config cfg = mock();
39+
when(cfg.getString(VAULT_NAME_SETTING)).thenReturn(VAULT_NAME);
40+
when(context.getConfig()).thenReturn(cfg);
5141

52-
assertThat(context.getService(Vault.class)).isInstanceOf(AzureVault.class);
53-
assertThat(context.getService(PrivateKeyResolver.class)).isInstanceOf(VaultPrivateKeyResolver.class);
54-
assertThat(context.getService(CertificateResolver.class)).isInstanceOf(VaultCertificateResolver.class);
55-
}
5642

57-
@BeforeAll
58-
static void setProps() {
59-
System.setProperty(VAULT_NAME_SETTING, VAULT_NAME);
60-
}
43+
assertThat(extension.createVault(context)).isInstanceOf(AzureVault.class);
44+
verify(context, atLeastOnce()).getConfig();
45+
verify(cfg).getString(VAULT_NAME_SETTING);
6146

62-
@AfterAll
63-
static void unsetProps() {
64-
System.clearProperty(VAULT_NAME_SETTING);
6547
}
6648
}

0 commit comments

Comments
 (0)