Skip to content

Commit 140cfa4

Browse files
committed
Restructure tests to follow the integration tests structure
1 parent 7b87cb3 commit 140cfa4

File tree

10 files changed

+56
-15
lines changed

10 files changed

+56
-15
lines changed

src/it/start-admin-commands/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
1515
#
1616

17-
invoker.goals=test
17+
invoker.goals=verify
1818

src/it/start-admin-commands/pom.xml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,17 @@
3232
<version>@project.version@</version>
3333
<executions>
3434
<execution>
35-
<phase>test</phase>
35+
<id>pre-integration</id>
36+
<phase>pre-integration-test</phase>
3637
<goals>
3738
<goal>start</goal>
39+
</goals>
40+
</execution>
41+
<execution>
42+
<id>integration-test</id>
43+
<phase>integration-test</phase>
44+
<goals>
3845
<goal>admin</goal>
39-
<goal>stop</goal>
4046
</goals>
4147
<configuration>
4248
<port>8081</port>
@@ -46,6 +52,13 @@
4652
</commands>
4753
</configuration>
4854
</execution>
55+
<execution>
56+
<id>post-integration</id>
57+
<phase>post-integration-test</phase>
58+
<goals>
59+
<goal>stop</goal>
60+
</goals>
61+
</execution>
4962
</executions>
5063
</plugin>
5164
</plugins>

src/it/start-with-dependency/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
1515
#
1616

17-
invoker.goals=test
17+
invoker.goals=verify
1818

src/it/start-with-dependency/pom.xml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,24 @@
4444
<version>@project.version@</version>
4545
<executions>
4646
<execution>
47-
<phase>test</phase>
47+
<id>pre-integration</id>
48+
<phase>pre-integration-test</phase>
4849
<goals>
4950
<goal>start</goal>
50-
<goal>stop</goal>
5151
</goals>
5252
<configuration>
5353
<port>8081</port>
5454
<!-- Just to test that this version is ignored -->
5555
<glassfishVersion>7.0.0</glassfishVersion>
5656
</configuration>
5757
</execution>
58+
<execution>
59+
<id>post-integration</id>
60+
<phase>post-integration-test</phase>
61+
<goals>
62+
<goal>stop</goal>
63+
</goals>
64+
</execution>
5865
</executions>
5966
<dependencies>
6067
<dependency>

src/it/start-with-gf-version/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
1515
#
1616

17-
invoker.goals=test
17+
invoker.goals=verify
1818

src/it/start-with-gf-version/pom.xml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,23 @@
3232
<version>@project.version@</version>
3333
<executions>
3434
<execution>
35-
<phase>test</phase>
35+
<id>pre-integration</id>
36+
<phase>pre-integration-test</phase>
3637
<goals>
3738
<goal>start</goal>
38-
<goal>stop</goal>
3939
</goals>
4040
<configuration>
4141
<port>8081</port>
4242
<glassfishVersion>@tested.glassfish.version@</glassfishVersion>
4343
</configuration>
4444
</execution>
45+
<execution>
46+
<id>post-integration</id>
47+
<phase>post-integration-test</phase>
48+
<goals>
49+
<goal>stop</goal>
50+
</goals>
51+
</execution>
4552
</executions>
4653
</plugin>
4754
</plugins>

src/it/start-with-version-in-dep-management/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
1515
#
1616

17-
invoker.goals=test
17+
invoker.goals=verify
1818

src/it/start-with-version-in-dep-management/pom.xml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,22 @@
4242
<version>@project.version@</version>
4343
<executions>
4444
<execution>
45-
<phase>test</phase>
45+
<id>pre-integration</id>
46+
<phase>pre-integration-test</phase>
4647
<goals>
4748
<goal>start</goal>
48-
<goal>stop</goal>
4949
</goals>
5050
<configuration>
5151
<port>8081</port>
5252
</configuration>
5353
</execution>
54+
<execution>
55+
<id>post-integration</id>
56+
<phase>post-integration-test</phase>
57+
<goals>
58+
<goal>stop</goal>
59+
</goals>
60+
</execution>
5461
</executions>
5562
</plugin>
5663
</plugins>

src/it/start/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
1515
#
1616

17-
invoker.goals=test
17+
invoker.goals=verify
1818

src/it/start/pom.xml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,22 @@
3232
<version>@project.version@</version>
3333
<executions>
3434
<execution>
35-
<phase>test</phase>
35+
<id>integration</id>
36+
<phase>integration-test</phase>
3637
<goals>
3738
<goal>start</goal>
38-
<goal>stop</goal>
3939
</goals>
4040
<configuration>
4141
<port>8081</port>
4242
</configuration>
4343
</execution>
44+
<execution>
45+
<id>post-integration</id>
46+
<phase>post-integration-test</phase>
47+
<goals>
48+
<goal>stop</goal>
49+
</goals>
50+
</execution>
4451
</executions>
4552
</plugin>
4653
</plugins>

0 commit comments

Comments
 (0)