Skip to content

Commit 4a7d6ed

Browse files
committed
Add missing add-exports
Needed for monitoring, at least in Embedded GlassFish. Otherwise: java.lang.reflect.InaccessibleObjectException: Unable to make public java.util.Enumeration jdk.internal.loader.BuiltinClassLoader.findResources(java.lang.String) throws java.io.IOException accessible: module java.base does not "exports jdk.internal.loader" to unnamed module @1de0aca6 at java.base/java.lang.reflect.AccessibleObject.throwInaccessibleObjectException(AccessibleObject.java:391) at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:367) at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:315) at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:203) at java.base/java.lang.reflect.Method.setAccessible(Method.java:197) at com.sun.enterprise.module.single.ManifestProxy.<init>(ManifestProxy.java:71) at com.sun.enterprise.module.single.ProxyModuleDefinition.generate(ProxyModuleDefinition.java:146) at com.sun.enterprise.module.single.ProxyModuleDefinition.getManifest(ProxyModuleDefinition.java:134) at org.glassfish.admin.monitor.MonitoringBootstrap.addProvider(MonitoringBootstrap.java:298)
1 parent ba65ce2 commit 4a7d6ed

File tree

7 files changed

+17
-7
lines changed

7 files changed

+17
-7
lines changed

appserver/admin/template/src/main/resources/config/domain.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@
223223
<jvm-options>--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED</jvm-options>
224224
<jvm-options>--add-exports=java.base/jdk.internal.vm.annotation=ALL-UNNAMED</jvm-options>
225225
<jvm-options>--add-opens=java.base/jdk.internal.vm.annotation=ALL-UNNAMED</jvm-options>
226+
<jvm-options>--add-exports=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
226227

227228
<!-- To enable attaching the flashlight agent to the current VM in OpenJDK 9+ -->
228229
<jvm-options>-Djdk.attach.allowAttachSelf=true</jvm-options>
@@ -421,6 +422,7 @@
421422
<jvm-options>--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED</jvm-options>
422423
<jvm-options>--add-exports=java.base/jdk.internal.vm.annotation=ALL-UNNAMED</jvm-options>
423424
<jvm-options>--add-opens=java.base/jdk.internal.vm.annotation=ALL-UNNAMED</jvm-options>
425+
<jvm-options>--add-exports=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
424426

425427
<!-- To enable attaching the flashlight agent to the current VM in OpenJDK 9+ -->
426428
<jvm-options>-Djdk.attach.allowAttachSelf=true</jvm-options>

appserver/extras/embedded/all/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@
177177
<Multi-Release>true</Multi-Release>
178178
<Bundle-SymbolicName>org.glassfish.main.embedded.all</Bundle-SymbolicName>
179179
<Main-Class>org.glassfish.runnablejar.UberMain</Main-Class>
180-
<Add-Opens>java.base/java.lang java.base/java.io java.base/java.util java.base/sun.nio.fs java.base/sun.net.www.protocol.jrt java.naming/javax.naming.spi java.rmi/sun.rmi.transport jdk.management/com.sun.management.internal java.base/jdk.internal.vm.annotation</Add-Opens>
181-
<Add-Exports>java.naming/com.sun.jndi.ldap java.base/jdk.internal.vm.annotation</Add-Exports>
180+
<Add-Opens>${glassfish.embedded.add-opens}</Add-Opens>
181+
<Add-Exports>${glassfish.embedded.add-exports}</Add-Exports>
182182
<probe-provider-class-names>${probe.provider.class.names}</probe-provider-class-names>
183183
</manifestEntries>
184184
</archive>

appserver/extras/embedded/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@
2929
<packaging>pom</packaging>
3030

3131
<name>GlassFish Embedded modules</name>
32+
33+
<properties>
34+
<glassfish.embedded.add-opens>java.base/java.lang java.base/java.io java.base/java.util java.base/sun.nio.fs java.base/sun.net.www.protocol.jrt java.naming/javax.naming.spi java.rmi/sun.rmi.transport jdk.management/com.sun.management.internal java.base/jdk.internal.vm.annotation</glassfish.embedded.add-opens>
35+
<glassfish.embedded.add-exports>java.naming/com.sun.jndi.ldap java.base/jdk.internal.vm.annotation java.base/jdk.internal.loader</glassfish.embedded.add-exports>
36+
</properties>
3237

3338
<modules>
3439
<module>common</module>

appserver/extras/embedded/shell/glassfish-embedded-static-shell/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
4-
Copyright (c) 2021, 2024 Contributors to Eclipse Foundation.
4+
Copyright (c) 2021, 2025 Contributors to Eclipse Foundation.
55
Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
66
77
This program and the accompanying materials are made available under the
@@ -1397,8 +1397,8 @@
13971397
<Bundle-SymbolicName>org.glassfish.embedded.static-shell</Bundle-SymbolicName>
13981398
<Class-Path>${classpath.derby} ../asadmin/server-mgmt.jar ../../admin-cli.jar</Class-Path>
13991399
<Main-Class>org.glassfish.runnablejar.UberMain</Main-Class>
1400-
<Add-Opens>java.base/java.lang java.base/java.io java.base/java.util java.base/sun.nio.fs java.base/sun.net.www.protocol.jrt java.naming/javax.naming.spi java.rmi/sun.rmi.transport jdk.management/com.sun.management.internal java.base/jdk.internal.vm.annotation</Add-Opens>
1401-
<Add-Exports>java.naming/com.sun.jndi.ldap java.base/jdk.internal.vm.annotation</Add-Exports>
1400+
<Add-Opens>${glassfish.embedded.add-opens}</Add-Opens>
1401+
<Add-Exports>${glassfish.embedded.add-exports}</Add-Exports>
14021402
</manifestEntries>
14031403
</archive>
14041404
</configuration>

appserver/extras/embedded/web/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@
201201
<Multi-Release>true</Multi-Release>
202202
<Bundle-SymbolicName>org.glassfish.main.embedded.web</Bundle-SymbolicName>
203203
<Main-Class>org.glassfish.runnablejar.UberMain</Main-Class>
204-
<Add-Opens>java.base/java.lang java.base/java.io java.base/java.util java.base/sun.nio.fs java.base/sun.net.www.protocol.jrt java.naming/javax.naming.spi java.rmi/sun.rmi.transport jdk.management/com.sun.management.internal java.base/jdk.internal.vm.annotation</Add-Opens>
205-
<Add-Exports>java.naming/com.sun.jndi.ldap java.base/jdk.internal.vm.annotation</Add-Exports>
204+
<Add-Opens>${glassfish.embedded.add-opens}</Add-Opens>
205+
<Add-Exports>${glassfish.embedded.add-exports}</Add-Exports>
206206
<probe-provider-class-names>${probe.provider.class.names}</probe-provider-class-names>
207207
</manifestEntries>
208208
</archive>

nucleus/admin/template/src/main/resources/config/domain.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@
182182
<jvm-options>--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED</jvm-options>
183183
<jvm-options>--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED</jvm-options>
184184
<jvm-options>--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED</jvm-options>
185+
<jvm-options>--add-exports=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
185186

186187
<!-- To enable attaching the flashlight agent to the current VM in OpenJDK 9+ -->
187188
<jvm-options>-Djdk.attach.allowAttachSelf=true</jvm-options>
@@ -342,6 +343,7 @@
342343
<jvm-options>--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED</jvm-options>
343344
<jvm-options>--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED</jvm-options>
344345
<jvm-options>--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED</jvm-options>
346+
<jvm-options>--add-exports=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
345347
<!-- To enable attaching the flashlight agent to the current VM in OpenJDK 9+ -->
346348
<jvm-options>-Djdk.attach.allowAttachSelf=true</jvm-options>
347349
</java-config>

nucleus/core/kernel/src/test/resources/DomainTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@
151151
<jvm-options>--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED</jvm-options>
152152
<jvm-options>--add-opens=java.naming/javax.naming.spi=org.glassfish.main.jdke</jvm-options>
153153
<jvm-options>--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED</jvm-options>
154+
<jvm-options>--add-exports=java.base/jdk.internal.loader=ALL-UNNAMED</jvm-options>
154155
</java-config>
155156
<network-config>
156157
<protocols>

0 commit comments

Comments
 (0)