Last parser event method removed

Verdent · Verdent · commit a1c14d653e41 · 2022-05-02T11:01:08.000+02:00
Signed-off-by: David Kral &lt;david.k.kral@oracle.com&gt;
diff --git a/src/main/java/org/eclipse/yasson/internal/DeserializationContextImpl.java b/src/main/java/org/eclipse/yasson/internal/DeserializationContextImpl.java
@@ -31,7 +31,6 @@
  */
 public class DeserializationContextImpl extends ProcessingContext implements DeserializationContext {
     private final List<Runnable> delayedSetters = new ArrayList<>();
-    private JsonParser.Event lastValueEvent;
     private Customization customization = ClassCustomization.empty();
     private Object instance;
 
@@ -51,7 +50,6 @@ public DeserializationContextImpl(JsonbContext jsonbContext) {
      */
     public DeserializationContextImpl(DeserializationContextImpl context) {
         super(context.getJsonbContext());
-        this.lastValueEvent = context.lastValueEvent;
     }
 
     /**
@@ -81,24 +79,6 @@ public List<Runnable> getDeferredDeserializers() {
         return delayedSetters;
     }
 
-    /**
-     * Return last obtained {@link JsonParser.Event} event.
-     *
-     * @return last obtained event
-     */
-    public JsonParser.Event getLastValueEvent() {
-        return lastValueEvent;
-    }
-
-    /**
-     * Set last obtained {@link JsonParser.Event} event.
-     *
-     * @param lastValueEvent last obtained event
-     */
-    public void setLastValueEvent(JsonParser.Event lastValueEvent) {
-        this.lastValueEvent = lastValueEvent;
-    }
-
     /**
      * Return customization used by currently processed user defined deserializer.
      *
@@ -130,9 +110,9 @@ public <T> T deserialize(Type type, JsonParser parser) {
     @SuppressWarnings("unchecked")
     private <T> T deserializeItem(Type type, JsonParser parser) {
         try {
-            if (lastValueEvent == null) {
-                lastValueEvent = parser.next();
-                checkState();
+            if (parser.currentEvent() == null) {
+                parser.next();
+                checkState(parser);
             }
             ModelDeserializer<JsonParser> modelDeserializer = getJsonbContext().getChainModelCreator().deserializerChain(type);
             return (T) modelDeserializer.deserialize(parser, this);
@@ -143,8 +123,8 @@ private <T> T deserializeItem(Type type, JsonParser parser) {
         }
     }
 
-    private void checkState() {
-        if (lastValueEvent == JsonParser.Event.KEY_NAME) {
+    private void checkState(JsonParser parser) {
+        if (parser.currentEvent() == JsonParser.Event.KEY_NAME) {
             throw new JsonbException("JsonParser has incorrect position as the first event: KEY_NAME");
         }
     }
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/ArrayDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/ArrayDeserializer.java
@@ -35,9 +35,7 @@ class ArrayDeserializer implements ModelDeserializer<JsonParser> {
     public Object deserialize(JsonParser parser, DeserializationContextImpl context) {
         Collection<Object> collection = new ArrayList<>();
         while (parser.hasNext()) {
-            final JsonParser.Event next = parser.next();
-            context.setLastValueEvent(next);
-            switch (next) {
+            switch (parser.next()) {
             case START_OBJECT:
             case START_ARRAY:
             case VALUE_STRING:
@@ -51,7 +49,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
             case END_ARRAY:
                 return collection;
             default:
-                throw new JsonbException("Unexpected state: " + next);
+                throw new JsonbException("Unexpected state: " + parser.currentEvent());
             }
         }
         return collection;
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/CollectionDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/CollectionDeserializer.java
@@ -35,9 +35,7 @@ class CollectionDeserializer implements ModelDeserializer<JsonParser> {
     public Object deserialize(JsonParser parser, DeserializationContextImpl context) {
         Collection<Object> collection = (Collection<Object>) context.getInstance();
         while (parser.hasNext()) {
-            final JsonParser.Event next = parser.next();
-            context.setLastValueEvent(next);
-            switch (next) {
+            switch (parser.next()) {
             case VALUE_NULL:
             case START_OBJECT:
             case START_ARRAY:
@@ -51,7 +49,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
             case END_ARRAY:
                 return collection;
             default:
-                throw new JsonbException("Unexpected state: " + next);
+                throw new JsonbException("Unexpected state: " + parser.currentEvent());
             }
         }
         return collection;
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/ContextSwitcher.java b/src/main/java/org/eclipse/yasson/internal/deserializer/ContextSwitcher.java
@@ -33,8 +33,6 @@ class ContextSwitcher implements ModelDeserializer<JsonParser> {
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
         DeserializationContextImpl ctx = new DeserializationContextImpl(context);
-        Object returnedValue = delegate.deserialize(modelDeserializer.deserialize(value, ctx), context);
-        context.setLastValueEvent(ctx.getLastValueEvent());
-        return returnedValue;
+        return delegate.deserialize(modelDeserializer.deserialize(value, ctx), context);
     }
 }
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/InheritanceInstanceCreator.java b/src/main/java/org/eclipse/yasson/internal/deserializer/InheritanceInstanceCreator.java
@@ -58,8 +58,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
                 .build();
         jsonParser = new JsonStructureToParserAdapter(newJsonObject);
         //To get to the first event
-        Event event = jsonParser.next();
-        context.setLastValueEvent(event);
+        jsonParser.next();
         Class<?> polymorphicTypeClass;
         if (alias == null) {
             return defaultProcessor.deserialize(jsonParser, context);
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/JsonbCreatorDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/JsonbCreatorDeserializer.java
@@ -65,9 +65,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
         String key = null;
         Map<String, Object> paramValues = new HashMap<>();
         while (parser.hasNext()) {
-            final JsonParser.Event next = parser.next();
-            context.setLastValueEvent(next);
-            switch (next) {
+            switch (parser.next()) {
             case KEY_NAME:
                 key = renamer.apply(parser.getString());
                 break;
@@ -106,7 +104,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
                 context.getDeferredDeserializers().clear();
                 return context.getInstance();
             default:
-                throw new JsonbException("Unexpected state: " + next);
+                throw new JsonbException("Unexpected state: " + parser.currentEvent());
             }
         }
         return context.getInstance();
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/MapDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/MapDeserializer.java
@@ -43,9 +43,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
         Mode mode = Mode.NONE;
         State state = State.NEXT;
         while (parser.hasNext()) {
-            final JsonParser.Event next = parser.next();
-            context.setLastValueEvent(next);
-            switch (next) {
+            switch (parser.next()) {
             case KEY_NAME:
                 mode = mode == Mode.NONE ? Mode.NORMAL : mode;
                 if (mode == Mode.NORMAL) {
@@ -89,7 +87,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
             case END_ARRAY:
                 return map;
             default:
-                throw new JsonbException("Unexpected state: " + next);
+                throw new JsonbException("Unexpected state: " + parser.currentEvent());
             }
         }
         return map;
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/NullCheckDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/NullCheckDeserializer.java
@@ -42,7 +42,7 @@ public NullCheckDeserializer(ModelDeserializer<JsonParser> nonNullDeserializer,
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        if (context.getLastValueEvent() != JsonParser.Event.VALUE_NULL) {
+        if (value.currentEvent() != JsonParser.Event.VALUE_NULL) {
             return nonNullDeserializer.deserialize(value, context);
         }
         return nullDeserializer.deserialize(null, context);
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/ObjectDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/ObjectDeserializer.java
@@ -50,9 +50,7 @@ class ObjectDeserializer implements ModelDeserializer<JsonParser> {
     public Object deserialize(JsonParser parser, DeserializationContextImpl context) {
         String key = null;
         while (parser.hasNext()) {
-            final JsonParser.Event next = parser.next();
-            context.setLastValueEvent(next);
-            switch (next) {
+            switch (parser.next()) {
             case KEY_NAME:
                 key = renamer.apply(parser.getString());
                 break;
@@ -78,7 +76,7 @@ public Object deserialize(JsonParser parser, DeserializationContextImpl context)
             case END_OBJECT:
                 return context.getInstance();
             default:
-                throw new JsonbException("Unexpected state: " + next);
+                throw new JsonbException("Unexpected state: " + parser.currentEvent());
             }
         }
         return context.getInstance();
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/PositionChecker.java b/src/main/java/org/eclipse/yasson/internal/deserializer/PositionChecker.java
@@ -71,11 +71,10 @@ private PositionChecker(Set<Event> expectedEvents,
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        Event original = context.getLastValueEvent();
+        Event original = value.currentEvent();
         Event startEvent = original;
         if (!expectedEvents.contains(startEvent)) {
             startEvent = value.next();
-            context.setLastValueEvent(startEvent);
             if (!expectedEvents.contains(startEvent)) {
                 throw new JsonbException("Incorrect position for processing type: " + rType + ". "
                                                  + "Received event: " + original + " "
@@ -84,10 +83,10 @@ public Object deserialize(JsonParser value, DeserializationContextImpl context)
         }
         Object o = delegate.deserialize(value, context);
         if (CLOSING_EVENTS.containsKey(startEvent)
-                && CLOSING_EVENTS.get(startEvent) != context.getLastValueEvent()) {
+                && CLOSING_EVENTS.get(startEvent) != value.currentEvent()) {
             throw new JsonbException("Incorrect parser position after processing of the type: " + rType + ". "
                                              + "Start event: " + startEvent + " "
-                                             + "After processing event: " + context.getLastValueEvent());
+                                             + "After processing event: " + value.currentEvent());
         }
         return o;
     }
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/UserDefinedDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/UserDefinedDeserializer.java
@@ -65,10 +65,9 @@ public Object deserialize(JsonParser value, DeserializationContextImpl context)
         //            return exactType.deserialize(value, newContext);
         //        }
         //        newContext.getUserProcessorChain().add(userDefinedDeserializer.getClass());
-        YassonParser yassonParser = new YassonParser(value, context.getLastValueEvent(), newContext);
+        YassonParser yassonParser = new YassonParser(value, value.currentEvent());
         Object object = userDefinedDeserializer.deserialize(yassonParser, newContext, rType);
         yassonParser.skipRemaining();
-        context.setLastValueEvent(newContext.getLastValueEvent());
         return delegate.deserialize(object, context);
     }
 
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/ValueExtractor.java b/src/main/java/org/eclipse/yasson/internal/deserializer/ValueExtractor.java
@@ -36,7 +36,7 @@ public ValueExtractor(TypeDeserializer delegate) {
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        JsonParser.Event last = context.getLastValueEvent();
+        JsonParser.Event last = value.currentEvent();
         switch (last) {
         case VALUE_TRUE:
             return delegate.deserialize(Boolean.TRUE, context);
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/YassonParser.java b/src/main/java/org/eclipse/yasson/internal/deserializer/YassonParser.java
@@ -33,12 +33,10 @@
 class YassonParser implements JsonParser {
 
     private final JsonParser delegate;
-    private final DeserializationContextImpl context;
     private int level;
 
-    YassonParser(JsonParser delegate, Event firstEvent, DeserializationContextImpl context) {
+    YassonParser(JsonParser delegate, Event firstEvent) {
         this.delegate = delegate;
-        this.context = context;
         this.level = determineLevelValue(firstEvent);
     }
 
@@ -70,7 +68,6 @@ public boolean hasNext() {
     public Event next() {
         validate();
         Event next = delegate.next();
-        context.setLastValueEvent(next);
         switch (next) {
         case START_OBJECT:
         case START_ARRAY:
@@ -120,14 +117,12 @@ public JsonLocation getLocation() {
     public JsonObject getObject() {
         validate();
         level--;
-        JsonObject jsonObject = delegate.getObject();
-        context.setLastValueEvent(Event.END_OBJECT);
-        return jsonObject;
+        return delegate.getObject();
     }
 
     @Override
     public JsonValue getValue() {
-        final Event currentLevel = context.getLastValueEvent();
+        final Event currentLevel = delegate.currentEvent();
         switch (currentLevel) {
         case START_ARRAY:
             return getArray();
@@ -142,9 +137,7 @@ public JsonValue getValue() {
     public JsonArray getArray() {
         validate();
         level--;
-        JsonArray array = delegate.getArray();
-        context.setLastValueEvent(Event.END_ARRAY);
-        return array;
+        return delegate.getArray();
     }
 
     @Override
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/types/JsonValueDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/types/JsonValueDeserializer.java
@@ -34,7 +34,7 @@ class JsonValueDeserializer implements ModelDeserializer<JsonParser> {
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        JsonParser.Event last = context.getLastValueEvent();
+        JsonParser.Event last = value.currentEvent();
         return delegate.deserialize(deserializeValue(last, value), context);
     }
 
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/types/ObjectTypeDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/types/ObjectTypeDeserializer.java
@@ -40,7 +40,7 @@ class ObjectTypeDeserializer implements ModelDeserializer<JsonParser> {
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
         Object toSet;
-        switch (context.getLastValueEvent()) {
+        switch (value.currentEvent()) {
         case VALUE_TRUE:
             toSet = Boolean.TRUE;
             break;
@@ -63,7 +63,7 @@ public Object deserialize(JsonParser value, DeserializationContextImpl context)
             toSet = newContext1.deserialize(LIST, value);
             break;
         default:
-            throw new JsonbException("Unexpected event: " + context.getLastValueEvent());
+            throw new JsonbException("Unexpected event: " + value.currentEvent());
         }
         return delegate.deserialize(toSet, context);
     }
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/types/OptionalDoubleDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/types/OptionalDoubleDeserializer.java
@@ -34,7 +34,7 @@ class OptionalDoubleDeserializer implements ModelDeserializer<JsonParser> {
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        if (context.getLastValueEvent() == JsonParser.Event.VALUE_NULL) {
+        if (value.currentEvent() == JsonParser.Event.VALUE_NULL) {
             return nullValueDelegate.deserialize(OptionalDouble.empty(), context);
         }
         OptionalDouble optional = OptionalDouble.of((Double) extractor.deserialize(value, context));
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/types/OptionalIntDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/types/OptionalIntDeserializer.java
@@ -34,7 +34,7 @@ class OptionalIntDeserializer implements ModelDeserializer<JsonParser> {
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        if (context.getLastValueEvent() == JsonParser.Event.VALUE_NULL) {
+        if (value.currentEvent() == JsonParser.Event.VALUE_NULL) {
             return delegate.deserialize(OptionalInt.empty(), context);
         }
         OptionalInt optional = OptionalInt.of((Integer) extractor.deserialize(value, context));
diff --git a/src/main/java/org/eclipse/yasson/internal/deserializer/types/OptionalLongDeserializer.java b/src/main/java/org/eclipse/yasson/internal/deserializer/types/OptionalLongDeserializer.java
@@ -34,7 +34,7 @@ class OptionalLongDeserializer implements ModelDeserializer<JsonParser> {
 
     @Override
     public Object deserialize(JsonParser value, DeserializationContextImpl context) {
-        if (context.getLastValueEvent() == JsonParser.Event.VALUE_NULL) {
+        if (value.currentEvent() == JsonParser.Event.VALUE_NULL) {
             return nullValueDelegate.deserialize(OptionalLong.empty(), context);
         }
         OptionalLong optional = OptionalLong.of((Long) extractor.deserialize(value, context));

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,6 @@ class ContextSwitcher implements ModelDeserializer<JsonParser> {`
`33`	`33`	`@Override`
`34`	`34`	`public Object deserialize(JsonParser value, DeserializationContextImpl context) {`
`35`	`35`	`DeserializationContextImpl ctx = new DeserializationContextImpl(context);`
`36`		`- Object returnedValue = delegate.deserialize(modelDeserializer.deserialize(value, ctx), context);`
`37`		`- context.setLastValueEvent(ctx.getLastValueEvent());`
`38`		`- return returnedValue;`
	`36`	`+ return delegate.deserialize(modelDeserializer.deserialize(value, ctx), context);`
`39`	`37`	`}`
`40`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public NullCheckDeserializer(ModelDeserializer<JsonParser> nonNullDeserializer,`
`42`	`42`
`43`	`43`	`@Override`
`44`	`44`	`public Object deserialize(JsonParser value, DeserializationContextImpl context) {`
`45`		`- if (context.getLastValueEvent() != JsonParser.Event.VALUE_NULL) {`
	`45`	`+ if (value.currentEvent() != JsonParser.Event.VALUE_NULL) {`
`46`	`46`	`return nonNullDeserializer.deserialize(value, context);`
`47`	`47`	`}`
`48`	`48`	`return nullDeserializer.deserialize(null, context);`