Skip to content

TheiaBackendModelServerClientV2.edit() does not work with CompoundCommand #144

@kubomann

Description

@kubomann

TheiaModelServerClientV2.edit() worked if I set the SetCommand as an argument.
However, it didn't work if I included SetCommand in CompoundCommand and set CompoundCommand as an argument.

TheiaBackendModelServerClientV2.edit() is currently implemented as follows:

    edit(modeluri: URI, patchOrCommand: PatchOrCommand, format?: Format): Promise<ModelUpdateResult> {
        if (ModelServerCommand.is(patchOrCommand)) {
            return super.edit(modeluri, ensureCommandPrototype(patchOrCommand));
        }
        return super.edit(modeluri, patchOrCommand, format);
    }

The if clause should check for both command types (e.g. like if (ModelServerCommand.is(patchOrCommand) || CompoundCommand.is(patchOrCommand))).

( refs. eclipse-emfcloud/emfcloud#209 )

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingmodelserverEMF.cloud Model Server Theia

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions