-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
bugSomething isn't workingSomething isn't workingmodelserverEMF.cloud Model Server TheiaEMF.cloud Model Server Theia
Description
TheiaModelServerClientV2.edit() worked if I set the SetCommand as an argument.
However, it didn't work if I included SetCommand in CompoundCommand and set CompoundCommand as an argument.
TheiaBackendModelServerClientV2.edit() is currently implemented as follows:
edit(modeluri: URI, patchOrCommand: PatchOrCommand, format?: Format): Promise<ModelUpdateResult> {
if (ModelServerCommand.is(patchOrCommand)) {
return super.edit(modeluri, ensureCommandPrototype(patchOrCommand));
}
return super.edit(modeluri, patchOrCommand, format);
}The if clause should check for both command types (e.g. like if (ModelServerCommand.is(patchOrCommand) || CompoundCommand.is(patchOrCommand))).
( refs. eclipse-emfcloud/emfcloud#209 )
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingmodelserverEMF.cloud Model Server TheiaEMF.cloud Model Server Theia