TransactionalPropertySource.resetPropertyValue(Object) has poor implementation.

[pcdavid]

• 🆔 Bugzilla ID: #428457
• 📘 Project: Modeling / EMF Services / Transaction
• 🗓 Created: 2014-02-18T16:33:32Z
• ❓ Status: NEW /

[pcdavid]

Comment #0 on Tue Feb 18 2014 17:33:32 GMT+0100 (Central European Standard Time):

The following method in TransactionalPropertySource should be parallel to all the other methods.


	public void resetPropertyValue(final Object id) {
		if (propertySource2 != null) {
			// are we in a read-only context?  if so, balk because we cannot upgrade
			//    read transaction to write when executing a command
			Transaction tx = ((InternalTransactionalEditingDomain) domain).getActiveTransaction();
			if ((tx == null) || !tx.isReadOnly()) {
				propertySource2.resetPropertyValue(id);
			}
		}
	}

I.e., propertySource2 is only needed in 

	public boolean isPropertyResettable(Object id) {
		return (propertySource2 == null)? false
				: propertySource2.isPropertyResettable(id);
	}

because that's the only place where the IPropertySource2 API is needed.  In the current implementation, the propertySource might not be an IPropertySource2 instance and in that case, reset does nothing.

---

Comment #1 on Sat May 14 2022 15:51:22 GMT+0200 (Central European Summer Time):

Eclipse EMF Transaction is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/emf-transaction.

If this issue is relevant to you and still present in the latest release:

* Create a new issue at https://github.com/eclipse/emf-transaction/issues/.
  * Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  * In the GitHub description, start with a link to this bugzilla ticket
  * Optionally add new content to the description if it can helps towards resolution
* Update bugzilla ticket
  * Add to "See also" property (up right column) the link to the newly created GitHub issue
  * Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  * Set status as CLOSED MOVED

All issues that remain open will be automatically closed next week or so. Then the Bugzilla component for EMF Transaction will be archived and made read-only.