Correct handling of SLF4J error log calls

Kummallinen · laeubi · commit bf9df0eb2d1c · 2026-03-26T07:54:25.000+01:00
Correct enabled check & fix to log as error not info Issue #1253
diff --git a/bundles/org.eclipse.equinox.slf4j/src/org/eclipse/equinox/slf4j/EquinoxLogger.java b/bundles/org.eclipse.equinox.slf4j/src/org/eclipse/equinox/slf4j/EquinoxLogger.java
@@ -109,9 +109,9 @@ protected void handleNormalizedLoggingCall(Level level, Marker marker, String me
 			String formattedMessage = safeBasicArrayFormat(messagePattern, arguments);
 			logger.info(formattedMessage, loggerArguments);
 		}
-		if(level == Level.ERROR && logger.isInfoEnabled()) {
+		if(level == Level.ERROR && logger.isErrorEnabled()) {
 			String formattedMessage = safeBasicArrayFormat(messagePattern, arguments);
-			logger.info(formattedMessage, loggerArguments);
+			logger.error(formattedMessage, loggerArguments);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,9 @@ protected void handleNormalizedLoggingCall(Level level, Marker marker, String me`
`109`	`109`	`String formattedMessage = safeBasicArrayFormat(messagePattern, arguments);`
`110`	`110`	`logger.info(formattedMessage, loggerArguments);`
`111`	`111`	`}`
`112`		`- if(level == Level.ERROR && logger.isInfoEnabled()) {`
	`112`	`+ if(level == Level.ERROR && logger.isErrorEnabled()) {`
`113`	`113`	`String formattedMessage = safeBasicArrayFormat(messagePattern, arguments);`
`114`		`- logger.info(formattedMessage, loggerArguments);`
	`114`	`+ logger.error(formattedMessage, loggerArguments);`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`