Usage of ILegacyPreferences

[vogella]

ILegacyPreferences is currently opened as a blocking service, see bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PreferencesOSGiUtils.java

   2 initTracker = new ServiceTracker<>(context, ILegacyPreferences.class, null);
   3 initTracker.open(true); // BLOCKS until service is found

@tjwatson the name implies that this is something we should phase out, I see it is still configured in eclipse.platform. Do you remember why we have this service? Can we open it non-blocking or remove it entirely?

[laeubi]

initTracker.open(true); // BLOCKS until service is found

This is nonsense... a service tracker does not block in any way (unless you use waitForService). If you open it it just fetches all services that are present but if no such service exits then nothing will happen at all.

Can we open it non-blocking or remove it entirely?

You need to check all call sites that access the service and replace it with something else (e.g. SCR) or make them open the tracker lazily)