Fix/findings on rc (#91)

* Remove validatePackage endpoint and service method

Deleted the validatePackage method from PackageService and its corresponding endpoint from PackageController. This streamlines the API by removing unused or deprecated validation functionality for uploaded ZIP files.

* Update ESMF SDK version and refactor imports

Bump esmf-sdk-version to 2.11.1 in pom.xml. Refactor imports in ModelUtils, ViolationFormatter, and ValidationUtils to use new locations for ProcessingViolation and InvalidSyntaxViolation, and update method signature in ModelUtils to use AspectModelFile.

* Refactor model file handling and validation logic

Replaces usage of StructuredModelsRoot with AspectModelLoader for file deletion. Updates validation and formatting methods to filter aspect model files by 'inmemory' source scheme instead of checking for empty source location.

* Refactor services to use CompletedFileUpload for model input

Service methods now accept CompletedFileUpload and URI instead of raw Turtle strings for aspect model input, improving file handling and consistency. Added MockFileUpload for testing, updated tests and utility methods, and enhanced model grouping logic to support filtering by aspect models.

* Remove FileWriteException and related references

Deleted the FileWriteException class and removed its usage from GlobalExceptionHandler. Also cleaned up unused code in ApplicationSettings, ModelService, ModelUtils, and refactored MockFileUpload to use a record for simplicity.

* Refactor model version handling and update URI scheme

Replaces 'inmemory' URI scheme with 'blob' throughout service and tests. Adds version field to Model, updates grouping logic to extract and assign meta model version, and refines version processing in ModelService to skip non-latest versions and improve file creation logic.

* Refactor aspect model versioning and file handling

Simplifies the process of saving aspect model files by removing the saveAspectModelFiles method and updating logic to use AspectSerializer directly. The applyNamespaceVersionChange method now accepts an errors list and throws a FileHandlingException for missing filenames, improving error reporting and exception handling.

* Refactor model file creation and validation logic

Introduces improved file creation methods in ModelUtils, adds duplicate element checks, and refactors ModelService to use new validation and file creation utilities. Exception handling and violation checks are now more robust and modular.

* Increase logging for native image build in CI

Adds SLF4J simple logger properties to Maven commands in the native image build steps for Mac, Linux, and Windows in the pull request workflow. This change sets the default log level to info and enables info-level logging for org.apache.jena, improving build output visibility.

* Move SLF4J log level config from workflow to pom.xml

Removes SLF4J log level and Apache Jena logger configuration from GitHub Actions workflow and sets them as system properties in the Maven Surefire plugin configuration in the respective pom.xml files. This centralizes logging configuration within the project build files for consistency across environments.

* Move Jena log level config from pom.xml to logback.xml

Removed SLF4J simple logger system properties for org.apache.jena from the Maven plugin configurations in both runtime and service modules. Added explicit logger configuration for org.apache.jena at INFO level in logback.xml to centralize logging configuration.

* Set root logger level to INFO and update logback config

Added logger.levels.root=INFO to all application properties files to explicitly set the root logging level. Removed redundant org.apache.jena logger entry from logback.xml to streamline logging configuration.

* Remove verbose options from native image build config

Eliminated the <verbose> and --verbose options from the native image build configuration in pom.xml to reduce build output verbosity.

* Remove unused GraalVM native-image arguments

Deleted the -H:+ReportExceptionStackTraces and -H:+PrintClassInitialization arguments from the native-image configuration in pom.xml as they are no longer needed.

* Add test logging configuration files

Introduce application-test.properties and logback.xml for configuring logging during tests in aspect-model-editor-service. Sets root logger level to ERROR and defines logback appenders and logger levels for Micronaut components.

* Refactor workspace migration to accept storage path

Updated ModelService and related calls to require an explicit metaModelStoragePath parameter for workspace migration, removing reliance on ApplicationSettings within the service. Adjusted tests, controller, and properties to support this change and improved configuration clarity.

* Normalize file paths for URI creation in tests

Introduced a toUriPath helper method to ensure file paths are converted to URI-compatible format, especially handling Windows path separators. Updated all test usages to apply this normalization when constructing URIs from file paths.

* Fix file path handling for URIs in tests

Introduced a toUriPath helper to ensure file paths are correctly formatted as URI paths, especially on Windows. Updated validateModel and migrateModel test calls to use this helper for consistent cross-platform behavior.

* Switch API requests to multipart form with file upload

Updated multiple Bruno API request definitions to use multipart form data and file upload for aspect models, replacing previous usage of plain text bodies. Added references to new test files in the TestingFiles directory to support file-based testing.

* Update ModelService.java

Author: michelu89

aspect-model-editor-core/src/main/java/org/eclipse/esmf/ame/config/ApplicationSettings.java

@@ -44,8 +44,4 @@ private ApplicationSettings() {
    public static Path getMetaModelStoragePath() {
       return Path.of( META_MODEL_PATH );
    }
-
-   public static Path getEndFilePath() {
-      return Path.of( END_FILE_PATH );
-   }
 }

aspect-model-editor-core/src/main/java/org/eclipse/esmf/ame/exceptions/CreateFileException.java

@@ -19,6 +19,15 @@ public class CreateFileException extends RuntimeException {
    @Serial
    private static final long serialVersionUID = 1L;
 
+   /**
+    * Constructs a CreateFileException with message and cause.
+    *
+    * @param message the message of the exception
+    */
+   public CreateFileException( final String message ) {
+      super( message );
+   }
+
    /**
     * Constructs a CreateFileException with message and cause.
     *

…f/ame/exceptions/FileWriteException.java …e/exceptions/UriNotDefinedException.javaaspect-model-editor-core/src/main/java/org/eclipse/esmf/ame/exceptions/FileWriteException.java renamed to aspect-model-editor-core/src/main/java/org/eclipse/esmf/ame/exceptions/UriNotDefinedException.java aspect-model-editor-core/src/main/java/org/eclipse/esmf/ame/exceptions/FileWriteException.java renamed to aspect-model-editor-core/src/main/java/org/eclipse/esmf/ame/exceptions/UriNotDefinedException.java

@@ -15,17 +15,16 @@
 
 import java.io.Serial;
 
-public class FileWriteException extends RuntimeException {
+public class UriNotDefinedException extends RuntimeException {
    @Serial
    private static final long serialVersionUID = 1L;
 
    /**
-    * Constructs a FileWriteException with message and cause.
+    * Constructs a UriNotDefinedException with message, cause and value.
     *
     * @param message the message of the exception
-    * @param cause of the exception
     */
-   public FileWriteException( final String message, final Throwable cause ) {
-      super( message, cause );
+   public UriNotDefinedException( final String message ) {
+      super( message );
    }
 }

aspect-model-editor-runtime/bruno/FormateAspectModel.bru

@@ -6,12 +6,12 @@ meta {
 
 post {
   url: http://localhost:{{port}}/ame/api/models/format
-  body: text
+  body: multipartForm
   auth: none
 }
 
 headers {
-  Content-Type: text/plain
+  uri: blob://movement.ttl
 }
 
 body:text {
@@ -110,6 +110,14 @@ body:text {
 
 }
 
+body:multipart-form {
+  aspectModel: @file(./TestingFiles/Movement.ttl)
+}
+
+body:file {
+  ~file: @file()
+}
+
 tests {
   test("Status code is 200", function() {
     expect(res.getStatus()).to.equal(200);})

aspect-model-editor-runtime/bruno/GenerateAASX.bru

@@ -1,121 +1,125 @@
-meta {
-  name: GenerateAASX
-  type: http
-  seq: 27
-}
-
-post {
-  url: http://localhost:{{port}}/ame/api/generate/aasx
-  body: text
-  auth: none
-}
-
-headers {
-  Content-Type: text/plain
-}
-
-body:text {
-  @prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.2.0#> .
-  @prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.2.0#> .
-  @prefix samm-e: <urn:samm:org.eclipse.esmf.samm:entity:2.2.0#> .
-  @prefix unit: <urn:samm:org.eclipse.esmf.samm:unit:2.2.0#> .
-  @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
-  @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
-  @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
-  @prefix : <urn:samm:org.eclipse.examples:1.0.0#> .
-  
-  :Movement a samm:Aspect ;
-     samm:preferredName "movement"@en ;
-     samm:description "Aspect for movement information"@en ;
-     samm:properties ( :isMoving :position :speed :speedLimitWarning ) ;
-     samm:operations ( ) ;
-     samm:events ( ) .
-  
-  :isMoving a samm:Property ;
-     samm:preferredName "is moving"@en ;
-     samm:description "Flag indicating whether the asset is currently moving"@en ;
-     samm:characteristic samm-c:Boolean .
-  
-  :position a samm:Property ;
-     samm:preferredName "position"@en ;
-     samm:description "Indicates a position"@en ;
-     samm:characteristic :SpatialPositionCharacteristic .
-  
-  :speed a samm:Property ;
-     samm:preferredName "speed"@en ;
-     samm:description "speed of vehicle"@en ;
-     samm:characteristic :Speed .
-  
-  :speedLimitWarning a samm:Property ;
-     samm:preferredName "speed limit warning"@en ;
-     samm:description "Indicates if the speed limit is adhered to."@en ;
-     samm:characteristic :TrafficLight .
-  
-  :SpatialPositionCharacteristic a samm-c:SingleEntity ;
-     samm:preferredName "spatial position characteristic"@en ;
-     samm:description "Represents a single position in space with optional z coordinate."@en ;
-     samm:dataType :SpatialPosition .
-  
-  :Speed a samm-c:Measurement ;
-     samm:preferredName "speed"@en ;
-     samm:description "Scalar representation of speed of an object in kilometers per hour."@en ;
-     samm:dataType xsd:float ;
-     samm-c:unit unit:kilometrePerHour .
-  
-  :TrafficLight a samm-c:Enumeration ;
-     samm:preferredName "warning level"@en ;
-     samm:description "Represents if speed of position change is within specification (green), within tolerance (yellow), or outside specification (red)."@en ;
-     samm:dataType xsd:string ;
-     samm-c:values ( "green" "yellow" "red" ) .
-  
-  :SpatialPosition a samm:Entity ;
-     samm:preferredName "spatial position"@en ;
-     samm:description "Represents latitude, longitude and altitude information in the WGS84 geodetic reference datum"@en ;
-     samm:see <https://www.w3.org/2003/01/geo/> ;
-     samm:properties ( :latitude :longitude [ samm:property :altitude; samm:optional true ] ) .
-  
-  :latitude a samm:Property ;
-     samm:preferredName "latitude"@en ;
-     samm:description "latitude coordinate in space (WGS84)"@en ;
-     samm:see <http://www.w3.org/2003/01/geo/wgs84_pos#lat> ;
-     samm:characteristic :Coordinate ;
-     samm:exampleValue "9.1781"^^xsd:decimal .
-  
-  :longitude a samm:Property ;
-     samm:preferredName "longitude"@en ;
-     samm:description "longitude coordinate in space (WGS84)"@en ;
-     samm:see <http://www.w3.org/2003/01/geo/wgs84_pos#long> ;
-     samm:characteristic :Coordinate ;
-     samm:exampleValue "48.80835"^^xsd:decimal .
-  
-  :altitude a samm:Property ;
-     samm:preferredName "altitude"@en ;
-     samm:description "Elevation above sea level zero"@en ;
-     samm:see <http://www.w3.org/2003/01/geo/wgs84_pos#alt> ;
-     samm:characteristic :MetresAboveMeanSeaLevel ;
-     samm:exampleValue "153"^^xsd:float .
-  
-  :Coordinate a samm-c:Measurement ;
-     samm:preferredName "coordinate"@en ;
-     samm:description "Representing the geographical coordinate"@en ;
-     samm:dataType xsd:decimal ;
-     samm-c:unit unit:degreeUnitOfAngle .
-  
-  :MetresAboveMeanSeaLevel a samm-c:Measurement ;
-     samm:preferredName "metres above mean sea level"@en ;
-     samm:description "Signifies the vertical distance in reference to a historic mean sea level as a vertical datum"@en ;
-     samm:see <https://en.wikipedia.org/wiki/Height_above_sea_level> ;
-     samm:dataType xsd:float ;
-     samm-c:unit unit:metre .
-  
-}
-
-tests {
-  test("Status code is 200", function() {
-    expect(res.getStatus()).to.equal(200);
-  });
-  test("Response body is valid", function () {
-    const data = res.getBody();
-    expect(data).to.contains("aasx");
-  })
-}
+meta {
+  name: GenerateAASX
+  type: http
+  seq: 27
+}
+
+post {
+  url: http://localhost:{{port}}/ame/api/generate/aasx
+  body: multipartForm
+  auth: none
+}
+
+headers {
+  uri: blob://movement.ttl
+}
+
+body:text {
+  @prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.2.0#> .
+  @prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.2.0#> .
+  @prefix samm-e: <urn:samm:org.eclipse.esmf.samm:entity:2.2.0#> .
+  @prefix unit: <urn:samm:org.eclipse.esmf.samm:unit:2.2.0#> .
+  @prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+  @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+  @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+  @prefix : <urn:samm:org.eclipse.examples:1.0.0#> .
+  
+  :Movement a samm:Aspect ;
+     samm:preferredName "movement"@en ;
+     samm:description "Aspect for movement information"@en ;
+     samm:properties ( :isMoving :position :speed :speedLimitWarning ) ;
+     samm:operations ( ) ;
+     samm:events ( ) .
+  
+  :isMoving a samm:Property ;
+     samm:preferredName "is moving"@en ;
+     samm:description "Flag indicating whether the asset is currently moving"@en ;
+     samm:characteristic samm-c:Boolean .
+  
+  :position a samm:Property ;
+     samm:preferredName "position"@en ;
+     samm:description "Indicates a position"@en ;
+     samm:characteristic :SpatialPositionCharacteristic .
+  
+  :speed a samm:Property ;
+     samm:preferredName "speed"@en ;
+     samm:description "speed of vehicle"@en ;
+     samm:characteristic :Speed .
+  
+  :speedLimitWarning a samm:Property ;
+     samm:preferredName "speed limit warning"@en ;
+     samm:description "Indicates if the speed limit is adhered to."@en ;
+     samm:characteristic :TrafficLight .
+  
+  :SpatialPositionCharacteristic a samm-c:SingleEntity ;
+     samm:preferredName "spatial position characteristic"@en ;
+     samm:description "Represents a single position in space with optional z coordinate."@en ;
+     samm:dataType :SpatialPosition .
+  
+  :Speed a samm-c:Measurement ;
+     samm:preferredName "speed"@en ;
+     samm:description "Scalar representation of speed of an object in kilometers per hour."@en ;
+     samm:dataType xsd:float ;
+     samm-c:unit unit:kilometrePerHour .
+  
+  :TrafficLight a samm-c:Enumeration ;
+     samm:preferredName "warning level"@en ;
+     samm:description "Represents if speed of position change is within specification (green), within tolerance (yellow), or outside specification (red)."@en ;
+     samm:dataType xsd:string ;
+     samm-c:values ( "green" "yellow" "red" ) .
+  
+  :SpatialPosition a samm:Entity ;
+     samm:preferredName "spatial position"@en ;
+     samm:description "Represents latitude, longitude and altitude information in the WGS84 geodetic reference datum"@en ;
+     samm:see <https://www.w3.org/2003/01/geo/> ;
+     samm:properties ( :latitude :longitude [ samm:property :altitude; samm:optional true ] ) .
+  
+  :latitude a samm:Property ;
+     samm:preferredName "latitude"@en ;
+     samm:description "latitude coordinate in space (WGS84)"@en ;
+     samm:see <http://www.w3.org/2003/01/geo/wgs84_pos#lat> ;
+     samm:characteristic :Coordinate ;
+     samm:exampleValue "9.1781"^^xsd:decimal .
+  
+  :longitude a samm:Property ;
+     samm:preferredName "longitude"@en ;
+     samm:description "longitude coordinate in space (WGS84)"@en ;
+     samm:see <http://www.w3.org/2003/01/geo/wgs84_pos#long> ;
+     samm:characteristic :Coordinate ;
+     samm:exampleValue "48.80835"^^xsd:decimal .
+  
+  :altitude a samm:Property ;
+     samm:preferredName "altitude"@en ;
+     samm:description "Elevation above sea level zero"@en ;
+     samm:see <http://www.w3.org/2003/01/geo/wgs84_pos#alt> ;
+     samm:characteristic :MetresAboveMeanSeaLevel ;
+     samm:exampleValue "153"^^xsd:float .
+  
+  :Coordinate a samm-c:Measurement ;
+     samm:preferredName "coordinate"@en ;
+     samm:description "Representing the geographical coordinate"@en ;
+     samm:dataType xsd:decimal ;
+     samm-c:unit unit:degreeUnitOfAngle .
+  
+  :MetresAboveMeanSeaLevel a samm-c:Measurement ;
+     samm:preferredName "metres above mean sea level"@en ;
+     samm:description "Signifies the vertical distance in reference to a historic mean sea level as a vertical datum"@en ;
+     samm:see <https://en.wikipedia.org/wiki/Height_above_sea_level> ;
+     samm:dataType xsd:float ;
+     samm-c:unit unit:metre .
+  
+}
+
+body:multipart-form {
+  aspectModel: @file(./TestingFiles/Movement.ttl)
+}
+
+tests {
+  test("Status code is 200", function() {
+    expect(res.getStatus()).to.equal(200);
+  });
+  test("Response body is valid", function () {
+    const data = res.getBody();
+    expect(data).to.contains("aasx");
+  })
+}