Fix message only appear in loaded model (#168)

Author: michelu89

core/apps/ame/src/app/startup.service.ts

@@ -43,7 +43,7 @@ export class StartupService {
     private fileHandlingService: FileHandlingService,
     private mxGraphService: MxGraphService,
     private translate: LanguageTranslationService,
-    private ngZone: NgZone
+    private ngZone: NgZone,
   ) {}
 
   listenForLoading() {
@@ -62,8 +62,8 @@ export class StartupService {
         }),
         take(1),
         switchMap(({isFirstWindow, model}) =>
-          (isFirstWindow ? this.migratorService.startMigrating() : of(null)).pipe(switchMap(() => this.loadModel(model)))
-        )
+          (isFirstWindow ? this.migratorService.startMigrating() : of(null)).pipe(switchMap(() => this.loadModel(model))),
+        ),
       )
       .subscribe(() => {
         this.sidebarService.workspace.refresh();
@@ -77,7 +77,7 @@ export class StartupService {
       this.loadingScreenService.open({
         title: this.translate.language.LOADING_SCREEN_DIALOG.MODEL_LOADING,
         content: this.translate.language.LOADING_SCREEN_DIALOG.MODEL_LOADING_WAIT,
-      })
+      }),
     );
     return this.electronSignalsService.call('requestWindowData').pipe(
       tap(data => (options = data.options)),
@@ -90,13 +90,13 @@ export class StartupService {
                 fromWorkspace: options?.fromWorkspace,
                 editElementUrn: options?.editElement,
               })
-            : of(this.fileHandlingService.createEmptyModel())
-        )
+            : of(this.fileHandlingService.createEmptyModel()),
+        ),
       ),
       tap(() => {
         this.modelSaveTracker.updateSavedModel();
         this.loadingScreenService.close();
-      })
+      }),
     );
   }
 }

core/libs/instantiator/src/lib/meta-model-element-instantiator.ts

@@ -512,14 +512,16 @@ export class MetaModelElementInstantiator {
     if (this.rdfModel.getLocale(quad)) {
       metaModelElement.addDescription(this.rdfModel.getLocale(quad), quad.object.value);
     } else {
-      this.notificationsService.error({
-        title: this.translate.language.NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_TITLE,
-        message: this.translate.translateService.instant('NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_DESC_MESSAGE', {
-          subject: quad.subject.value,
-          fileName: metaModelElement?.fileName,
-        }),
-        timeout: 5000,
-      });
+      if (this.rdfModel.loadedRdfModel) {
+        this.notificationsService.error({
+          title: this.translate.language.NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_TITLE,
+          message: this.translate.translateService.instant('NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_DESC_MESSAGE', {
+            subject: quad.subject.value,
+            fileName: metaModelElement?.fileName,
+          }),
+          timeout: 5000,
+        });
+      }
       metaModelElement.addDescription('en', quad.object.value);
     }
   }
@@ -528,14 +530,17 @@ export class MetaModelElementInstantiator {
     if (this.rdfModel.getLocale(quad)) {
       metaModelElement.addPreferredName(this.rdfModel.getLocale(quad), quad.object.value);
     } else {
-      this.notificationsService.error({
-        title: this.translate.language.NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_TITLE,
-        message: this.translate.translateService.instant('NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_PREF_MESSAGE', {
-          subject: quad.subject.value,
-          fileName: metaModelElement?.fileName,
-        }),
-        timeout: 5000,
-      });
+      if (this.rdfModel.loadedRdfModel) {
+        this.notificationsService.error({
+          title: this.translate.language.NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_TITLE,
+          message: this.translate.translateService.instant('NOTIFICATION_SERVICE.FALLBACK_TO_DEFAULT_LANGUAGE_PREF_MESSAGE', {
+            subject: quad.subject.value,
+            fileName: metaModelElement?.fileName,
+          }),
+          timeout: 5000,
+        });
+      }
+
       metaModelElement.addPreferredName('en', quad.object.value);
     }
   }

core/libs/rdf/src/lib/services/rdf.service.ts

@@ -91,7 +91,7 @@ export class RdfService {
   }
 
   loadModel(rdf: string, namespaceFileName?: string): Observable<RdfModel> {
-    const rdfModel = new RdfModel();
+    const rdfModel = new RdfModel(true);
     const parser = new Parser();
     const store: Store = new Store();
     const subject = new Subject<RdfModel>();

core/libs/rdf/src/lib/utils/rdf-model.ts

@@ -33,6 +33,7 @@ export class RdfModel {
   private _absoluteAspectModelFileName: string = null;
   private _metaModelVersion: string;
   private _defaultAspectModelAlias = '';
+  private _loadedRdfModel: boolean;
 
   public samm: Samm;
   public sammC: SammC;
@@ -44,6 +45,10 @@ export class RdfModel {
   public loadedFromWorkspace = false;
   public aspect: Quad_Subject;
 
+  get loadedRdfModel(): boolean {
+    return this._loadedRdfModel;
+  }
+
   get store(): Store {
     return this._store;
   }
@@ -119,6 +124,10 @@ export class RdfModel {
     );
   }
 
+  constructor(loadedRdfModel = false) {
+    this._loadedRdfModel = loadedRdfModel;
+  }
+
   public initRdfModel(store: Store, prefixes: Prefixes, mode: 'empty' | 'loaded' = 'loaded'): RdfModel {
     this._store = store;
     this._prefixes = prefixes;