Fix and improve some problems (#114)

* Resolved the issue with adding references.
* The migration button now refreshes automatically after migration in a single window.
* Ensured that the Aspect Model only opens in one window to enhance user experience.
* Updated the documentation to reflect current known issues.
* Adjusted the workspace view so that the close button no longer overlaps with other elements.

Author: michelu89

.gitignore

@@ -21,6 +21,7 @@ speed-measure-plugin.json
 *.launch
 .settings/
 *.sublime-workspace
+.log
 
 # IDE - VSCode
 .vscode

core/.browserslistrc

@@ -19,4 +19,3 @@ not IE 11 # Angular supports IE 11 only as an opt-in. To opt-in, remove the 'not
 
 not ios_saf 15.2-15.3
 not safari 15.2-15.3
-not op_mini all

core/.eslintrc.json

@@ -42,7 +42,11 @@
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
-      "rules": {}
+      "rules": {
+        "no-var": "error",
+        "no-unused-vars": "error",
+        "no-undef": "error"
+      }
     }
   ]
 }

core/.husky/pre-commit

@@ -1,5 +1,4 @@
 #!/usr/bin/env sh
-
 . "$(dirname -- "$0")/_/husky.sh"
 
 cd core

core/apps/ame-e2e/src/integration/drag-and-drop/different-namespace/external-characteristic-reference.spec.ts

@@ -13,6 +13,7 @@
 
 /// <reference types="Cypress" />
 
+import {cyHelp} from '../../../support/helpers';
 import {
   SELECTOR_ecCharacteristic,
   SELECTOR_fileMenuFindElements,
@@ -42,6 +43,7 @@ describe('Test drag and drop ext characteristic', () => {
     cy.visitDefault().then(() =>
       cy
         .startModelling()
+        .then(() => cyHelp.checkAspectDefaultExists())
         .then(() => cy.get(SELECTOR_openNamespacesButton).click({force: true}))
         .then(() => cy.get(SELECTOR_namespaceFileMenuButton).click({force: true}))
         .then(() => cy.get(SELECTOR_fileMenuFindElements).click({force: true}).wait(3000))

core/apps/ame-e2e/src/integration/drag-and-drop/different-namespace/external-constraint-reference.spec.ts

@@ -45,6 +45,7 @@ describe('Test drag and drop ext constraint', () => {
     cy.visitDefault().then(() =>
       cy
         .startModelling()
+        .then(() => cyHelp.checkAspectDefaultExists())
         .then(() => cy.get(SELECTOR_openNamespacesButton).click({force: true}))
         .then(() => cy.get(SELECTOR_namespaceFileMenuButton).click({force: true}))
         .then(() => cy.get(SELECTOR_fileMenuFindElements).click({force: true}).wait(3000))

core/apps/ame-e2e/src/integration/drag-and-drop/different-namespace/external-entity-reference.spec.ts

@@ -13,6 +13,7 @@
 
 /// <reference types="Cypress" />
 
+import {cyHelp} from '../../../support/helpers';
 import {
   SELECTOR_ecEntity,
   SELECTOR_fileMenuFindElements,
@@ -42,6 +43,7 @@ describe('Test drag and drop', () => {
     cy.visitDefault().then(() =>
       cy
         .startModelling()
+        .then(() => cyHelp.checkAspectDefaultExists())
         .then(() => cy.get(SELECTOR_openNamespacesButton).click({force: true}))
         .then(() => cy.get(SELECTOR_namespaceFileMenuButton).click({force: true}))
         .then(() => cy.get(SELECTOR_fileMenuFindElements).click({force: true}))

core/apps/ame-e2e/src/integration/drag-and-drop/different-namespace/external-property-reference-with-children.spec.ts

@@ -13,13 +13,14 @@
 
 /// <reference types="Cypress" />
 
+import {cyHelp} from '../../../support/helpers';
 import {
   SELECTOR_ecProperty,
   SELECTOR_fileMenuFindElements,
   SELECTOR_namespaceFileMenuButton,
   SELECTOR_openNamespacesButton,
 } from '../../../support/constants';
-import {checkAspectTree, checkRelationParentChild, connectElements, dragExternalReferenceWithChildren} from '../../../support/utils';
+import {checkAspectTree, connectElements, dragExternalReferenceWithChildren} from '../../../support/utils';
 
 describe('Test drag and drop ext properties', () => {
   it("can add Property with children's from external reference different namespace", () => {
@@ -42,6 +43,7 @@ describe('Test drag and drop ext properties', () => {
     cy.visitDefault().then(() =>
       cy
         .startModelling()
+        .then(() => cyHelp.checkAspectDefaultExists())
         .then(() => cy.get(SELECTOR_openNamespacesButton).click({force: true}))
         .then(() => cy.get(SELECTOR_namespaceFileMenuButton).click({force: true}))
         .then(() => cy.get(SELECTOR_fileMenuFindElements).click({force: true}))

core/apps/ame-e2e/src/integration/drag-and-drop/different-namespace/external-property-reference.spec.ts

@@ -13,13 +13,14 @@
 
 /// <reference types="Cypress" />
 
+import {cyHelp} from '../../../support/helpers';
 import {
   SELECTOR_ecProperty,
   SELECTOR_fileMenuFindElements,
   SELECTOR_namespaceFileMenuButton,
   SELECTOR_openNamespacesButton,
 } from '../../../support/constants';
-import {checkAspectTree, checkRelationParentChild, connectElements, dragExternalReferenceWithChildren} from '../../../support/utils';
+import {checkRelationParentChild, connectElements} from '../../../support/utils';
 
 describe('Test drag and drop ext properties', () => {
   it('can add Property from external reference with different namespace', () => {
@@ -42,6 +43,7 @@ describe('Test drag and drop ext properties', () => {
     cy.visitDefault().then(() =>
       cy
         .startModelling()
+        .then(() => cyHelp.checkAspectDefaultExists())
         .then(() => cy.get(SELECTOR_openNamespacesButton).click({force: true}))
         .then(() => cy.get(SELECTOR_namespaceFileMenuButton).click({force: true}))
         .then(() => cy.get(SELECTOR_fileMenuFindElements).click({force: true}).wait(3000))

core/apps/ame-e2e/src/integration/drag-and-drop/same-namespace/external-characteristic-reference.spec.ts

@@ -13,6 +13,7 @@
 
 /// <reference types="Cypress" />
 
+import {cyHelp} from '../../../support/helpers';
 import {
   SELECTOR_ecCharacteristic,
   SELECTOR_fileMenuFindElements,
@@ -45,6 +46,7 @@ describe('Test drag and drop ext characteristic', () => {
     cy.visitDefault().then(() =>
       cy
         .startModelling()
+        .then(() => cyHelp.checkAspectDefaultExists())
         .then(() => cy.get(SELECTOR_openNamespacesButton).click({force: true}))
         .then(() => cy.get(SELECTOR_namespaceFileMenuButton).click({force: true}))
         .then(() => cy.get(SELECTOR_fileMenuFindElements).click({force: true}).wait(3000))