Skip to content

Commit 65b7cda

Browse files
authored
Hotfix/adjust icon for electron (#158)
* Add icons into electron version
1 parent 8009bbf commit 65b7cda

File tree

3 files changed

+59
-9
lines changed

3 files changed

+59
-9
lines changed

core/electron-libs/app-menu.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@ const {
4848
SIGNAL_ZOOM_OUT,
4949
SIGNAL_LOAD_FROM_TEXT,
5050
} = require('./events');
51-
const {icons} = require('./consts');
51+
const {icons, models, inDevMode} = require('./consts');
5252
const {isMac} = require('./os-checker');
53+
const path = require('path');
5354

5455
const readFile = promisify(fs.readFile);
5556

@@ -115,19 +116,21 @@ const fileSubmenu = [
115116
id: 'LOAD_DEFAULT_EXAMPLE',
116117
label: 'SimpleAspect.ttl',
117118
icon: getIcon(icons.LOAD_DEFAULT_EXAMPLE.enabled),
118-
click: (menuItem, browserWindow, _) =>
119-
getFileInfo('./apps/ame/src/assets/aspect-models/org.eclipse.examples/1.0.0/SimpleAspect.ttl')
119+
click: (menuItem, browserWindow, _) => {
120+
return getFileInfo(path.join(models, 'SimpleAspect.ttl'))
120121
.then(fileInfo => browserWindow.webContents.send(SIGNAL_LOAD_SPECIFIC_FILE, fileInfo))
121-
.catch(error => console.error(error)),
122+
.catch(error => console.error(error));
123+
},
122124
},
123125
{
124126
id: 'LOAD_MOVEMENT_EXAMPLE',
125127
label: 'Movement.ttl',
126128
icon: getIcon(icons.LOAD_MOVEMENT_EXAMPLE.enabled),
127-
click: (menuItem, browserWindow, _) =>
128-
getFileInfo('./apps/ame/src/assets/aspect-models/org.eclipse.examples/1.0.0/Movement.ttl')
129+
click: (menuItem, browserWindow, _) => {
130+
return getFileInfo(path.join(models, 'Movement.ttl'))
129131
.then(fileInfo => browserWindow.webContents.send(SIGNAL_LOAD_SPECIFIC_FILE, fileInfo))
130-
.catch(error => console.error(error)),
132+
.catch(error => console.error(error));
133+
},
131134
},
132135
],
133136
},

core/electron-libs/consts.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,16 @@ function inProdMode() {
2121
return !inDevMode();
2222
}
2323

24-
const iconsPath = inDevMode() ? path.join('.', 'apps', 'ame', 'src', 'assets', 'img', 'png', 'app-menu') : path.join();
24+
const iconsPath = inDevMode()
25+
? path.join('.', 'apps', 'ame', 'src', 'assets', 'img', 'png', 'app-menu')
26+
: path.join(__dirname, '..', '..', '..', 'app-menu');
27+
2528
const disabledIconsPath = `${iconsPath}${path.sep}disabled`;
2629
const enabledIconsPath = `${iconsPath}${path.sep}enabled`;
2730

28-
const modelsPath = inDevMode() ? path.join('.', 'apps', 'ame', 'src', 'assets', 'aspect-models') : path.join();
31+
const modelsPath = inDevMode()
32+
? path.join('.', 'apps', 'ame', 'src', 'assets', 'aspect-models', 'org.eclipse.examples', '1.0.0')
33+
: path.join(__dirname, '..', '..', '..', 'default-models');
2934

3035
module.exports.paths = {
3136
icons: {

core/package.json

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,20 @@
2323
"filter": [
2424
"**/*"
2525
]
26+
},
27+
{
28+
"from": "./apps/ame/src/assets/aspect-models/org.eclipse.examples/1.0.0/",
29+
"to": "default-models/",
30+
"filter": [
31+
"**/*"
32+
]
33+
},
34+
{
35+
"from": "./apps/ame/src/assets/img/png/app-menu/",
36+
"to": "app-menu/",
37+
"filter": [
38+
"**/*"
39+
]
2640
}
2741
]
2842
},
@@ -41,6 +55,20 @@
4155
"filter": [
4256
"**/*"
4357
]
58+
},
59+
{
60+
"from": "./apps/ame/src/assets/aspect-models/org.eclipse.examples/1.0.0/",
61+
"to": "default-models/",
62+
"filter": [
63+
"**/*"
64+
]
65+
},
66+
{
67+
"from": "./apps/ame/src/assets/img/png/app-menu/",
68+
"to": "app-menu/",
69+
"filter": [
70+
"**/*"
71+
]
4472
}
4573
]
4674
},
@@ -59,6 +87,20 @@
5987
"filter": [
6088
"**/*"
6189
]
90+
},
91+
{
92+
"from": "./apps/ame/src/assets/aspect-models/org.eclipse.examples/1.0.0/",
93+
"to": "default-models/",
94+
"filter": [
95+
"**/*"
96+
]
97+
},
98+
{
99+
"from": "./apps/ame/src/assets/img/png/app-menu/",
100+
"to": "app-menu/",
101+
"filter": [
102+
"**/*"
103+
]
62104
}
63105
]
64106
},

0 commit comments

Comments
 (0)