Skip to content

Commit 001b592

Browse files
authored
Add data-test ids for e2e tests (#51)
* add data-test ids * fix code review comments * fix code review comments
1 parent ea9df73 commit 001b592

16 files changed

+32
-14
lines changed

src/ng-generate/components/form/generators/components/fields/boolean/files/__name@dasherize__.component.html.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
class="form-field"
33
[formControl]="formControl"
44
(ngModelChange)="value = $event"
5+
data-test="<%= options.fieldConfig.name %>-checkbox"
56
><%= options.fieldConfig.name %></mat-checkbox>

src/ng-generate/components/form/generators/components/fields/complex/files/__name@dasherize__.component.html.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<legend><%= options.fieldConfig.name %></legend>
44
<section class="form-fields">
55
<% for (let childConfig of options.fieldConfig.children) {
6-
%><<%= childConfig.selector %> formControlName="<%= childConfig.name %>"></<%= childConfig.selector %>>
6+
%><<%= childConfig.selector %> formControlName="<%= childConfig.name %>" data-test="<%= childConfig.name %>"></<%= childConfig.selector %>>
77
<% } %>
88
</section>
99
</fieldset>

src/ng-generate/components/form/generators/components/fields/date/files/__name@dasherize__.component.html.template

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<mat-form-field class="form-field">
22
<mat-label><%= options.fieldConfig.name %></mat-label>
3-
<input matInput [matDatepicker]="<%= options.fieldConfig.name %>picker" [formControl]="formControl" (ngModelChange)="value = $event" />
3+
<input matInput [matDatepicker]="<%= options.fieldConfig.name %>picker" [formControl]="formControl" (ngModelChange)="value = $event"
4+
data-test="<%= options.fieldConfig.name %>-date" />
45
<mat-datepicker-toggle matSuffix [for]="<%= options.fieldConfig.name %>picker"></mat-datepicker-toggle>
56
<mat-datepicker #<%= options.fieldConfig.name %>picker [color]="color"></mat-datepicker>
67

src/ng-generate/components/form/generators/components/fields/datePartial/files/__name@dasherize__.component.html.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
type="text"
55
matInput
66
placeholder="<%= options.fieldConfig.placeholder %>"
7+
data-test="<%= options.fieldConfig.name %>"
78
[formControl]="formControl"
89
(ngModelChange)="value = $event"
910
/>

src/ng-generate/components/form/generators/components/fields/dateTime/files/__name@dasherize__.component.html.template

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
<mat-form-field class="form-field">
22
<mat-label><%= options.fieldConfig.name %></mat-label>
3-
<input matInput [ngxMatDatetimePicker]="<%= options.fieldConfig.name %>picker" [formControl]="formControl" (ngModelChange)="value = $event" />
3+
<input matInput [ngxMatDatetimePicker]="<%= options.fieldConfig.name %>picker" [formControl]="formControl" (ngModelChange)="value = $event"
4+
data-test="<%= options.fieldConfig.name %>-picker"
5+
/>
46
<ngx-mat-datepicker-toggle matSuffix [for]="<%= options.fieldConfig.name %>picker"></ngx-mat-datepicker-toggle>
57
<ngx-mat-datetime-picker #<%= options.fieldConfig.name %>picker [color]="color"></ngx-mat-datetime-picker>
68

src/ng-generate/components/form/generators/components/fields/default/files/__name@dasherize__.component.html.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<input
44
type="text"
55
matInput
6+
data-test="<%= options.fieldConfig.name %>"
67
placeholder="<%= options.fieldConfig.exampleValue %>"
78
[formControl]="formControl"
89
(ngModelChange)="value = $event"

src/ng-generate/components/form/generators/components/fields/duration/files/__name@dasherize__.component.html.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
type="text"
55
matInput
66
placeholder="<%= options.fieldConfig.placeholder %>"
7+
data-test="<%= options.fieldConfig.name %>-duration"
78
[formControl]="formControl"
89
(ngModelChange)="value = $event"
910
/>

src/ng-generate/components/form/generators/components/fields/either/files/__name@dasherize__.component.html.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<form [formGroup]="formGroup">
2-
<fieldset class="form-group">
2+
<fieldset class="form-group" data-test="<%= options.fieldConfig.name %>-either">
33
<legend><%= options.fieldConfig.name %></legend>
44
<section class="form-fields">
55
<% for (let childConfig of options.fieldConfig.children) {

src/ng-generate/components/form/generators/components/fields/enumeration/files/__name@dasherize__.component.html.template

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
<mat-form-field appearance="fill" class="form-field">
22
<mat-label><%= options.fieldConfig.name %></mat-label>
3-
<mat-select [formControl]="formControl" (ngModelChange)="value = $event">
3+
<mat-select [formControl]="formControl" (ngModelChange)="value = $event"
4+
data-test="<%= options.fieldConfig.name %>-select"
5+
>
46
<% if (options.fieldConfig.values) { %>
57
<% for (let value of options.fieldConfig.values) { %>
6-
<mat-option value="<%= value %>">
8+
<mat-option value="<%= value %>"
9+
data-test="<%= value %>-select-option"
10+
>
711
<%= value %>
812
</mat-option>
913
<% } %>

src/ng-generate/components/form/generators/components/fields/list/files/__name@dasherize__.component.html.template

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<fieldset>
22
<legend><%= options.fieldConfig.name %></legend>
33
<section class="table-actions" [class.disabled]="formArray.disabled">
4-
<button mat-flat-button (click)="onAdd()">Add</button>
5-
<button mat-flat-button (click)="onEdit(selection)" [disabled]="!isSelection">Edit</button>
6-
<button mat-flat-button (click)="onDelete(selection)" [disabled]="!isSelection">Delete</button>
4+
<button mat-flat-button (click)="onAdd()" data-test="<%= options.fieldConfig.name %>-btn-add">Add</button>
5+
<button mat-flat-button (click)="onEdit(selection)" [disabled]="!isSelection" data-test="<%= options.fieldConfig.name %>-btn-edit">Edit</button>
6+
<button mat-flat-button (click)="onDelete(selection)" [disabled]="!isSelection" data-test="<%= options.fieldConfig.name %>-btn-delete">Delete</button>
77
</section>
88

99
<ng-container *ngIf="dataSource.data.length; else empty">

0 commit comments

Comments
 (0)