Fixed PR comments

Author: Hanna-Shalamitskaya-EPAM

.gitignore

@@ -70,3 +70,4 @@ dmypy.json
 # SAMM
 core/esmf-aspect-meta-model-python/esmf_aspect_meta_model_python/samm_aspect_meta_model/samm/
 /core/esmf-aspect-meta-model-python/samm-cli/
+/core/esmf-aspect-meta-model-python/tests/integration/java_models/resources/

core/esmf-aspect-meta-model-python/README.md

@@ -71,10 +71,10 @@ poetry run download-samm-branch
 ```
 Link to all branches: [SAMM Releases](https://github.com/eclipse-esmf/esmf-semantic-aspect-meta-model/branches)
 
-## SAMMGraph usage
+## SAMM Aspect Model Graph usage
 
-SAMMGraph is a class that allows you to load and interact with the Semantic Data Aspect Meta Model graph. 
-Below is an example of how to use SAMMGraph in your Python code:
+SAMM Aspect Model Graph is a class that allows you to load and interact with the Semantic Data Aspect Meta Model graph. 
+Below is an example of how to use SAMM Aspect Model Graph in your Python code:
 ```python
 from esmf_aspect_meta_model_python import SAMMGraph
 

core/esmf-aspect-meta-model-python/esmf_aspect_meta_model_python/impl/data_types/default_abstract_entity.py

@@ -36,4 +36,10 @@ def __init__(
     @property
     def extending_elements(self) -> List[ComplexType]:
         """Extending elements."""
-        return [DefaultComplexType._instances[element_subject] for element_subject in self.__extending_elements]
+        extending_elements = []
+        for element_subject in self.__extending_elements:
+            element = DefaultComplexType._instances.get(element_subject)
+            if element:
+                extending_elements.append(element)
+
+        return extending_elements

core/esmf-aspect-meta-model-python/esmf_aspect_meta_model_python/loader/instantiator/property_instantiator.py

@@ -82,7 +82,7 @@ def _create_property_blank_node(self, element_node: BNode) -> Property:
             predicate=self._samm.get_urn(SAMM.property),
         )
         if not property_node:
-            raise ValueError(f"Could not found property for the node {element_node}")
+            raise ValueError(f"Could not find property for the node {element_node}")
 
         return DefaultBlankProperty(
             base_element_node=element_node,

core/esmf-aspect-meta-model-python/esmf_aspect_meta_model_python/vocabulary/constants.py

@@ -97,8 +97,9 @@ class CharacteristicElements:
 
 
 class SAMMEElements:
-    TimeSeriesEntity = "TimeSeriesEntity"
+    FileResource = "FileResource"
     Point3d = "Point3d"
+    TimeSeriesEntity = "TimeSeriesEntity"
 
 
 class MetaModelElementAttributes:

core/esmf-aspect-meta-model-python/tests/integration/java_models/test_loading_aspects.py

@@ -156,6 +156,6 @@ def run_model_elements_load_test():
             writer.writerow(row)
 
 
-if __name__ == "__main__":
+def test_loading_aspects():
     run_aspect_load_test()
     run_model_elements_load_test()

core/esmf-aspect-meta-model-python/tests/unit/loader/instantiators/test_property_instantiator.py

@@ -174,7 +174,7 @@ def test_create_property_blank_node_raise_exception(self):
         with pytest.raises(ValueError) as error:
             instantiator_cls._create_property_blank_node(element_node_mock)
 
-        assert str(error.value) == "Could not found property for the node element_node"
+        assert str(error.value) == "Could not find property for the node element_node"
         samm_mock.get_urn.assert_called_once_with(SAMM.property)
         graph_mock.value.assert_called_once_with(subject=element_node_mock, predicate="urn")