Skip to content

Commit 3128db8

Browse files
committed
Fix failed unit tests.
1 parent e0ba694 commit 3128db8

File tree

6 files changed

+36
-18
lines changed

6 files changed

+36
-18
lines changed

core/esmf-aspect-meta-model-java/src/main/java/org/eclipse/esmf/metamodel/impl/DefaultAbstractEntity.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,29 @@
1616
import java.util.List;
1717
import java.util.Optional;
1818

19+
import org.eclipse.esmf.aspectmodel.urn.AspectModelUrn;
1920
import org.eclipse.esmf.metamodel.AbstractEntity;
2021
import org.eclipse.esmf.metamodel.ComplexType;
2122
import org.eclipse.esmf.metamodel.Property;
2223
import org.eclipse.esmf.metamodel.loader.MetaModelBaseAttributes;
24+
import org.eclipse.esmf.metamodel.loader.ModelElementFactory;
2325
import org.eclipse.esmf.metamodel.visitor.AspectVisitor;
2426

2527
public class DefaultAbstractEntity extends DefaultComplexType implements AbstractEntity {
2628
public static DefaultAbstractEntity createDefaultAbstractEntity(
2729
final MetaModelBaseAttributes metaModelBaseAttributes,
2830
final List<? extends Property> properties,
2931
final Optional<ComplexType> _extends,
30-
final List<ComplexType> extendingElements ) {
31-
return new DefaultAbstractEntity( metaModelBaseAttributes, properties, _extends, extendingElements );
32+
final List<AspectModelUrn> extendingElements ) {
33+
return new DefaultAbstractEntity( metaModelBaseAttributes, properties, _extends, extendingElements, null );
3234
}
3335

3436
public DefaultAbstractEntity( final MetaModelBaseAttributes metaModelBaseAttributes,
3537
final List<? extends Property> properties,
3638
final Optional<ComplexType> _extends,
37-
final List<ComplexType> extendingElements ) {
38-
super( metaModelBaseAttributes, properties, _extends, extendingElements );
39+
final List<AspectModelUrn> extendingElements,
40+
final ModelElementFactory loadedElements ) {
41+
super( metaModelBaseAttributes, properties, _extends, extendingElements, loadedElements );
3942
}
4043

4144
/**

core/esmf-aspect-meta-model-java/src/main/java/org/eclipse/esmf/metamodel/impl/DefaultComplexType.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,30 @@
1717
import java.util.List;
1818
import java.util.Optional;
1919

20+
import org.eclipse.esmf.aspectmodel.urn.AspectModelUrn;
2021
import org.eclipse.esmf.metamodel.ComplexType;
2122
import org.eclipse.esmf.metamodel.Property;
2223
import org.eclipse.esmf.metamodel.loader.MetaModelBaseAttributes;
24+
import org.eclipse.esmf.metamodel.loader.ModelElementFactory;
2325
import org.eclipse.esmf.metamodel.visitor.AspectVisitor;
2426

2527
public class DefaultComplexType extends ModelElementImpl implements ComplexType {
2628
private final List<Property> properties;
2729
private final Optional<ComplexType> _extends;
28-
private final List<ComplexType> extendingElements;
30+
private final List<AspectModelUrn> extendingElements;
31+
private final ModelElementFactory loadedElements;
2932

3033
protected DefaultComplexType(
3134
final MetaModelBaseAttributes metaModelBaseAttributes,
3235
final List<? extends Property> properties,
3336
final Optional<ComplexType> _extends,
34-
final List<ComplexType> extendingElements ) {
37+
final List<AspectModelUrn> extendingElements,
38+
final ModelElementFactory loadedElements ) {
3539
super( metaModelBaseAttributes );
3640
this.properties = new ArrayList<>( properties );
3741
this._extends = _extends;
3842
this.extendingElements = extendingElements;
43+
this.loadedElements = loadedElements;
3944
}
4045

4146
/**
@@ -58,7 +63,10 @@ public Optional<ComplexType> getExtends() {
5863
*/
5964
@Override
6065
public List<ComplexType> getExtendingElements() {
61-
return extendingElements;
66+
if ( loadedElements == null ) {
67+
throw new RuntimeException( "No inheritance information is available." );
68+
}
69+
return loadedElements.getExtendingElements( extendingElements );
6270
}
6371

6472
@Override

core/esmf-aspect-meta-model-java/src/main/java/org/eclipse/esmf/metamodel/impl/DefaultEntity.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,31 +16,34 @@
1616
import java.util.List;
1717
import java.util.Optional;
1818

19+
import org.eclipse.esmf.aspectmodel.urn.AspectModelUrn;
1920
import org.eclipse.esmf.metamodel.ComplexType;
2021
import org.eclipse.esmf.metamodel.Entity;
2122
import org.eclipse.esmf.metamodel.Property;
2223
import org.eclipse.esmf.metamodel.loader.MetaModelBaseAttributes;
24+
import org.eclipse.esmf.metamodel.loader.ModelElementFactory;
2325
import org.eclipse.esmf.metamodel.visitor.AspectVisitor;
2426

2527
public class DefaultEntity extends DefaultComplexType implements Entity {
2628

2729
public static DefaultEntity createDefaultEntity( final MetaModelBaseAttributes metaModelBaseAttributes,
2830
final List<? extends Property> properties, final Optional<ComplexType> _extends ) {
29-
return new DefaultEntity( metaModelBaseAttributes, properties, _extends, Collections.emptyList() );
31+
return new DefaultEntity( metaModelBaseAttributes, properties, _extends, Collections.emptyList(), null );
3032
}
3133

3234
public DefaultEntity(
3335
final MetaModelBaseAttributes metaModelBaseAttributes,
3436
final List<? extends Property> properties ) {
35-
this( metaModelBaseAttributes, properties, Optional.empty(), Collections.emptyList() );
37+
this( metaModelBaseAttributes, properties, Optional.empty(), Collections.emptyList(), null );
3638
}
3739

3840
public DefaultEntity(
3941
final MetaModelBaseAttributes metaModelBaseAttributes,
4042
final List<? extends Property> properties,
4143
final Optional<ComplexType> _extends,
42-
final List<ComplexType> extendingElements ) {
43-
super( metaModelBaseAttributes, properties, _extends, extendingElements );
44+
final List<AspectModelUrn> extendingElements,
45+
final ModelElementFactory loadedElements ) {
46+
super( metaModelBaseAttributes, properties, _extends, extendingElements, loadedElements );
4447
}
4548

4649
/**

core/esmf-aspect-meta-model-java/src/main/java/org/eclipse/esmf/metamodel/loader/instantiator/AbstractEntityInstantiator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import java.util.List;
1717
import java.util.Optional;
1818

19+
import org.eclipse.esmf.aspectmodel.urn.AspectModelUrn;
1920
import org.eclipse.esmf.metamodel.AbstractEntity;
2021
import org.eclipse.esmf.metamodel.ComplexType;
2122
import org.eclipse.esmf.metamodel.Property;
@@ -34,11 +35,12 @@ protected AbstractEntity createDefaultEntity(
3435
final MetaModelBaseAttributes metaModelBaseAttributes,
3536
final List<Property> properties,
3637
final Optional<ComplexType> extendedEntity,
37-
final List<ComplexType> extendingComplexTypes ) {
38+
final List<AspectModelUrn> extendingComplexTypes ) {
3839
return new DefaultAbstractEntity(
3940
metaModelBaseAttributes,
4041
properties,
4142
extendedEntity,
42-
extendingComplexTypes );
43+
extendingComplexTypes,
44+
modelElementFactory );
4345
}
4446
}

core/esmf-aspect-meta-model-java/src/main/java/org/eclipse/esmf/metamodel/loader/instantiator/ComplexTypeInstantiator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ public T apply( final Resource resource ) {
7070

7171
final Optional<ComplexType> extendedEntity = getExtendedEntity( resource );
7272

73-
final List<ComplexType> extending = new ArrayList<>();
73+
final List<AspectModelUrn> extending = new ArrayList<>();
7474

7575
final T entity = createDefaultEntity( metaModelBaseAttributes, properties, extendedEntity, extending );
7676

7777
creatingElements.put( resource, entity );
7878

79-
extending.addAll( modelElementFactory.getExtendingElements( getExtending( resource ) ) );
79+
extending.addAll( getExtending( resource ) );
8080

8181
return entity;
8282
}
@@ -111,5 +111,5 @@ protected abstract T createDefaultEntity(
111111
MetaModelBaseAttributes metaModelBaseAttributes,
112112
List<Property> properties,
113113
Optional<ComplexType> extendedEntity,
114-
List<ComplexType> extendingComplexTypes );
114+
List<AspectModelUrn> extendingComplexTypes );
115115
}

core/esmf-aspect-meta-model-java/src/main/java/org/eclipse/esmf/metamodel/loader/instantiator/EntityInstantiator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import java.util.List;
1717
import java.util.Optional;
1818

19+
import org.eclipse.esmf.aspectmodel.urn.AspectModelUrn;
1920
import org.eclipse.esmf.metamodel.ComplexType;
2021
import org.eclipse.esmf.metamodel.Entity;
2122
import org.eclipse.esmf.metamodel.Property;
@@ -33,11 +34,12 @@ protected Entity createDefaultEntity(
3334
final MetaModelBaseAttributes metaModelBaseAttributes,
3435
final List<Property> properties,
3536
final Optional<ComplexType> extendedEntity,
36-
final List<ComplexType> extendingComplexTypes ) {
37+
final List<AspectModelUrn> extendingComplexTypes ) {
3738
return new DefaultEntity(
3839
metaModelBaseAttributes,
3940
properties,
4041
extendedEntity,
41-
extendingComplexTypes );
42+
extendingComplexTypes,
43+
modelElementFactory );
4244
}
4345
}

0 commit comments

Comments
 (0)