Skip to content

Commit 6290466

Browse files
committed
Add missing entity URLs in meta model resolver
1 parent d2dce4d commit 6290466

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

core/sds-aspect-meta-model-resolver/src/main/java/io/openmanufacturing/sds/aspectmodel/resolver/services/ClassPathMetaModelUrnResolver.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ public Set<URL> apply( final KnownVersion metaModelVersion ) {
3535
MetaModelUrls.url( "characteristic", metaModelVersion, "characteristic-definitions.ttl" ),
3636
MetaModelUrls.url( "characteristic", metaModelVersion, "characteristic-instances.ttl" ),
3737
MetaModelUrls.url( "entity", metaModelVersion, "TimeSeriesEntity.ttl" ),
38+
MetaModelUrls.url( "entity", metaModelVersion, "FileResource.ttl" ),
39+
MetaModelUrls.url( "entity", metaModelVersion, "Point3d.ttl" ),
3840
MetaModelUrls.url( "unit", metaModelVersion, "units.ttl" ),
3941
Optional.<URL> empty()
4042
).filter( Optional::isPresent ).map( Optional::get ).collect( Collectors.toSet() );

core/sds-aspect-meta-model-resolver/src/test/java/io/openmanufacturing/sds/aspectmodel/resolver/services/ClassPathMetaModelUrnResolverTest.java

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) 2021 Robert Bosch Manufacturing Solutions GmbH
33
*
44
* See the AUTHORS file(s) distributed with this work for additional
5-
* information regarding authorship.
5+
* information regarding authorship.
66
*
77
* This Source Code Form is subject to the terms of the Mozilla Public
88
* License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -18,16 +18,27 @@
1818
import java.net.URL;
1919
import java.util.Optional;
2020

21-
import io.openmanufacturing.sds.aspectmetamodel.KnownVersion;
22-
2321
import org.junit.jupiter.api.Test;
22+
import org.junit.jupiter.params.ParameterizedTest;
23+
import org.junit.jupiter.params.provider.MethodSource;
24+
25+
import io.openmanufacturing.sds.aspectmetamodel.KnownVersion;
26+
import io.openmanufacturing.sds.test.MetaModelVersions;
2427

25-
public class ClassPathMetaModelUrnResolverTest {
28+
public class ClassPathMetaModelUrnResolverTest extends MetaModelVersions {
2629
@Test
2730
public void testUrlConstruction() {
2831
for ( final KnownVersion version : KnownVersion.getVersions() ) {
2932
final Optional<URL> url = MetaModelUrls.url( "meta-model", version, "aspect-meta-model-definitions.ttl" );
3033
assertThat( url ).isNotEmpty();
3134
}
3235
}
36+
37+
@ParameterizedTest
38+
@MethodSource( value = "allVersions" )
39+
public void testContainsEntityDefinitions( final KnownVersion metaModelVersion ) {
40+
assertThat( MetaModelUrls.url( "entity", metaModelVersion, "Point3d.ttl" ) ).isNotEmpty();
41+
assertThat( MetaModelUrls.url( "entity", metaModelVersion, "FileResource.ttl" ) ).isNotEmpty();
42+
assertThat( MetaModelUrls.url( "entity", metaModelVersion, "TimeSeriesEntity.ttl" ) ).isNotEmpty();
43+
}
3344
}

0 commit comments

Comments
 (0)