Skip to content

Commit 679ac81

Browse files
committed
Remove usage of deprecated internal APIs
1 parent deff172 commit 679ac81

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

tools/samm-cli/src/main/java/org/eclipse/esmf/AbstractCommand.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.nio.file.Path;
2323
import java.nio.file.Paths;
2424
import java.util.ArrayList;
25-
import java.util.HashSet;
2625
import java.util.List;
2726
import java.util.Locale;
2827
import java.util.Optional;
@@ -36,6 +35,8 @@
3635
import org.eclipse.esmf.aspectmodel.edit.ChangeReportFormatter;
3736
import org.eclipse.esmf.aspectmodel.generator.LanguageCollector;
3837
import org.eclipse.esmf.aspectmodel.generator.diagram.AspectModelDiagramGenerator;
38+
import org.eclipse.esmf.aspectmodel.generator.diagram.DiagramGenerationConfig;
39+
import org.eclipse.esmf.aspectmodel.generator.diagram.DiagramGenerationConfigBuilder;
3940
import org.eclipse.esmf.aspectmodel.serializer.AspectSerializer;
4041
import org.eclipse.esmf.exception.CommandException;
4142
import org.eclipse.esmf.metamodel.Aspect;
@@ -79,19 +80,21 @@ protected InputHandler getInputHandler( final String input ) {
7980
throw new CommandException( "Can not find file: " + input );
8081
}
8182

82-
protected void generateDiagram( final String input, final AspectModelDiagramGenerator.Format targetFormat,
83+
protected void generateDiagram( final String input, final DiagramGenerationConfig.Format targetFormat,
8384
final String outputFileName, final String languageTag ) throws IOException {
8485
final Aspect aspect = getInputHandler( input ).loadAspect();
85-
final AspectModelDiagramGenerator generator = new AspectModelDiagramGenerator( aspect );
86-
final Set<AspectModelDiagramGenerator.Format> targetFormats = new HashSet<>();
87-
targetFormats.add( targetFormat );
8886
final Set<Locale> languagesUsedInModel = LanguageCollector.collectUsedLanguages( aspect );
8987
if ( !languagesUsedInModel.contains( Locale.forLanguageTag( languageTag ) ) ) {
9088
throw new CommandException( String.format( "The model does not contain the desired language: %s.", languageTag ) );
9189
}
9290
// we intentionally override the name of the generated artifact here to the name explicitly desired by the user (outputFileName),
9391
// as opposed to what the model thinks it should be called (name)
94-
generator.generateDiagrams( targetFormats, Locale.forLanguageTag( languageTag ), name -> getStreamForFile( outputFileName ) );
92+
final DiagramGenerationConfig config = DiagramGenerationConfigBuilder.builder()
93+
.format( targetFormat )
94+
.language( Locale.forLanguageTag( languageTag ) )
95+
.build();
96+
final AspectModelDiagramGenerator generator = new AspectModelDiagramGenerator( aspect, config );
97+
generator.generate( name -> getStreamForFile( outputFileName ) );
9598
}
9699

97100
protected FileOutputStream getStreamForFile( final String artifactPath, final String artifactName, final String baseOutputPath ) {

tools/samm-cli/src/main/java/org/eclipse/esmf/aspect/to/AspectToPngCommand.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.eclipse.esmf.ResolverConfigurationMixin;
2121
import org.eclipse.esmf.aspect.AspectToCommand;
2222
import org.eclipse.esmf.aspectmodel.generator.diagram.AspectModelDiagramGenerator;
23+
import org.eclipse.esmf.aspectmodel.generator.diagram.DiagramGenerationConfig;
2324
import org.eclipse.esmf.exception.CommandException;
2425

2526
import picocli.CommandLine;
@@ -67,7 +68,7 @@ public void run() {
6768
setResolverConfig( resolverConfiguration );
6869

6970
try {
70-
generateDiagram( parentCommand.parentCommand.getInput(), AspectModelDiagramGenerator.Format.PNG, outputFilePath, language );
71+
generateDiagram( parentCommand.parentCommand.getInput(), DiagramGenerationConfig.Format.PNG, outputFilePath, language );
7172
} catch ( final IOException e ) {
7273
throw new CommandException( e );
7374
}

tools/samm-cli/src/main/java/org/eclipse/esmf/aspect/to/AspectToSqlCommand.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ public class AspectToSqlCommand extends AbstractCommand {
5151

5252
@CommandLine.Option(
5353
names = { "--dialect", "-d" },
54-
description = "The SQL dialect to generate for (default: ${DEFAULT-VALUE}" )
54+
description = "The SQL dialect to generate for (default: ${DEFAULT-VALUE})" )
5555
private SqlGenerationConfig.Dialect dialect = SqlGenerationConfig.Dialect.DATABRICKS;
5656

5757
@CommandLine.Option(
5858
names = { "--mapping-strategy", "-s" },
59-
description = "The mapping strategy to use (default: ${DEFAULT-VALUE}" )
59+
description = "The mapping strategy to use (default: ${DEFAULT-VALUE})" )
6060
private SqlGenerationConfig.MappingStrategy strategy = SqlGenerationConfig.MappingStrategy.DENORMALIZED;
6161

6262
@CommandLine.Option(

tools/samm-cli/src/main/java/org/eclipse/esmf/aspect/to/AspectToSvgCommand.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.eclipse.esmf.ResolverConfigurationMixin;
2121
import org.eclipse.esmf.aspect.AspectToCommand;
2222
import org.eclipse.esmf.aspectmodel.generator.diagram.AspectModelDiagramGenerator;
23+
import org.eclipse.esmf.aspectmodel.generator.diagram.DiagramGenerationConfig;
2324
import org.eclipse.esmf.exception.CommandException;
2425

2526
import picocli.CommandLine;
@@ -66,7 +67,7 @@ public void run() {
6667
setResolverConfig( resolverConfiguration );
6768

6869
try {
69-
generateDiagram( parentCommand.parentCommand.getInput(), AspectModelDiagramGenerator.Format.SVG, outputFilePath, language );
70+
generateDiagram( parentCommand.parentCommand.getInput(), DiagramGenerationConfig.Format.SVG, outputFilePath, language );
7071
} catch ( final IOException e ) {
7172
throw new CommandException( e );
7273
}

0 commit comments

Comments
 (0)