Skip to content

Commit 71d2d2a

Browse files
committed
Use new diagram generator API in documentation generation
1 parent 809adf7 commit 71d2d2a

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

core/esmf-aspect-model-document-generators/src/main/java/org/eclipse/esmf/aspectmodel/generator/docu/AspectModelDocumentationGenerator.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
package org.eclipse.esmf.aspectmodel.generator.docu;
1515

16-
import java.io.ByteArrayOutputStream;
1716
import java.io.IOException;
1817
import java.io.InputStream;
1918
import java.io.InputStreamReader;
@@ -34,6 +33,8 @@
3433
import org.eclipse.esmf.aspectmodel.generator.LanguageCollector;
3534
import org.eclipse.esmf.aspectmodel.generator.TemplateEngine;
3635
import org.eclipse.esmf.aspectmodel.generator.diagram.AspectModelDiagramGenerator;
36+
import org.eclipse.esmf.aspectmodel.generator.diagram.DiagramGenerationConfig;
37+
import org.eclipse.esmf.aspectmodel.generator.diagram.DiagramGenerationConfigBuilder;
3738
import org.eclipse.esmf.aspectmodel.visitor.AspectStreamTraversalVisitor;
3839
import org.eclipse.esmf.metamodel.Aspect;
3940
import org.eclipse.esmf.metamodel.Scalar;
@@ -153,10 +154,13 @@ private String getArtifactName( final Aspect aspectModel, final Locale locale )
153154
}
154155

155156
private String insertAspectModelDiagram( final String html, final Locale language ) {
156-
final AspectModelDiagramGenerator diagramGenerator = new AspectModelDiagramGenerator( aspect() );
157-
final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
158-
diagramGenerator.generateDiagram( AspectModelDiagramGenerator.Format.SVG, language, buffer );
159-
final String encodedImage = "data:image/svg+xml;base64," + Base64.getEncoder().encodeToString( buffer.toByteArray() );
157+
final DiagramGenerationConfig config = DiagramGenerationConfigBuilder.builder()
158+
.format( DiagramGenerationConfig.Format.SVG )
159+
.language( language )
160+
.build();
161+
final AspectModelDiagramGenerator diagramGenerator = new AspectModelDiagramGenerator( aspect(), config );
162+
final byte[] diagram = diagramGenerator.getContent();
163+
final String encodedImage = "data:image/svg+xml;base64," + Base64.getEncoder().encodeToString( diagram );
160164
return html.replace( "diagram_svg_placeholder", encodedImage );
161165
}
162166

core/esmf-aspect-model-document-generators/src/test/java/org/eclipse/esmf/aspectmodel/generator/docu/AspectModelDocumentationGeneratorTest.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.io.ByteArrayOutputStream;
2020
import java.io.IOException;
2121
import java.io.PrintStream;
22-
import java.nio.charset.StandardCharsets;
2322

2423
import org.eclipse.esmf.metamodel.Aspect;
2524
import org.eclipse.esmf.test.TestAspect;
@@ -183,10 +182,6 @@ public void testAspectWithConstraintWithSeeAttribute() throws IOException {
183182
private String generateHtmlDocumentation( final TestAspect testAspect ) throws IOException {
184183
final Aspect aspect = TestResources.load( testAspect ).aspect();
185184
final AspectModelDocumentationGenerator aspectModelDocumentationGenerator = new AspectModelDocumentationGenerator( aspect );
186-
187-
try ( final ByteArrayOutputStream result = new ByteArrayOutputStream() ) {
188-
aspectModelDocumentationGenerator.generate();
189-
return result.toString( StandardCharsets.UTF_8 );
190-
}
185+
return aspectModelDocumentationGenerator.getContent();
191186
}
192187
}

0 commit comments

Comments
 (0)