Fix recursive property identification logic to also handle recursive properties, which are not optional

Signed-off-by: Johannes Kristan <[email protected]>

Author: bs-jokri

core/sds-aspect-model-aas-generator/src/main/java/io/openmanufacturing/sds/aspectmodel/aas/AspectModelAASVisitor.java

@@ -229,10 +229,10 @@ private SubmodelElement map( final Property property, final Context context ) {
          recursiveProperty.remove( property );
          if ( property.isOptional() ) {
             LOG.warn( String.format( "Having a recursive Property %s which is optional. Will be excluded from AAS mapping.", property ) );
-            return defaultResultForProperty.get();
          } else {
-            throw new IllegalArgumentException( String.format( "Having a recursive Property: %s which is not optional is not valid.", property ) );
+            LOG.error( String.format( "Having a recursive Property: %s which is not optional is not valid. Check the model. Property will be excluded from AAS mapping.", property ) );
          }
+         return defaultResultForProperty.get();
       }
       recursiveProperty.add( property );