Remove false positive validation test model

With the updated version of the meta model shapes, this is acutally validated
using shapes, so the test model and the test are neither working nor required
any more.

Author: atextor

core/sds-aspect-model-validator/src/test/java/io/openmanufacturing/sds/aspectmodel/validation/services/AspectModelValidatorTest.java

@@ -61,23 +61,6 @@ public void testValidAspect( final KnownVersion metaModelVersion ) {
       assertThat( violations ).isEmpty();
    }
 
-   /**
-    * Test for a model that passes validation via BAMM's SHACL shapes but is actually invalid and can not be loaded using
-    * {@link io.openmanufacturing.sds.metamodel.loader.AspectModelLoader#fromVersionedModel(VersionedModel)}.
-    * This method and the corresponding test model should be removed once
-    * <a href="https://github.com/OpenManufacturingPlatform/sds-bamm-aspect-meta-model/issues/173">BAMM-173</a> has been addressed
-    * @param metaModelVersion the meta model version
-    */
-   @ParameterizedTest
-   @MethodSource( value = "versionsStartingWith2_0_0" )
-   public void testFalsePositiveValidation( final KnownVersion metaModelVersion ) {
-      final TestModel testModel = InvalidTestAspect.ASPECT_WITH_FALSE_POSITIVE_VALIDATION;
-      final Try<VersionedModel> aspectModel = TestResources.getModel( testModel, metaModelVersion );
-      final List<Violation> violations = service.get( metaModelVersion ).validateModel( aspectModel );
-      assertThat( violations ).isNotEmpty();
-      assertThat( violations.get( 0 ) ).isOfAnyClassIn( ProcessingViolation.class );
-   }
-
    @ParameterizedTest
    @EnumSource( value = TestAspect.class, mode = EnumSource.Mode.EXCLUDE, names = {
          "ASPECT_WITH_CONSTRAINTS",

core/sds-test-aspect-models/src/main/java/io/openmanufacturing/sds/test/InvalidTestAspect.java

@@ -19,7 +19,6 @@ public enum InvalidTestAspect implements TestModel {
    ACTUALLY_JSON,
    ASPECT_MISSING_NAME_AND_PROPERTIES,
    ASPECT_MISSING_PROPERTIES,
-   ASPECT_WITH_FALSE_POSITIVE_VALIDATION,
    ASPECT_WITH_INVALID_VERSION,
    ASPECT_WITH_BAMM_NAMESPACE_FOR_CUSTOM_UNIT,
    ASPECT_WITH_RECURSIVE_PROPERTY,