Skip to content

Commit 77ce167

Browse files
committed
Fix code and tests that broke due to merge
1 parent bb5b4a5 commit 77ce167

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

core/sds-aspect-model-validator/src/main/java/io/openmanufacturing/sds/aspectmodel/validation/services/ModelCycleDetector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public List<Violation> validateModel( final VersionedModel versionedModel ) {
8080
cycleDetectionReport.clear();
8181

8282
model = versionedModel.getModel();
83-
final Optional<KnownVersion> metaModelVersion = KnownVersion.fromVersionString( versionedModel.getVersion().toString() );
83+
final Optional<KnownVersion> metaModelVersion = KnownVersion.fromVersionString( versionedModel.getMetaModelVersion().toString() );
8484
bamm = new BAMM( metaModelVersion.get() );
8585
initializeQuery( metaModelVersion.get() );
8686

core/sds-aspect-model-validator/src/test/java/io/openmanufacturing/sds/aspectmodel/validation/services/AspectModelValidatorTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ public void testValidAspect( final KnownVersion metaModelVersion ) {
7676
"ASPECT_WITH_RANGE_CONSTRAINT_WITH_ONLY_MIN_VALUE", // uses bamm-c:OPEN
7777
"ASPECT_WITH_RANGE_CONSTRAINT_WITH_ONLY_UPPER_BOUND", // uses bamm-c:OPEN
7878
"ASPECT_WITH_RANGE_CONSTRAINT_WITH_ONLY_UPPER_BOUND_INCL_BOUND_DEFINITION", // uses bamm-c:OPEN
79-
"MODEL_WITH_CYCLES" // contains cycles
79+
"MODEL_WITH_CYCLES",
80+
"MODEL_WITH_BROKEN_CYCLES"// contains cycles
8081
} )
8182
public void testValidateTestAspectModel( final TestAspect testAspect ) {
8283
final KnownVersion metaModelVersion = KnownVersion.getLatest();
@@ -147,7 +148,7 @@ public void testValidateInvalidModelElement( final KnownVersion metaModelVersion
147148
final BAMM bamm = new BAMM( metaModelVersion );
148149
assertThat( violation.context().element() ).isEqualTo( element );
149150
assertThat( violation.context().property().get() ).isEqualTo( bamm.exampleValue() );
150-
assertThat( violation.bindings().get( "value" ).asResource().getURI() ).isEqualTo( XSD.xint.getURI() );
151+
assertThat( violation.bindings().get( "value" ).asLiteral().getString() ).isEqualTo( XSD.xint.getURI() );
151152
}
152153

153154
@ParameterizedTest

0 commit comments

Comments
 (0)