Execute Sparql constraints on properties even when the sh:path does not return any matches.

Author: RaMisess

core/sds-aspect-model-validator/src/main/java/io/openmanufacturing/sds/aspectmodel/shacl/ShaclValidator.java

@@ -41,6 +41,7 @@
 import io.openmanufacturing.sds.aspectmodel.resolver.services.VersionedModel;
 import io.openmanufacturing.sds.aspectmodel.shacl.constraint.Constraint;
 import io.openmanufacturing.sds.aspectmodel.shacl.constraint.MinCountConstraint;
+import io.openmanufacturing.sds.aspectmodel.shacl.constraint.SparqlConstraint;
 import io.openmanufacturing.sds.aspectmodel.shacl.path.PathNodeRetriever;
 import io.openmanufacturing.sds.aspectmodel.shacl.path.PredicatePath;
 import io.openmanufacturing.sds.aspectmodel.shacl.violation.EvaluationContext;
@@ -178,6 +179,13 @@ public List<Violation> validateShapeForElement( final Resource element, final Sh
                violations.addAll( constraint.apply( assertion.getObject(), context ) );
             }
 
+            // important detail: Sparql constraints must run independent of whether there are any matches via the sh:path property or not
+            // ( the check could be the verification whether the property exists )
+            if ( reachableNodes.isEmpty() && constraint instanceof SparqlConstraint ) {
+               final EvaluationContext context = new EvaluationContext( element, shape, Optional.empty(), List.of(), this );
+               violations.addAll( constraint.apply( null, context ) );
+            }
+
             // MinCount needs to be handled separately: If the property is not used at all on the target node, but a MinCount constraints >= 1
             // exists, a violation must be emitted even though no value for the property exists
             if ( reachableNodes.isEmpty() && constraint instanceof MinCountConstraint && property.path() instanceof PredicatePath predicatePath ) {

core/sds-aspect-model-validator/src/test/java/io/openmanufacturing/sds/aspectmodel/shacl/ShaclValidatorTest.java

@@ -1780,7 +1780,7 @@ void testSparqlTargetWithGenericConstraint() {
    }
 
    @Test
-   void testSparqlTargetWithSparqlConstraint() {
+   void testSparqlTargetWithShapeSparqlConstraint() {
       final Model shapesModel = model( """
             @prefix sh: <http://www.w3.org/ns/shacl#> .
             @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@@ -1845,6 +1845,71 @@ void testSparqlTargetWithSparqlConstraint() {
       assertThat( finding ).isInstanceOf( SparqlConstraintViolation.class );
    }
 
+   @Test
+   void testSparqlTargetWithPropertySparqlConstraint() {
+      final Model shapesModel = model( """
+            @prefix sh: <http://www.w3.org/ns/shacl#> .
+            @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+            @prefix : <http://example.com#> .
+
+            :prefixDeclarations
+               sh:declare [
+                  sh:prefix "" ;
+                  sh:namespace "http://example.com#"^^xsd:anyURI ;
+               ] .
+
+            :MyShape
+               a sh:NodeShape ;
+               sh:target [
+                  a sh:SPARQLTarget ;
+                  sh:prefixes :prefixDeclarations ;
+                  sh:select ""\"
+                     select $this
+                     where {
+                        $this a :TestClass .
+                     }
+                  ""\"
+               ] ;
+               sh:name "Test shape" ;
+               sh:description "Test shape description" ;
+               sh:property [
+                  sh:path :testProperty ;
+                  sh:datatype xsd:string ;
+                  sh:sparql [
+                     a sh:SPARQLConstraint ;
+                     sh:message "Required property 'testProperty' does not exist on {$this}." ;
+                     sh:prefixes :prefixDeclarations ;
+                     sh:select ""\"
+                        select $this ?code
+                        where {
+                          $this a :TestClass .
+                          filter ( not exists { $this :testProperty [] } ) .
+                          bind( "ERR_CUSTOM" as ?code )
+                        }
+                     ""\"
+                  ] ;
+               ] .
+            """ );
+
+      // important detail: ':testProperty' is missing on ':Foo', the SPARQLConstraint must run anyway
+      final Model dataModel = model( """
+            @prefix : <http://example.com#> .
+            @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+            :Foo a :TestClass.              
+
+            :Bar a :TestClass ;
+              :testProperty "secret valid value" .
+            """ );
+
+      final ShaclValidator validator = new ShaclValidator( shapesModel );
+      final Resource element = dataModel.createResource( namespace + "Foo" );
+      final List<Violation> violations = validator.validateElement( element );
+
+      assertThat( violations.size() ).isEqualTo( 1 );
+      final Violation finding = violations.get( 0 );
+      assertThat( finding ).isInstanceOf( SparqlConstraintViolation.class );
+   }
+
    @Test
    void testMultiElementValidation() {
       final Model shapesModel = model( """