Skip to content

Commit d6190bb

Browse files
committed
Fix test and create own all upper check
1 parent d48e83d commit d6190bb

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

core/esmf-aspect-model-java-generator/src/main/java/org/eclipse/esmf/aspectmodel/java/AspectModelJavaUtil.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -344,14 +344,18 @@ public static Class<?> getDataTypeClass( final Type dataType ) {
344344
* Convert a string given as upper or lower camel case into a constant format. For example {@code someVariable} would become
345345
* {@code SOME_VARIABLE}.
346346
*
347-
* @param upperOrLowerCamelString the string to convert
347+
* @param upperOrLowerCamel the string to convert
348348
* @return the string formatted as a constant.
349349
*/
350-
public static String toConstant( final String upperOrLowerCamelString ) {
351-
if ( StringUtils.isAllUpperCase( upperOrLowerCamelString ) ) {
352-
return upperOrLowerCamelString;
350+
public static String toConstant( final String upperOrLowerCamel ) {
351+
if ( isAllUppercaseWithUnderscore( upperOrLowerCamel ) ) {
352+
return upperOrLowerCamel;
353353
}
354-
return TO_CONSTANT.convert( StringUtils.capitalize( upperOrLowerCamelString ) );
354+
return TO_CONSTANT.convert( StringUtils.capitalize( upperOrLowerCamel ) );
355+
}
356+
357+
public static boolean isAllUppercaseWithUnderscore( final String upperOrLowerCamel ) {
358+
return upperOrLowerCamel != null && upperOrLowerCamel.matches( "[A-Z0-9_]+" );
355359
}
356360

357361
/**

core/esmf-aspect-model-java-generator/src/test/java/org/eclipse/esmf/aspectmodel/java/AspectModelJavaUtilTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static Stream<Arguments> generatedEnumKeysAreExpectedEnumNames() {
6464
Arguments.arguments( "SOME_ENUM", "SOME_ENUM" ),
6565
Arguments.arguments( "SomeEnum", "SOME_ENUM" ),
6666
Arguments.arguments( "aB", "A_B" ),
67-
Arguments.arguments( "aBc", "A_B_C" ),
67+
Arguments.arguments( "aBc", "AB_C" ),
6868
Arguments.arguments( "a_b_c", "A_B_C" )
6969
);
7070
}

0 commit comments

Comments
 (0)