Skip to content

Commit f715a62

Browse files
committed
Adjust some versions and namespaces after merge of main
Signed-off-by: Johannes Kristan <[email protected]>
1 parent aa1ece7 commit f715a62

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

core/esmf-aspect-model-aas-generator/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@
2828
<artifactId>esmf-aspect-meta-model-java</artifactId>
2929
</dependency>
3030
<dependency>
31-
<groupId>io.admin-shell.aas</groupId>
31+
<groupId>org.eclipse.digitaltwin.aas4j</groupId>
3232
<artifactId>model</artifactId>
3333
</dependency>
3434
<dependency>
35-
<groupId>io.admin-shell.aas</groupId>
35+
<groupId>org.eclipse.digitaltwin.aas4j</groupId>
3636
<artifactId>dataformat-xml</artifactId>
3737
</dependency>
3838
<dependency>
39-
<groupId>io.admin-shell.aas</groupId>
39+
<groupId>org.eclipse.digitaltwin.aas4j</groupId>
4040
<artifactId>dataformat-aasx</artifactId>
4141
</dependency>
4242
<dependency>

core/esmf-aspect-model-aas-generator/src/main/java/org/eclipse/esmf/aspectmodel/aas/AspectModelAASVisitor.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
import org.eclipse.digitaltwin.aas4j.v3.model.impl.DefaultSubmodelElementList;
7575
import org.eclipse.digitaltwin.aas4j.v3.model.impl.DefaultValueList;
7676
import org.eclipse.digitaltwin.aas4j.v3.model.impl.DefaultValueReferencePair;
77+
import org.eclipse.esmf.aspectmodel.urn.AspectModelUrn;
7778
import org.slf4j.Logger;
7879
import org.slf4j.LoggerFactory;
7980

@@ -226,7 +227,7 @@ public Environment visitAspect( final Aspect aspect, Context context ) {
226227
}
227228

228229
private List<SubmodelElement> visitOperations(
229-
final List<io.openmanufacturing.sds.metamodel.Operation> elements, final Context context ) {
230+
final List<org.eclipse.esmf.metamodel.Operation> elements, final Context context ) {
230231
return elements.stream().map( i -> mapText( i, context ) ).collect( Collectors.toList() );
231232
}
232233

@@ -250,9 +251,9 @@ private Optional<SubmodelElement> mapText( final Property property, final Contex
250251
if ( property.isOptional() ) {
251252
LOG.warn( String.format( "Having a recursive Property %s which is optional. Will be excluded from AAS mapping.",
252253
property.getAspectModelUrn().map( AspectModelUrn::toString ).orElse( "(unknown)" ) ) );
253-
return defaultResultForProperty.get();
254+
return Optional.of(defaultResultForProperty.get());
254255
} else {
255-
throw new IllegalArgumentException( String.format( "Having a recursive Property %s which is not optional is not valid.",
256+
LOG.error( String.format( "Having a recursive property: %s which is not optional is not valid. Check the model. Property will be excluded from AAS mapping.",
256257
property.getAspectModelUrn().map( AspectModelUrn::toString ).orElse( "(unknown)" ) ) );
257258
}
258259
return defaultResultForProperty;
@@ -344,7 +345,7 @@ private OperationVariable mapOperationVariable( final Property property, final C
344345
return new DefaultOperationVariable.Builder().value( mapText( property, context ).orElseThrow() ).build();
345346
}
346347

347-
private List<LangStringTextType> mapText( final Set<io.openmanufacturing.sds.metamodel.datatypes.LangString> localizedStrings ) {
348+
private List<LangStringTextType> mapText( final Set<org.eclipse.esmf.metamodel.datatypes.LangString> localizedStrings ) {
348349
return localizedStrings.stream()
349350
.map( this::mapText )
350351
.collect( Collectors.toList() );
@@ -356,19 +357,19 @@ private List<LangStringNameType> mapName( final Set<org.eclipse.esmf.metamodel.d
356357
.collect( Collectors.toList() );
357358
}
358359

359-
private LangStringTextType mapText( final io.openmanufacturing.sds.metamodel.datatypes.LangString langString ) {
360+
private LangStringTextType mapText( final org.eclipse.esmf.metamodel.datatypes.LangString langString ) {
360361
return createLangStringTextType( langString.getLanguageTag().getLanguage(), langString.getValue() );
361362
}
362363

363-
private LangStringNameType mapName( final io.openmanufacturing.sds.metamodel.datatypes.LangString langString ) {
364+
private LangStringNameType mapName( final org.eclipse.esmf.metamodel.datatypes.LangString langString ) {
364365
return createLangStringNameType( langString.getLanguageTag().getLanguage(), langString.getValue() );
365366
}
366367

367-
private LangStringDefinitionTypeIec61360 mapDefinitionIec61360( final io.openmanufacturing.sds.metamodel.datatypes.LangString langString ) {
368+
private LangStringDefinitionTypeIec61360 mapDefinitionIec61360( final org.eclipse.esmf.metamodel.datatypes.LangString langString ) {
368369
return createLangStringDefinitionTypeIec61360( langString.getLanguageTag().getLanguage(), langString.getValue() );
369370
}
370371

371-
private LangStringPreferredNameTypeIec61360 mapLangStringPreferredNameTypeIec61360( final io.openmanufacturing.sds.metamodel.datatypes.LangString langString ) {
372+
private LangStringPreferredNameTypeIec61360 mapLangStringPreferredNameTypeIec61360( final org.eclipse.esmf.metamodel.datatypes.LangString langString ) {
372373
return createLangStringPreferredNameTypeIec61360( langString.getLanguageTag().getLanguage(), langString.getValue() );
373374
}
374375

core/esmf-aspect-model-aas-generator/src/test/java/org/eclipse/esmf/aspectmodel/aas/AspectModelAASGeneratorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@
4242
import org.eclipse.digitaltwin.aas4j.v3.model.SubmodelElement;
4343
import org.eclipse.digitaltwin.aas4j.v3.model.SubmodelElementCollection;
4444
import org.eclipse.digitaltwin.aas4j.v3.model.SubmodelElementList;
45+
import org.eclipse.esmf.samm.KnownVersion;
4546
import org.junit.jupiter.api.Test;
4647
import org.junit.jupiter.params.ParameterizedTest;
4748
import org.junit.jupiter.params.provider.EnumSource;
4849
import org.xml.sax.SAXException;
4950

50-
import org.eclipse.esmf.aspectmetamodel.KnownVersion;
5151
import org.eclipse.esmf.aspectmodel.resolver.services.VersionedModel;
5252
import org.eclipse.esmf.metamodel.Aspect;
5353
import org.eclipse.esmf.metamodel.loader.AspectModelLoader;

0 commit comments

Comments
 (0)