-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
acknowledgedHas been viewed by one of the maintainers and is ready for further work, discussion or other steps.Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.bugSomething isn't workingSomething isn't working
Description
io.admin-shell.idta.carbon_footprint.zip
How: List of performed steps
Generate aasx from the file in attachment
The following bugfixes are needed:
- SML and Element of Type "Property" within SML have the same semanticId and description etc.: If there is a set or list (SubmodelElementCollection or Property within a SubmodelElementList) then the semanticId of the element is the one of the Entity or Quantifiable within the set or list etc. but not of the list again. (Example
pcfCalculationMethods
) - The identifier of the SML shall be the one of the property with the Characteristic Set, it is not the name of the Characteristic itself (Example
productCarbonFootprints
andurn:samm:io.admin-shell.idta.carbon_footprint:1.0.0#ProductCarbonFootprintSet
) - The SMC within the SML does not have a semanticId, only a supplementalSemanticId from the see-Attribute. The semanticId is the identifier of the Entity (example
productCarbonFootprints
) - idShort of SMC within SML is the same as for the SML, it shall be the element name of the Entity - although this is not very usual but there is not other name... and it even not possible to define a payload name here... (here it would be CarbonFootprintEntity: this is not a suitable property name)
- The payload name shall be the idShort of the generated aasx, not the name of the element (see [Task] SAMM2AASX Take payload names into account #769)
- A see attribute like
samm:see <0173-1%2302-ABG854%23003> ;
leads to a supplmental semantic ID like "file:///C:/__git/bosch-semantic-stack.rbs-aspect-models/src/main/resources/aspects/cli/0173-1%2302" this is incorrect. The see attribute is wrong and needs to be "urn:irdi:0173-1%2302-ABG854%23003> but it is strange that it lead to such entries in the generated file. The validator did not find that the see attribute has wrong format.
see also #796 for semanticId of SMC that seem to be missing in general.
not clear:
- why are the properties of externalPcfApi not generated at all?
- why are the properties of productOr'SectorSpecificPcfInformation not generated at all?
USED:
samm-cli - Semantic Aspect Meta Model Command Line Tool
Version: 2.10.3
Build date: 2025-05-08T14:47:57Z
Git commit: 192116d
Metadata
Metadata
Assignees
Labels
acknowledgedHas been viewed by one of the maintainers and is ready for further work, discussion or other steps.Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.bugSomething isn't workingSomething isn't working