Skip to content

Commit 042b415

Browse files
committed
Update documentation and Quantity model
1 parent dc9f18e commit 042b415

File tree

4 files changed

+24
-43
lines changed

4 files changed

+24
-43
lines changed

documentation/modules/ROOT/examples/aspect-sample.ttl

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -78,25 +78,11 @@
7878
# tag::quantity-declaration[]
7979
:Parameter a samm:Entity ;
8080
samm:extends samm-e:Quantity ;
81-
samm:properties ( :parameterValue :parameterUnit ) .
82-
83-
:parameterValue a samm:Property ;
84-
samm:characteristic :ParameterValueCharacteristic .
85-
81+
samm:properties (
82+
[ samm:extends samm-e:value ; samm:characteristic :ParameterValueCharacteristic ]
83+
) .
8684
:ParameterValueCharacteristic a samm:Characteristic ;
8785
samm:dataType xsd:integer .
88-
89-
:parameterUnit a samm:Property ;
90-
samm:characteristic samm-c:UnitReference .
91-
92-
:ProcessParameterDetails a samm:Entity ;
93-
samm:properties ( :parameter ) .
94-
95-
:parameter a samm:Property ;
96-
samm:characteristic [
97-
a samm-c:SingleEntity ;
98-
samm:dataType :Parameter ;
99-
] .
10086
# end::quantity-declaration[]
10187

10288
# tag::enumeration-simple-declaration-string[]

esmf-semantic-aspect-meta-model/src/main/resources/samm/entity/2.2.0/Quantity.ttl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414
@prefix samm-e: <urn:samm:org.eclipse.esmf.samm:entity:2.2.0#> .
1515

1616
samm-e:Quantity a samm:AbstractEntity ;
17-
samm:description "A numeric value and the physical unit of the value"@en ;
18-
samm:properties ( samm-e:value samm-e:unit ) .
17+
samm:preferredName "Quantity"@en ;
18+
samm:description "A numeric value and the physical unit of the value."@en ;
19+
samm:properties ( samm-e:value samm-e:unit ) .
1920

2021
samm-e:unit a samm:Property ;
21-
samm:characteristic samm-c:UnitReference .
22+
samm:characteristic samm-c:UnitReference .
23+

esmf-semantic-aspect-meta-model/src/test/java/org/eclipse/esmf/samm/AbstractShapeTest.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,19 @@
1616
import static org.assertj.core.api.Assertions.assertThat;
1717

1818
import java.io.StringWriter;
19+
import java.util.ArrayList;
1920
import java.util.HashMap;
2021
import java.util.List;
2122
import java.util.Map;
2223
import java.util.stream.Stream;
2324

24-
import org.apache.jena.rdf.model.Model;
25-
2625
import org.eclipse.esmf.samm.validation.ModelLoader;
2726
import org.eclipse.esmf.samm.validation.SemanticError;
2827
import org.eclipse.esmf.samm.validation.ValidationReport;
2928
import org.eclipse.esmf.samm.validation.Validator;
3029

30+
import org.apache.jena.rdf.model.Model;
31+
3132
public abstract class AbstractShapeTest {
3233
final static String TEST_NAMESPACE = "org.eclipse.esmf.test";
3334
final static String TEST_NAMESPACE_VERSION = "1.0.0";
@@ -134,7 +135,7 @@ protected static Stream<KnownVersion> versionsUpToIncluding1_0_0() {
134135
+ "Property's '{$this}' Characteristic's dataType.";
135136

136137
Model loadMetaModelDefinitions( final KnownVersion version ) {
137-
return ModelLoader.createModel( List.of(
138+
List<String> files = new ArrayList<>( List.of(
138139
"samm/meta-model/" + version.toVersionString() + "/aspect-meta-model-definitions.ttl",
139140
"samm/meta-model/" + version.toVersionString() + "/type-conversions.ttl",
140141
"samm/characteristic/" + version.toVersionString() + "/characteristic-definitions.ttl",
@@ -144,6 +145,12 @@ Model loadMetaModelDefinitions( final KnownVersion version ) {
144145
"samm/entity/" + version.toVersionString() + "/Point3d.ttl",
145146
"samm/unit/" + version.toVersionString() + "/units.ttl"
146147
) );
148+
149+
if ( version.isNewerThan( KnownVersion.SAMM_2_1_0 ) ) {
150+
files.add( "samm/entity/" + version.toVersionString() + "/Quantity.ttl" );
151+
}
152+
153+
return ModelLoader.createModel( files );
147154
}
148155

149156
protected void checkValidity( final String path, final String ttlDefinition, final KnownVersion testedVersion ) {

esmf-semantic-aspect-meta-model/src/test/resources/samm_2_2_0/quantity/org.eclipse.esmf.test/1.0.0/QuantityTestEntity.ttl

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,30 +11,16 @@
1111
# SPDX-License-Identifier: MPL-2.0
1212
#
1313
@prefix : <urn:samm:org.eclipse.esmf.samm.test:1.0.0#> .
14-
@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.2.0#> .
1514
@prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.2.0#> .
15+
@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.2.0#> .
1616
@prefix samm-e: <urn:samm:org.eclipse.esmf.samm:entity:2.2.0#> .
17-
@prefix unit: <urn:samm:org.eclipse.esmf.samm:unit:2.2.0#> .
1817
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
1918

2019
:Parameter a samm:Entity ;
21-
samm:extends samm-e:Quantity ;
22-
samm:properties ( :parameterValue :parameterUnit ) .
23-
24-
:parameterValue a samm:Property ;
25-
samm:characteristic :ParameterValueCharacteristic .
20+
samm:extends samm-e:Quantity ;
21+
samm:properties (
22+
[ samm:extends samm-e:value ; samm:characteristic :ParameterValueCharacteristic ]
23+
) .
2624

2725
:ParameterValueCharacteristic a samm:Characteristic ;
28-
samm:dataType xsd:integer .
29-
30-
:parameterUnit a samm:Property ;
31-
samm:characteristic samm-c:UnitReference .
32-
33-
:ProcessParameterDetails a samm:Entity ;
34-
samm:properties ( :parameter ) .
35-
36-
:parameter a samm:Property ;
37-
samm:characteristic [
38-
a samm-c:SingleEntity ;
39-
samm:dataType :Parameter ;
40-
] .
26+
samm:dataType xsd:integer .

0 commit comments

Comments
 (0)