Update value min count

Author: Yauhenikapl

documentation/modules/ROOT/pages/modeling-guidelines.adoc

@@ -165,8 +165,8 @@ that all model elements have], Properties have the following attributes:
 | `samm:exampleValue` | An exemplary value that the Property can take, helping to clarify the intended meaning of the Property.
 This attribute supports both scalar literal values (e.g., xsd:string, xsd:float), an anonymous described scalar value,
 and value references that point to example values (i.e., references to instances of xref:modeling-guidelines.adoc#value-type[samm:Value]).
-enriched with semantic metadata). In either case, the data type of the `samm:exampleValue` must be convertible to
-the effective data type defined by the Property's Characteristic. For example, if the Characteristic's `samm:dataType`
+In either case, the data type of the `samm:exampleValue` must be convertible to the effective data type defined by the Property's Characteristic.
+For example, if the Characteristic's `samm:dataType`
 is `xsd:int`, a value with the type `xsd:short` is also acceptable. Refer to section xref:datatypes.adoc#implicit-conversions[Implicit Conversions]
 for more details. | {nok}
 |===

esmf-semantic-aspect-meta-model/src/main/resources/samm/meta-model/2.2.0/aspect-meta-model-shapes.ttl

@@ -1032,7 +1032,7 @@ samm:ValueShape
   sh:targetClass samm:Value ;
   sh:property [
     sh:path samm:value ;
-    sh:minCount 0 ;
+    sh:minCount 1 ;
     sh:maxCount 1 ;
     sh:name "value" ;
     sh:description "A single constant value or link to another resource." ;

esmf-semantic-aspect-meta-model/src/test/java/org/eclipse/esmf/samm/ValueTest.java

@@ -1,37 +1,48 @@
 package org.eclipse.esmf.samm;
 
+import org.eclipse.esmf.samm.validation.SemanticError;
+
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
 
 class ValueTest extends AbstractShapeTest {
 
    @ParameterizedTest
    @MethodSource( value = "versionsStartingWith2_2_0" )
-   void defaultValueDefinition ( final KnownVersion metaModelVersion ) {
+   void defaultValueDefinition( final KnownVersion metaModelVersion ) {
       checkValidity( "value-shape", "DefaultValue", metaModelVersion );
    }
 
+   @ParameterizedTest
+   @MethodSource( "versionsStartingWith2_2_0" )
+   void invalidValueDeclarationExpectedFailure( KnownVersion metaModelVersion ) {
+      final SemanticError expectedError = new SemanticError( "Property needs to have at least 1 values, but found 0",
+            testNamespacePrefix + "GreenLight", "urn:samm:org.eclipse.esmf.samm:meta-model:2.2.0#value", violationUrn, "" );
+
+      expectSemanticValidationErrors( "value-shape", "InvalidValueDeclaration", metaModelVersion, expectedError );
+   }
+
    @ParameterizedTest
    @MethodSource( value = "versionsStartingWith2_2_0" )
-   void valueWithEnumeration ( final KnownVersion metaModelVersion ) {
+   void valueWithEnumeration( final KnownVersion metaModelVersion ) {
       checkValidity( "value-shape", "ValueWithEnumeration", metaModelVersion );
    }
 
    @ParameterizedTest
    @MethodSource( value = "versionsStartingWith2_2_0" )
-   void multipleValueWithEnumeration ( final KnownVersion metaModelVersion ) {
+   void multipleValueWithEnumeration( final KnownVersion metaModelVersion ) {
       checkValidity( "value-shape", "MultipleValueWithEnumeration", metaModelVersion );
    }
 
    @ParameterizedTest
    @MethodSource( value = "versionsStartingWith2_2_0" )
-   void referenceValueWithProperty ( final KnownVersion metaModelVersion ) {
+   void referenceValueWithProperty( final KnownVersion metaModelVersion ) {
       checkValidity( "value-shape", "ReferenceValueWithProperty", metaModelVersion );
    }
 
    @ParameterizedTest
    @MethodSource( value = "versionsStartingWith2_2_0" )
-   void anonymousDescribedValueInExampleValue ( final KnownVersion metaModelVersion ) {
+   void anonymousDescribedValueInExampleValue( final KnownVersion metaModelVersion ) {
       checkValidity( "value-shape", "AnonymousDescribedValueInExampleValue", metaModelVersion );
    }
 }

esmf-semantic-aspect-meta-model/src/test/resources/samm_2_2_0/value-shape/org.eclipse.esmf.test/1.0.0/InvalidValueDeclaration.ttl

@@ -0,0 +1,21 @@
+#
+# Copyright (c) 2025 Robert Bosch Manufacturing Solutions GmbH
+#
+# See the AUTHORS file(s) distributed with this work for additional
+# information regarding authorship.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at https://mozilla.org/MPL/2.0/.
+#
+# SPDX-License-Identifier: MPL-2.0
+#
+@prefix : <urn:samm:org.eclipse.esmf.samm.test:1.0.0#> .
+@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.2.0#> .
+@prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.2.0#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+
+:GreenLight a samm:Value ;
+   samm:preferredName "Normal"@en ;
+   samm:description "Indicates that the speed of position change is within specification."@en ;
+   samm:see <https://en.wikipedia.org/wiki/Traffic_light> .