Skip to content

Commit 18564bc

Browse files
ptzieglerazoitl
authored andcommitted
Remove usage of deprecated CommandStackListener in example editors
The example editors override the deprecated commandStackChanged() method to manage the "dirty" flag of the editor. For backwards-compatibility, this method is call by the non-deprecated stackChanged method. Contributes to #778
1 parent 2cb016e commit 18564bc

File tree

3 files changed

+10
-10
lines changed
  • org.eclipse.gef.examples.logic/src/org/eclipse/gef/examples/logicdesigner
  • org.eclipse.gef.examples.shapes/src/org/eclipse/gef/examples/shapes
  • org.eclipse.gef.examples.text/src/org/eclipse/gef/examples/text

3 files changed

+10
-10
lines changed

org.eclipse.gef.examples.logic/src/org/eclipse/gef/examples/logicdesigner/LogicEditor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.io.ObjectOutputStream;
2121
import java.io.OutputStream;
2222
import java.util.ArrayList;
23-
import java.util.EventObject;
2423
import java.util.List;
2524

2625
import org.eclipse.swt.SWT;
@@ -94,6 +93,7 @@
9493
import org.eclipse.gef.RootEditPart;
9594
import org.eclipse.gef.SnapToGeometry;
9695
import org.eclipse.gef.SnapToGrid;
96+
import org.eclipse.gef.commands.CommandStackEvent;
9797
import org.eclipse.gef.dnd.TemplateTransferDragSourceListener;
9898
import org.eclipse.gef.dnd.TemplateTransferDropTargetListener;
9999
import org.eclipse.gef.editparts.ScalableFreeformRootEditPart;
@@ -427,9 +427,9 @@ protected void closeEditor(boolean save) {
427427
}
428428

429429
@Override
430-
public void commandStackChanged(EventObject event) {
430+
public void stackChanged(CommandStackEvent event) {
431431
firePropertyChange(IEditorPart.PROP_DIRTY);
432-
super.commandStackChanged(event);
432+
super.stackChanged(event);
433433
}
434434

435435
@Override

org.eclipse.gef.examples.shapes/src/org/eclipse/gef/examples/shapes/ShapesEditor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.io.ObjectOutputStream;
2020
import java.io.OutputStream;
2121
import java.lang.reflect.InvocationTargetException;
22-
import java.util.EventObject;
2322

2423
import org.eclipse.swt.widgets.Composite;
2524
import org.eclipse.swt.widgets.Control;
@@ -48,6 +47,7 @@
4847
import org.eclipse.gef.DefaultEditDomain;
4948
import org.eclipse.gef.EditPartViewer;
5049
import org.eclipse.gef.GraphicalViewer;
50+
import org.eclipse.gef.commands.CommandStackEvent;
5151
import org.eclipse.gef.dnd.TemplateTransferDragSourceListener;
5252
import org.eclipse.gef.dnd.TemplateTransferDropTargetListener;
5353
import org.eclipse.gef.editparts.ScalableFreeformRootEditPart;
@@ -118,9 +118,9 @@ protected void configureGraphicalViewer() {
118118
* .EventObject)
119119
*/
120120
@Override
121-
public void commandStackChanged(EventObject event) {
121+
public void stackChanged(CommandStackEvent event) {
122122
firePropertyChange(IEditorPart.PROP_DIRTY);
123-
super.commandStackChanged(event);
123+
super.stackChanged(event);
124124
}
125125

126126
private void createOutputStream(OutputStream os) throws IOException {

org.eclipse.gef.examples.text/src/org/eclipse/gef/examples/text/TextEditor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2004, 2023 IBM Corporation and others.
2+
* Copyright (c) 2004, 2025 IBM Corporation and others.
33
*
44
* This program and the accompanying materials are made available under the
55
* terms of the Eclipse Public License 2.0 which is available at
@@ -19,7 +19,6 @@
1919
import java.io.InputStream;
2020
import java.io.ObjectInputStream;
2121
import java.io.ObjectOutputStream;
22-
import java.util.EventObject;
2322

2423
import org.eclipse.swt.SWT;
2524
import org.eclipse.swt.widgets.Composite;
@@ -47,6 +46,7 @@
4746
import org.eclipse.gef.MouseWheelHandler;
4847
import org.eclipse.gef.MouseWheelZoomHandler;
4948
import org.eclipse.gef.commands.CommandStack;
49+
import org.eclipse.gef.commands.CommandStackEvent;
5050
import org.eclipse.gef.editparts.ScalableRootEditPart;
5151
import org.eclipse.gef.tools.SelectionTool;
5252
import org.eclipse.gef.ui.actions.ActionRegistry;
@@ -130,9 +130,9 @@ public void createControl(Composite parent) {
130130
}
131131

132132
@Override
133-
public void commandStackChanged(EventObject event) {
133+
public void stackChanged(CommandStackEvent event) {
134134
firePropertyChange(PROP_DIRTY);
135-
super.commandStackChanged(event);
135+
super.stackChanged(event);
136136
}
137137

138138
/**

0 commit comments

Comments
 (0)