Deprecate ScaledGraphics

All scaling needs for Draw2d can be handled by SWT natively and there
are several issues in the implementation of ScaledGraphics.

Author: azoitl

CHANGELOG.md

@@ -5,6 +5,20 @@
 
 - Added new PrecisionPointList class. This class was created during the previous
   release and has now been finalized.
+- **Deprecated ScaledGraphics**  
+  *To be removed after 2028-03 release*   
+  All scaling needs for Draw2d can be handled by SWT natively and there are several issues in the implementation of 
+  ScaledGraphics. Therefore, use `SWTGraphics` instead.   
+  
+  As part of this deprecation also all methods and flags allowing to switch to between `SWTGraphics` and 
+  `ScaledGraphics` are deprecated and the default behavior is changed to use `SWTGraphics`.
+  
+  **Action Required:** If your application depends on `ScaledGraphics` you need to actively switch it on for the following classes:
+    - ScaleableFreeformLayeredPane
+    - ScalableFreeformRootEditPart
+    - ScalableLayeredPane
+    - ScalableRootEditPart
+    - ScalableLightweightSystem
 
 ## GEF
 

org.eclipse.draw2d.tests/src/org/eclipse/draw2d/test/ScaledGraphicsTest.java

@@ -38,6 +38,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 
+@SuppressWarnings("removal")
 public class ScaledGraphicsTest {
 
 	static Stream<Arguments> singleValueTestCombinations() {

org.eclipse.draw2d/src/org/eclipse/draw2d/AutoscaleFreeformViewport.java

@@ -22,6 +22,7 @@
  */
 public class AutoscaleFreeformViewport extends FreeformViewport {
 
+	@SuppressWarnings("removal")
 	public AutoscaleFreeformViewport(boolean useScaledGraphics) {
 		super.setContents(new ScalableFreeformLayeredPane(useScaledGraphics));
 	}

org.eclipse.draw2d/src/org/eclipse/draw2d/IScalablePane.java

@@ -32,6 +32,11 @@
  */
 public interface IScalablePane extends ScalableFigure {
 
+	/**
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
+	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	boolean useScaledGraphics();
 
 	boolean optimizeClip();
@@ -42,6 +47,7 @@ public default Rectangle getScaledRect(Rectangle rect) {
 		return rect;
 	}
 
+	@SuppressWarnings("removal")
 	public static final class IScalablePaneHelper {
 
 		private static Graphics prepareScaledGraphics(final Graphics graphics, IScalablePane figurePane) {

org.eclipse.draw2d/src/org/eclipse/draw2d/PrinterGraphics.java

@@ -28,6 +28,7 @@
  *
  * @author danlee
  */
+@SuppressWarnings("removal")
 public class PrinterGraphics extends ScaledGraphics {
 
 	Map<Image, Image> imageCache = new HashMap<>();

org.eclipse.draw2d/src/org/eclipse/draw2d/ScalableFreeformLayeredPane.java

@@ -24,17 +24,25 @@ public class ScalableFreeformLayeredPane extends FreeformLayeredPane implements
 
 	private double scale = 1.0;
 
+	/**
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
+	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	private final boolean useScaledGraphics;
 
 	public ScalableFreeformLayeredPane() {
-		this(true);
+		this(false);
 	}
 
 	/**
 	 * Constructor which allows to configure if scaled graphics should be used.
 	 *
 	 * @since 3.13
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
 	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	public ScalableFreeformLayeredPane(boolean useScaledGraphics) {
 		this.useScaledGraphics = useScaledGraphics;
 	}
@@ -97,7 +105,10 @@ public void setScale(double newZoom) {
 
 	/**
 	 * @since 3.13
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
 	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	@Override
 	public boolean useScaledGraphics() {
 		return useScaledGraphics;

org.eclipse.draw2d/src/org/eclipse/draw2d/ScalableLayeredPane.java

@@ -27,17 +27,25 @@ public class ScalableLayeredPane extends LayeredPane implements IScalablePane {
 
 	private double scale = 1.0;
 
+	/**
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
+	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	private final boolean useScaledGraphics;
 
 	public ScalableLayeredPane() {
-		this(true);
+		this(false);
 	}
 
 	/**
 	 * Constructor which allows to configure if scaled graphics should be used.
 	 *
 	 * @since 3.13
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
 	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	public ScalableLayeredPane(boolean useScaledGraphics) {
 		this.useScaledGraphics = useScaledGraphics;
 	}
@@ -104,7 +112,10 @@ public void setScale(double newZoom) {
 
 	/**
 	 * @since 3.13
+	 * @deprecated will be deleted after the 2028-03 release (see
+	 *             {@link ScaledGraphics}).
 	 */
+	@Deprecated(forRemoval = true, since = "2026-03")
 	@Override
 	public boolean useScaledGraphics() {
 		return useScaledGraphics;

org.eclipse.draw2d/src/org/eclipse/draw2d/ScalableLightweightSystem.java

@@ -77,9 +77,14 @@ public double getScale() {
 			return scale;
 		}
 
+		/**
+		 * @deprecated will be deleted after the 2028-03 release (see
+		 *             {@link ScaledGraphics}).
+		 */
+		@Deprecated(forRemoval = true, since = "2026-03")
 		@Override
 		public boolean useScaledGraphics() {
-			return true;
+			return false;
 		}
 
 		@Override